From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [RFC v2 3/7] firmware: port built-in section to linker table Date: Mon, 2 May 2016 11:41:06 -0700 Message-ID: <20160502184106.GA17329@kroah.com> References: <1455889559-9428-1-git-send-email-mcgrof@kernel.org> <1455889559-9428-4-git-send-email-mcgrof@kernel.org> <1456740770.4666.366.camel@infradead.org> <20160229185606.GD25240@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:51521 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754969AbcEBSlH (ORCPT ); Mon, 2 May 2016 14:41:07 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Kees Cook Cc: "Luis R. Rodriguez" , David Woodhouse , "Luis R. Rodriguez" , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "x86@kernel.org" , LKML , Andy Lutomirski , Boris Ostrovsky , Rusty Russell , David Vrabel , Konrad Rzeszutek Wilk , mcb30@ipxe.org, jgross@suse.com, Ming Lei , Arnd Bergmann , linux-arch , Russell King - ARM Linux , "benh@kernel.crashing.org" , jbaron@akamai.com, "ananth@in.ibm.com" , anil.s.keshavamurthy@intel.com On Mon, May 02, 2016 at 11:34:33AM -0700, Kees Cook wrote: > On Mon, Feb 29, 2016 at 10:56 AM, Luis R. Rodriguez wrote: > > On Mon, Feb 29, 2016 at 10:12:50AM +0000, David Woodhouse wrote: > >> On Fri, 2016-02-19 at 05:45 -0800, Luis R. Rodriguez wrote: > >> > This ports built-in firmware to use linker tables, > >> > this replaces the custom section solution with a > >> > generic solution. > >> > > >> > This also demos the use of the .rodata (SECTION_RO) > >> > linker tables. > >> > > >> > Tested with 0 built-in firmware, 1 and 2 built-in > >> > firmwares successfully. > >> > >> I think we'd do better to rip this support out entirely. It just isn't > >> needed; firmware can live in an initramfs and don't even need *any* > >> actual running userspace support to load it from there these days, do > >> we? > > > > I think this is reasonable if and only if we really don't know of anyone > > out there not able to use initramfs. I'm happy to rip it out. > > The changelog for this doesn't say anything about _why_ the change is > being made? (and what about other architectures.) Also, Chrome OS > doesn't use an initramfs (and plenty of other things don't too). Being > able to build monolithic kernels (e.g. Android and Brillo) with > builtin firmware is very handy. Please don't remove built-in firmware > support. I second this, we can't break existing systems at all. I thought we were going to keep built-in firmware, right Luis? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:51521 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754969AbcEBSlH (ORCPT ); Mon, 2 May 2016 14:41:07 -0400 Date: Mon, 2 May 2016 11:41:06 -0700 From: Greg KH Subject: Re: [RFC v2 3/7] firmware: port built-in section to linker table Message-ID: <20160502184106.GA17329@kroah.com> References: <1455889559-9428-1-git-send-email-mcgrof@kernel.org> <1455889559-9428-4-git-send-email-mcgrof@kernel.org> <1456740770.4666.366.camel@infradead.org> <20160229185606.GD25240@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Kees Cook Cc: "Luis R. Rodriguez" , David Woodhouse , "Luis R. Rodriguez" , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "x86@kernel.org" , LKML , Andy Lutomirski , Boris Ostrovsky , Rusty Russell , David Vrabel , Konrad Rzeszutek Wilk , mcb30@ipxe.org, jgross@suse.com, Ming Lei , Arnd Bergmann , linux-arch , Russell King - ARM Linux , "benh@kernel.crashing.org" , jbaron@akamai.com, "ananth@in.ibm.com" , anil.s.keshavamurthy@intel.com, "David S. Miller" , Masami Hiramatsu , Andy Shevchenko , "xen-devel@lists.xensource.com" Message-ID: <20160502184106.Y7rkl7KV98_7HEm78vkkWrgUOAhIMuIAI1-oglSfyXo@z> On Mon, May 02, 2016 at 11:34:33AM -0700, Kees Cook wrote: > On Mon, Feb 29, 2016 at 10:56 AM, Luis R. Rodriguez wrote: > > On Mon, Feb 29, 2016 at 10:12:50AM +0000, David Woodhouse wrote: > >> On Fri, 2016-02-19 at 05:45 -0800, Luis R. Rodriguez wrote: > >> > This ports built-in firmware to use linker tables, > >> > this replaces the custom section solution with a > >> > generic solution. > >> > > >> > This also demos the use of the .rodata (SECTION_RO) > >> > linker tables. > >> > > >> > Tested with 0 built-in firmware, 1 and 2 built-in > >> > firmwares successfully. > >> > >> I think we'd do better to rip this support out entirely. It just isn't > >> needed; firmware can live in an initramfs and don't even need *any* > >> actual running userspace support to load it from there these days, do > >> we? > > > > I think this is reasonable if and only if we really don't know of anyone > > out there not able to use initramfs. I'm happy to rip it out. > > The changelog for this doesn't say anything about _why_ the change is > being made? (and what about other architectures.) Also, Chrome OS > doesn't use an initramfs (and plenty of other things don't too). Being > able to build monolithic kernels (e.g. Android and Brillo) with > builtin firmware is very handy. Please don't remove built-in firmware > support. I second this, we can't break existing systems at all. I thought we were going to keep built-in firmware, right Luis? thanks, greg k-h