From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Schwidefsky Subject: Re: [PATCH 11/14] s390/ptrace: run seccomp after ptrace Date: Fri, 10 Jun 2016 12:51:58 +0200 Message-ID: <20160610125158.16dd5497@mschwide> References: <1465506124-21866-1-git-send-email-keescook@chromium.org> <1465506124-21866-12-git-send-email-keescook@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1465506124-21866-12-git-send-email-keescook@chromium.org> Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Kees Cook Cc: linux-kernel@vger.kernel.org, Heiko Carstens , linux-s390@vger.kernel.org, Andy Lutomirski , Benjamin Herrenschmidt , Catalin Marinas , Chris Metcalf , Helge Deller , "James E.J. Bottomley" , James Hogan , Jeff Dike , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "Maciej W. Rozycki" , Mark Rutland , Michael Ellerman , Paul Mackerras , Ralf Baechle , Ri List-Id: linux-arch.vger.kernel.org On Thu, 9 Jun 2016 14:02:01 -0700 Kees Cook wrote: > Close the hole where ptrace can change a syscall out from under seccomp. > > Signed-off-by: Kees Cook > Cc: Heiko Carstens > Cc: Martin Schwidefsky > Cc: linux-s390@vger.kernel.org > --- > arch/s390/kernel/ptrace.c | 21 +++++++++------------ > 1 file changed, 9 insertions(+), 12 deletions(-) If the change in semantics in regard to the audit of skipped system calls is acceptable, the modified s390 arch code is ok. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:22254 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932124AbcFJKwN (ORCPT ); Fri, 10 Jun 2016 06:52:13 -0400 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u5AAoX3x040658 for ; Fri, 10 Jun 2016 06:52:12 -0400 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0b-001b2d01.pphosted.com with ESMTP id 23fm51txkh-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 10 Jun 2016 06:52:12 -0400 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 10 Jun 2016 11:52:10 +0100 Date: Fri, 10 Jun 2016 12:51:58 +0200 From: Martin Schwidefsky Subject: Re: [PATCH 11/14] s390/ptrace: run seccomp after ptrace In-Reply-To: <1465506124-21866-12-git-send-email-keescook@chromium.org> References: <1465506124-21866-1-git-send-email-keescook@chromium.org> <1465506124-21866-12-git-send-email-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID: <20160610125158.16dd5497@mschwide> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Kees Cook Cc: linux-kernel@vger.kernel.org, Heiko Carstens , linux-s390@vger.kernel.org, Andy Lutomirski , Benjamin Herrenschmidt , Catalin Marinas , Chris Metcalf , Helge Deller , "James E.J. Bottomley" , James Hogan , Jeff Dike , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "Maciej W. Rozycki" , Mark Rutland , Michael Ellerman , Paul Mackerras , Ralf Baechle , Richard Weinberger , Russell King , user-mode-linux-devel@lists.sourceforge.net, Will Deacon , x86@kernel.org Message-ID: <20160610105158.VAbr0ynZPadto0sR_Hruy_zgbl9IBY1-S8Ea1KHl4vc@z> On Thu, 9 Jun 2016 14:02:01 -0700 Kees Cook wrote: > Close the hole where ptrace can change a syscall out from under seccomp. > > Signed-off-by: Kees Cook > Cc: Heiko Carstens > Cc: Martin Schwidefsky > Cc: linux-s390@vger.kernel.org > --- > arch/s390/kernel/ptrace.c | 21 +++++++++------------ > 1 file changed, 9 insertions(+), 12 deletions(-) If the change in semantics in regard to the audit of skipped system calls is acceptable, the modified s390 arch code is ok. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.