From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Date: Thu, 16 Jun 2016 16:56:53 +0200 Message-ID: <20160616145653.GH30921@twins.programming.kicks-ass.net> References: <20160531101925.702692792@infradead.org> <20160531102642.333689893@infradead.org> <20160616101309.GD30921@twins.programming.kicks-ass.net> <20160616124949.GF30921@twins.programming.kicks-ass.net> <20160616143530.GG30921@twins.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from bombadil.infradead.org ([198.137.202.9]:46170 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754047AbcFPO5R (ORCPT ); Thu, 16 Jun 2016 10:57:17 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Andreas Schwab Cc: Geert Uytterhoeven , Linus Torvalds , Ingo Molnar , Thomas Gleixner , Will Deacon , Paul McKenney , boqun.feng@gmail.com, waiman.long@hpe.com, =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , "linux-kernel@vger.kernel.org" , Linux-Arch , Richard Henderson , Vineet Gupta , Russell King , Hans-Christian Noren Egtvedt , Miao Steven , Yoshinori Sato , Richard Kuo , Tony Luck , James Hogan , Ralf Baechle , David Howells Ja On Thu, Jun 16, 2016 at 04:37:36PM +0200, Andreas Schwab wrote: > Peter Zijlstra writes: > > > So the "2" input operand actually sets the value of "=&d" (tmp), how > > creative... > > That was the only way to do it when this was written. Fair enough; do you still support a compiler old enough to require this? If not, do you want me to 'fix' this or just remove the comment? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.9]:46170 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754047AbcFPO5R (ORCPT ); Thu, 16 Jun 2016 10:57:17 -0400 Date: Thu, 16 Jun 2016 16:56:53 +0200 From: Peter Zijlstra Subject: Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Message-ID: <20160616145653.GH30921@twins.programming.kicks-ass.net> References: <20160531101925.702692792@infradead.org> <20160531102642.333689893@infradead.org> <20160616101309.GD30921@twins.programming.kicks-ass.net> <20160616124949.GF30921@twins.programming.kicks-ass.net> <20160616143530.GG30921@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Andreas Schwab Cc: Geert Uytterhoeven , Linus Torvalds , Ingo Molnar , Thomas Gleixner , Will Deacon , Paul McKenney , boqun.feng@gmail.com, waiman.long@hpe.com, =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , "linux-kernel@vger.kernel.org" , Linux-Arch , Richard Henderson , Vineet Gupta , Russell King , Hans-Christian Noren Egtvedt , Miao Steven , Yoshinori Sato , Richard Kuo , Tony Luck , James Hogan , Ralf Baechle , David Howells , "James E.J. Bottomley" , Michael Ellerman , Martin Schwidefsky , Rich Felker , "David S. Miller" , cmetcalf@mellanox.com, Max Filippov , Arnd Bergmann , dbueso@suse.de, Wu Fengguang , linux-m68k Message-ID: <20160616145653.D4BL31L8v0wgRQjdDUnN0IOOlQmiQTkuZg52lCKRpdo@z> On Thu, Jun 16, 2016 at 04:37:36PM +0200, Andreas Schwab wrote: > Peter Zijlstra writes: > > > So the "2" input operand actually sets the value of "=&d" (tmp), how > > creative... > > That was the only way to do it when this was written. Fair enough; do you still support a compiler old enough to require this? If not, do you want me to 'fix' this or just remove the comment?