From: Steven Rostedt <rostedt@goodmis.org>
To: Torsten Duwe <duwe@lst.de>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
Petr Mladek <pmladek@suse.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
takahiro.akashi@linaro.org,
Jungseok Lee <jungseoklee85@gmail.com>,
Arnd Bergmann <arnd@arndb.de>, Li Bin <huawei.libin@huawei.com>,
Ingo Molnar <mingo@redhat.com>,
Christopher Li <sparse@chrisli.org>,
Jiri Kosina <jikos@kernel.org>,
andrew.wafaa@arm.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, live-patching@vger.kernel.org,
linux-arch@vger.kernel.org, linux-sparse@vger.kernel.org
Subject: Re: [PATCH v2 1/2] arm64: implement FTRACE_WITH_REGS
Date: Fri, 15 Jul 2016 14:36:16 -0400 [thread overview]
Message-ID: <20160715143616.5b3d063e@gandalf.local.home> (raw)
In-Reply-To: <20160709090632.GA2598@lst.de>
On Sat, 9 Jul 2016 11:06:32 +0200
Torsten Duwe <duwe@lst.de> wrote:
> Maybe the code in question can be replaced with the change below, now that
> there is a preprocessor define in V2?
> (untested)
>
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 3f743b1..695a646 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -2423,6 +2423,12 @@ ftrace_code_disable(struct module *mod, struct dyn_ftrace *rec)
> if (unlikely(ftrace_disabled))
> return 0;
>
> +#ifdef CC_USING_PROLOG_PAD
> + /* If the compiler already generated NOPs instead of
> + * calls to mcount, we're done here.
> + */
> + return 1;
> +#endif
I really hate adding #ifdef's like this in generic code if the arch can
handle it with some other means.
-- Steve
> ret = ftrace_make_nop(mod, rec, MCOUNT_ADDR);
> if (ret) {
> ftrace_bug(ret, rec);
next prev parent reply other threads:[~2016-07-15 18:36 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 15:15 [PATCH v2 0/2] arm64 live patching Torsten Duwe
2016-06-27 15:15 ` Torsten Duwe
2016-06-27 15:17 ` [PATCH v2 1/2] arm64: implement FTRACE_WITH_REGS Torsten Duwe
2016-06-27 15:17 ` Torsten Duwe
2016-07-01 12:53 ` Josh Poimboeuf
2016-07-01 12:53 ` Josh Poimboeuf
2016-07-04 9:18 ` Torsten Duwe
2016-07-04 9:18 ` Torsten Duwe
2016-07-03 5:17 ` kbuild test robot
2016-07-08 14:58 ` Petr Mladek
2016-07-08 14:58 ` Petr Mladek
2016-07-08 15:07 ` Torsten Duwe
2016-07-08 15:24 ` Petr Mladek
2016-07-08 15:24 ` Petr Mladek
2016-07-08 15:48 ` Josh Poimboeuf
2016-07-08 15:48 ` Josh Poimboeuf
2016-07-08 15:57 ` Steven Rostedt
2016-07-08 20:24 ` Torsten Duwe
2016-07-08 20:24 ` Torsten Duwe
2016-07-08 21:08 ` Steven Rostedt
2016-07-09 9:06 ` Torsten Duwe
2016-07-09 9:06 ` Torsten Duwe
2016-07-15 18:36 ` Steven Rostedt [this message]
2016-07-15 18:36 ` Steven Rostedt
2016-07-08 15:49 ` Steven Rostedt
2016-06-27 15:17 ` [PATCH v2 2/2] arm64: implement live patching Torsten Duwe
2016-06-27 15:17 ` Torsten Duwe
2016-07-11 14:03 ` Miroslav Benes
2016-07-11 14:03 ` Miroslav Benes
2016-07-11 21:58 ` Jessica Yu
2016-07-12 9:47 ` Miroslav Benes
2016-07-13 0:11 ` [PATCH] arm64: take SHN_LIVEPATCH syms into account when calculating plt_max_entries Jessica Yu
2016-07-13 0:11 ` Jessica Yu
2016-08-17 9:38 ` Miroslav Benes
2016-08-17 9:38 ` Miroslav Benes
2016-08-11 16:46 ` [PATCH v2 2/2] arm64: implement live patching Torsten Duwe
2016-08-11 16:46 ` Torsten Duwe
2016-07-15 16:03 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715143616.5b3d063e@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=andrew.wafaa@arm.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=duwe@lst.de \
--cc=huawei.libin@huawei.com \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=jungseoklee85@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pmladek@suse.com \
--cc=sparse@chrisli.org \
--cc=takahiro.akashi@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).