From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: James Hogan <james.hogan@imgtec.com>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH 4/5] s390: Define AT_VECTOR_SIZE_ARCH for ARCH_DLINFO
Date: Sun, 31 Jul 2016 08:23:04 -0400 [thread overview]
Message-ID: <20160731082304.05f4aad7@mschwide> (raw)
In-Reply-To: <1469462394-8970-5-git-send-email-james.hogan@imgtec.com>
On Mon, 25 Jul 2016 16:59:53 +0100
James Hogan <james.hogan@imgtec.com> wrote:
> AT_VECTOR_SIZE_ARCH should be defined with the maximum number of
> NEW_AUX_ENT entries that ARCH_DLINFO can contain, but it wasn't defined
> for s390 at all even though ARCH_DLINFO can contain one NEW_AUX_ENT when
> VDSO is enabled.
>
> This shouldn't be a problem as AT_VECTOR_SIZE_BASE includes space for
> AT_BASE_PLATFORM which s390 doesn't use, but lets define it now and add
> the comment above ARCH_DLINFO as found in several other architectures to
> remind future modifiers of ARCH_DLINFO to keep AT_VECTOR_SIZE_ARCH up to
> date.
>
> Fixes: b020632e40c3 ("[S390] introduce vdso on s390")
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> Cc: linux-s390@vger.kernel.org
The patch makes sense. I not quite sure about the checkpoint-restore code
that clears the last two entries of the user_auxv[] without knowing how
many aux entries there really are. That seems kind of strange.
I will the patch to our repositories and we'll give it a spin. If there
is no fallout I queue it to linux-s390.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2016-07-31 12:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 15:59 [PATCH 0/5] Define AT_VECTOR_SIZE_ARCH correctly James Hogan
2016-07-25 15:59 ` [PATCH 1/5] MIPS: Define AT_VECTOR_SIZE_ARCH for ARCH_DLINFO James Hogan
2016-07-25 15:59 ` [PATCH 2/5] ARM: " James Hogan
2016-07-25 15:59 ` James Hogan
2016-07-25 15:59 ` [PATCH 3/5] arm64: " James Hogan
2016-07-25 15:59 ` James Hogan
2016-07-25 15:59 ` [PATCH 4/5] s390: " James Hogan
2016-07-31 12:23 ` Martin Schwidefsky [this message]
2016-07-25 15:59 ` [PATCH 5/5] tile: " James Hogan
2016-07-25 16:37 ` Chris Metcalf
2016-07-25 19:10 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160731082304.05f4aad7@mschwide \
--to=schwidefsky@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=james.hogan@imgtec.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).