diff for duplicates of <20160808164828.GH12649@leverpostej> diff --git a/a/1.txt b/N1/1.txt index 5f5c369..75ab106 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -42,23 +42,3 @@ On Mon, Aug 08, 2016 at 12:03:38PM -0400, Chris Metcalf wrote: > ret > ENDPROC(cpu_do_idle) > + .popsection - -From a quick scan it looks like we only call this with interrupts -disabled, and we have no NMI. So shouldn't we be annotating -arch_cpu_idle(), which calls this and subsequently enables interrupts? - -I'm also not sure what you need to do for PSCI, which is the preferred -(FW-backed) idle mechanism for arm64. The infrastrucure for that is -spread over a few files: - - arch/arm64/kernel/sleep.S - arch/arm64/kernel/smccc-call.S - arch/arm64/kernel/suspend.c - drivers/cpuidle/cpuidle-arm.c - drivers/firmware/psci.c - -I'm not sure where we'd be an an interruptible state, and therefore I'm -not immediately sure what we should annotate. - -Thanks, -Mark. diff --git a/a/content_digest b/N1/content_digest index 85478ef..20ca784 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -63,26 +63,6 @@ "> \twfi\n" "> \tret\n" "> ENDPROC(cpu_do_idle)\n" - "> +\t.popsection\n" - "\n" - "From a quick scan it looks like we only call this with interrupts\n" - "disabled, and we have no NMI. So shouldn't we be annotating\n" - "arch_cpu_idle(), which calls this and subsequently enables interrupts?\n" - "\n" - "I'm also not sure what you need to do for PSCI, which is the preferred\n" - "(FW-backed) idle mechanism for arm64. The infrastrucure for that is\n" - "spread over a few files:\n" - "\n" - " arch/arm64/kernel/sleep.S\n" - " arch/arm64/kernel/smccc-call.S\n" - " arch/arm64/kernel/suspend.c\n" - " drivers/cpuidle/cpuidle-arm.c\n" - " drivers/firmware/psci.c\n" - "\n" - "I'm not sure where we'd be an an interruptible state, and therefore I'm\n" - "not immediately sure what we should annotate.\n" - "\n" - "Thanks,\n" - Mark. + "> +\t.popsection" -e4e507510e0064bc080b7c09f0e3d3e2a9edbbd1938f8050fba86975f88685aa +6de7ecd7471d3b0d64933895b56a6051c2a6dfc65804a49bc24fb95e75f78376
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox