From: Alan Modra <amodra@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linuxppc-dev@lists.ozlabs.org,
Nicholas Piggin <npiggin@gmail.com>,
linux-arch@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Nicolas Pitre <nico@linaro.org>,
linux-kbuild@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/5] kbuild: allow archs to select build for link dead code/data elimination
Date: Tue, 9 Aug 2016 09:20:16 +0930 [thread overview]
Message-ID: <20160808235016.GD20904@bubble.grove.modra.org> (raw)
In-Reply-To: <1882847.dG563Vieov@wuerfel>
On Mon, Aug 08, 2016 at 05:14:27PM +0200, Arnd Bergmann wrote:
> I have reverted that patch now, so ARM uses ".fixup" again like every
> other architecture does, and now "*(.fixup) *(.text .text.*)" works
> correctly, while ""*(.fixup) *(.text .fixup .text.*)" also fails
> the same way that I saw before:
That is really odd. The linker isn't supposed to treat those script
snippets differently. First match for .fixup wins.
$ cat > fixup1.s <<\EOF
.global _start
.text
_start:
.dc.a .L2
.L1:
.section ".fixup","ax",%progbits
.L2:
.dc.a .L1
EOF
$ cat > fixup2.s <<\EOF
.section ".text.xyz","ax",%progbits
.dc.a .L2
.L1:
.section ".fixup","ax",%progbits
.L2:
.dc.a .L1
EOF
$ cat > fixup.lnk <<\EOF
SECTIONS {
.text : { *(.fixup) *(.text .fixup .text.*) }
}
EOF
$ as -o fixup1.o fixup1.s
$ as -o fixup2.o fixup2.s
$ ld -o fixup -T fixup.lnk -Map fixup.map fixup1.o fixup2.o
$ cat fixup.map
Memory Configuration
Name Origin Length Attributes
*default* 0x0000000000000000 0xffffffffffffffff
Linker script and memory map
.text 0x0000000000000000 0x10
*(.fixup)
.fixup 0x0000000000000000 0x4 fixup1.o
.fixup 0x0000000000000004 0x4 fixup2.o
*(.text .fixup .text.*)
.text 0x0000000000000008 0x4 fixup1.o
0x0000000000000008 _start
.text 0x000000000000000c 0x0 fixup2.o
.text.xyz 0x000000000000000c 0x4 fixup2.o
[snip]
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2016-08-08 23:50 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 12:11 [RFC][PATCH 0/5] kbuild changes, thin archives, --gc-sections Nicholas Piggin
2016-08-05 12:11 ` Nicholas Piggin
2016-08-05 12:11 ` [PATCH 1/5] kbuild: allow architectures to use thin archives instead of ld -r Nicholas Piggin
2016-08-06 3:50 ` kbuild test robot
2016-08-06 3:50 ` kbuild test robot
2016-08-06 20:10 ` Sam Ravnborg
2016-08-07 1:49 ` Stephen Rothwell
2016-08-07 1:49 ` Stephen Rothwell
2016-08-07 3:34 ` Alan Modra
2016-08-07 4:17 ` Nicolas Pitre
2016-08-07 14:40 ` Sam Ravnborg
2016-08-07 14:40 ` Sam Ravnborg
2016-08-08 3:19 ` Nicholas Piggin
2016-08-08 4:46 ` Sam Ravnborg
2016-08-08 4:46 ` Sam Ravnborg
2016-08-08 3:25 ` Nicholas Piggin
2016-08-08 9:18 ` Arnd Bergmann
2016-08-08 9:18 ` Arnd Bergmann
2016-08-05 12:12 ` [PATCH 2/5] kbuild: allow archs to select build for link dead code/data elimination Nicholas Piggin
2016-08-05 12:12 ` Nicholas Piggin
2016-08-06 20:14 ` Sam Ravnborg
2016-08-08 3:29 ` Nicholas Piggin
2016-08-08 4:49 ` Sam Ravnborg
2016-08-07 5:33 ` Nicolas Pitre
2016-08-08 3:42 ` Nicholas Piggin
2016-08-08 3:42 ` Nicholas Piggin
2016-08-08 4:12 ` Nicolas Pitre
2016-08-08 4:12 ` Nicolas Pitre
2016-08-08 4:27 ` Nicholas Piggin
2016-08-07 9:57 ` Alan Modra
2016-08-07 9:57 ` Alan Modra
2016-08-07 11:35 ` Andreas Schwab
2016-08-07 11:35 ` Andreas Schwab
2016-08-07 20:26 ` Arnd Bergmann
2016-08-07 23:49 ` Alan Modra
2016-08-07 23:49 ` Alan Modra
2016-08-08 15:14 ` Arnd Bergmann
2016-08-08 23:50 ` Alan Modra [this message]
2016-08-09 22:10 ` Arnd Bergmann
2016-08-09 3:16 ` Andi Kleen
2016-08-09 3:16 ` Andi Kleen
2016-08-09 22:29 ` Arnd Bergmann
2016-08-09 22:29 ` Arnd Bergmann
2016-08-09 23:08 ` Andi Kleen
2016-08-10 0:37 ` Andi Kleen
2016-08-10 0:37 ` Andi Kleen
2016-08-05 12:12 ` [PATCH 3/5] kbuild: add arch specific post-module-link pass Nicholas Piggin
2016-08-05 12:12 ` Nicholas Piggin
2016-08-05 13:56 ` Nicholas Piggin
2016-08-06 20:16 ` Sam Ravnborg
2016-08-06 20:16 ` Sam Ravnborg
2016-08-08 3:30 ` Nicholas Piggin
2016-08-08 3:30 ` Nicholas Piggin
2016-08-05 12:12 ` [PATCH 4/5] powerpc: switch to using thin archives Nicholas Piggin
2016-08-05 12:12 ` Nicholas Piggin
2016-08-05 12:12 ` [PATCH 5/5] powerpc/64: use linker dce Nicholas Piggin
2016-08-05 13:32 ` [RFC][PATCH 0/5] kbuild changes, thin archives, --gc-sections Nicholas Piggin
2016-08-05 13:32 ` Nicholas Piggin
2016-08-07 20:23 ` Arnd Bergmann
2016-08-08 3:53 ` Nicholas Piggin
2016-08-08 3:53 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160808235016.GD20904@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=ak@linux.intel.com \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nico@linaro.org \
--cc=npiggin@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).