From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: S3 resume regression [1cf4f629d9d2 ("cpu/hotplug: Move online calls to hotplugged cpu")] Date: Thu, 27 Oct 2016 20:28:53 +0300 Message-ID: <20161027172852.GE4617@intel.com> References: <20160511133406.GC4329@intel.com> <20160516193910.GL4329@intel.com> <573BA5E2.5040506@intel.com> <20160518072424.GU4329@intel.com> <20160526183207.GX4329@intel.com> <20160531072650.GP4329@intel.com> <20160713145425.GB4329@intel.com> <20160809172057.GZ4329@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20160809172057.GZ4329@intel.com> Sender: linux-acpi-owner@vger.kernel.org To: Feng Tang Cc: feng.tang@intel.com, "Rafael J. Wysocki" , "Rafael J. Wysocki" , Steven Rostedt , Sebastian Andrzej Siewior , Thomas Gleixner , linux-arch@vger.kernel.org, Rik van Riel , "Srivatsa S. Bhat" , Peter Zijlstra , Arjan van de Ven , Rusty Russell , Oleg Nesterov , Tejun Heo , Andrew Morton , Paul McKenney , Linus Torvalds , Paul Turner , Linux Kernel Mailing List , "Zhang, Rui" List-Id: linux-arch.vger.kernel.org On Tue, Aug 09, 2016 at 08:20:57PM +0300, Ville Syrjälä wrote: > On Thu, Jul 14, 2016 at 04:29:42PM +0800, Feng Tang wrote: > > if you only want it to work, you can try an old patch > > https://bugzilla.kernel.org/attachment.cgi?id=76071 from a similar bug > > https://bugzilla.kernel.org/show_bug.cgi?id=41932 > > > > Alistair Buxton confirmed it work for 3.18 at least > > https://bugzilla.kernel.org/show_bug.cgi?id=107151#c16 > > That patch is a bit too ripe by now. Would need a fresh squeezed one. Since no one else bothered to refresh the patch I did it myself: diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c index f6aae7977824..d73d094a8972 100644 --- a/kernel/time/tick-broadcast.c +++ b/kernel/time/tick-broadcast.c @@ -657,8 +657,16 @@ static void tick_handle_oneshot_broadcast(struct clock_event_device *dev) * - There are pending events on sleeping CPUs which were not * in the event mask */ - if (next_event.tv64 != KTIME_MAX) + if (next_event.tv64 != KTIME_MAX) { + s64 delta = next_event.tv64 - now.tv64; + + if (delta >= 10000000000) { + printk(KERN_CRIT "%s(): The delta is big: %lld\n", __func__, delta); + next_event.tv64 = now.tv64 + 3000000000; + } + tick_broadcast_set_event(dev, next_cpu, next_event); + } raw_spin_unlock(&tick_broadcast_lock); Unfortunately it doesn't do anything for me. The fortunate thing is that acpi-idle has magically been fixed in the meantime, so I can at least go back to using that one and have working S3. -- Ville Syrjälä Intel OTC From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com ([134.134.136.24]:51304 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935238AbcJ0R3G (ORCPT ); Thu, 27 Oct 2016 13:29:06 -0400 Date: Thu, 27 Oct 2016 20:28:53 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: S3 resume regression [1cf4f629d9d2 ("cpu/hotplug: Move online calls to hotplugged cpu")] Message-ID: <20161027172852.GE4617@intel.com> References: <20160511133406.GC4329@intel.com> <20160516193910.GL4329@intel.com> <573BA5E2.5040506@intel.com> <20160518072424.GU4329@intel.com> <20160526183207.GX4329@intel.com> <20160531072650.GP4329@intel.com> <20160713145425.GB4329@intel.com> <20160809172057.GZ4329@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160809172057.GZ4329@intel.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Feng Tang Cc: feng.tang@intel.com, "Rafael J. Wysocki" , "Rafael J. Wysocki" , Steven Rostedt , Sebastian Andrzej Siewior , Thomas Gleixner , linux-arch@vger.kernel.org, Rik van Riel , "Srivatsa S. Bhat" , Peter Zijlstra , Arjan van de Ven , Rusty Russell , Oleg Nesterov , Tejun Heo , Andrew Morton , Paul McKenney , Linus Torvalds , Paul Turner , Linux Kernel Mailing List , "Zhang, Rui" , Len Brown , Linux PM , Linux ACPI Message-ID: <20161027172853.edue6ki4k76ZZY8OoFyDe7P6d1dhgcKObqo0an6x_fU@z> On Tue, Aug 09, 2016 at 08:20:57PM +0300, Ville Syrjälä wrote: > On Thu, Jul 14, 2016 at 04:29:42PM +0800, Feng Tang wrote: > > if you only want it to work, you can try an old patch > > https://bugzilla.kernel.org/attachment.cgi?id=76071 from a similar bug > > https://bugzilla.kernel.org/show_bug.cgi?id=41932 > > > > Alistair Buxton confirmed it work for 3.18 at least > > https://bugzilla.kernel.org/show_bug.cgi?id=107151#c16 > > That patch is a bit too ripe by now. Would need a fresh squeezed one. Since no one else bothered to refresh the patch I did it myself: diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c index f6aae7977824..d73d094a8972 100644 --- a/kernel/time/tick-broadcast.c +++ b/kernel/time/tick-broadcast.c @@ -657,8 +657,16 @@ static void tick_handle_oneshot_broadcast(struct clock_event_device *dev) * - There are pending events on sleeping CPUs which were not * in the event mask */ - if (next_event.tv64 != KTIME_MAX) + if (next_event.tv64 != KTIME_MAX) { + s64 delta = next_event.tv64 - now.tv64; + + if (delta >= 10000000000) { + printk(KERN_CRIT "%s(): The delta is big: %lld\n", __func__, delta); + next_event.tv64 = now.tv64 + 3000000000; + } + tick_broadcast_set_event(dev, next_cpu, next_event); + } raw_spin_unlock(&tick_broadcast_lock); Unfortunately it doesn't do anything for me. The fortunate thing is that acpi-idle has magically been fixed in the meantime, so I can at least go back to using that one and have working S3. -- Ville Syrjälä Intel OTC