From mboxrd@z Thu Jan 1 00:00:00 1970 From: Feng Tang Subject: Re: S3 resume regression [1cf4f629d9d2 ("cpu/hotplug: Move online calls to hotplugged cpu")] Date: Wed, 9 Nov 2016 11:54:18 +0800 Message-ID: <20161109035418.GA18246@shbuild888> References: <20160809172057.GZ4329@intel.com> <20161027172852.GE4617@intel.com> <20161027192006.GF4617@intel.com> <20161027203745.GH4617@intel.com> <20161028155603.GI4617@intel.com> <20161101204737.GB4617@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from mga04.intel.com ([192.55.52.120]:25167 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750953AbcKIDrS (ORCPT ); Tue, 8 Nov 2016 22:47:18 -0500 Content-Disposition: inline In-Reply-To: <20161101204737.GB4617@intel.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: Thomas Gleixner , Feng Tang , "Rafael J. Wysocki" , "Wysocki, Rafael J" , Steven Rostedt , Sebastian Andrzej Siewior , "linux-arch@vger.kernel.org" , Rik van Riel , "Srivatsa S. Bhat" , Peter Zijlstra , Arjan van de Ven , Rusty Russell , Oleg Nesterov , Tejun Heo , Andrew Morton , Paul McKenney , Linus Torvalds , Paul Turner Linux Kernel Mailing List On Wed, Nov 02, 2016 at 04:47:37AM +0800, Ville Syrjälä wrote: > On Fri, Oct 28, 2016 at 08:58:41PM +0200, Thomas Gleixner wrote: > > On Fri, 28 Oct 2016, Ville Syrjälä wrote: > > > On Thu, Oct 27, 2016 at 10:41:18PM +0200, Thomas Gleixner wrote: > > > > On Thu, 27 Oct 2016, Ville Syrjälä wrote: > > > > > On Thu, Oct 27, 2016 at 09:25:05PM +0200, Thomas Gleixner wrote: > > > > > > So it would be interesting whether that hunk in resume_broadcast() is > > > > > > sufficient. > > > > > > > > > > So far it looks like the answer is yes. > > > > > > > > > > Looks to be about 5 seconds slower than acpi-idle in resuming, but > > > > > I suppose that's not all that surprising ;) > > > > > > > > Well, set it to 1msec then. If that works reliably then we really can do > > > > that unconditionally. There is no harm in firing a useless timer during > > > > resume once. > > > > > > I narrowed down the required timeout, and looks like 25ms is the > > > minimum that works. With 24ms I already started to have failures. So > > > maybe just bump it up by an order of magnitude to 250ms for some > > > safety margin? > > I left the thing running for the weekend and it failed 26 out of 16057 > times with the 25ms timeout. Looks like it takes ~5 minutes to resume > when it fails, but eventually it does come back. > Just came back from a travel. Yes, the 5 minutes delay may be due to the expiration of the HPET timer, counting from 0 to 0xffffffff for a 13M frequencey HPET takes about 300 seconds. After resume, it seems nobody arms it so my old patch forces to arm one event. Thanks, Feng From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com ([192.55.52.120]:25167 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750953AbcKIDrS (ORCPT ); Tue, 8 Nov 2016 22:47:18 -0500 Date: Wed, 9 Nov 2016 11:54:18 +0800 From: Feng Tang Subject: Re: S3 resume regression [1cf4f629d9d2 ("cpu/hotplug: Move online calls to hotplugged cpu")] Message-ID: <20161109035418.GA18246@shbuild888> References: <20160809172057.GZ4329@intel.com> <20161027172852.GE4617@intel.com> <20161027192006.GF4617@intel.com> <20161027203745.GH4617@intel.com> <20161028155603.GI4617@intel.com> <20161101204737.GB4617@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161101204737.GB4617@intel.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: Thomas Gleixner , Feng Tang , "Rafael J. Wysocki" , "Wysocki, Rafael J" , Steven Rostedt , Sebastian Andrzej Siewior , "linux-arch@vger.kernel.org" , Rik van Riel , "Srivatsa S. Bhat" , Peter Zijlstra , Arjan van de Ven , Rusty Russell , Oleg Nesterov , Tejun Heo , Andrew Morton , Paul McKenney , Linus Torvalds , Paul Turner , Linux Kernel Mailing List , "Zhang, Rui" , "Brown, Len" , Linux PM , Linux ACPI Message-ID: <20161109035418.MngHWRfpLNRFBJgiq7CEx6nGhfeeIilbDEJew44d1Bc@z> On Wed, Nov 02, 2016 at 04:47:37AM +0800, Ville Syrjälä wrote: > On Fri, Oct 28, 2016 at 08:58:41PM +0200, Thomas Gleixner wrote: > > On Fri, 28 Oct 2016, Ville Syrjälä wrote: > > > On Thu, Oct 27, 2016 at 10:41:18PM +0200, Thomas Gleixner wrote: > > > > On Thu, 27 Oct 2016, Ville Syrjälä wrote: > > > > > On Thu, Oct 27, 2016 at 09:25:05PM +0200, Thomas Gleixner wrote: > > > > > > So it would be interesting whether that hunk in resume_broadcast() is > > > > > > sufficient. > > > > > > > > > > So far it looks like the answer is yes. > > > > > > > > > > Looks to be about 5 seconds slower than acpi-idle in resuming, but > > > > > I suppose that's not all that surprising ;) > > > > > > > > Well, set it to 1msec then. If that works reliably then we really can do > > > > that unconditionally. There is no harm in firing a useless timer during > > > > resume once. > > > > > > I narrowed down the required timeout, and looks like 25ms is the > > > minimum that works. With 24ms I already started to have failures. So > > > maybe just bump it up by an order of magnitude to 250ms for some > > > safety margin? > > I left the thing running for the weekend and it failed 26 out of 16057 > times with the 25ms timeout. Looks like it takes ~5 minutes to resume > when it fails, but eventually it does come back. > Just came back from a travel. Yes, the 5 minutes delay may be due to the expiration of the HPET timer, counting from 0 to 0xffffffff for a 13M frequencey HPET takes about 300 seconds. After resume, it seems nobody arms it so my old patch forces to arm one event. Thanks, Feng