From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: S3 resume regression [1cf4f629d9d2 ("cpu/hotplug: Move online calls to hotplugged cpu")] Date: Thu, 17 Nov 2016 19:14:56 +0200 Message-ID: <20161117171456.GZ31595@intel.com> References: <20161027192006.GF4617@intel.com> <20161027203745.GH4617@intel.com> <20161028155603.GI4617@intel.com> <20161101204737.GB4617@intel.com> <20161109035418.GA18246@shbuild888> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org To: Linus Torvalds Cc: Feng Tang , Thomas Gleixner , Feng Tang , "Rafael J. Wysocki" , "Wysocki, Rafael J" , Steven Rostedt , Sebastian Andrzej Siewior , "linux-arch@vger.kernel.org" , Rik van Riel , "Srivatsa S. Bhat" , Peter Zijlstra , Arjan van de Ven , Rusty Russell , Oleg Nesterov , Tejun Heo , Andrew Morton , Paul McKenney , Paul Turner , Linux Kernel Mailing List List-Id: linux-arch.vger.kernel.org On Tue, Nov 08, 2016 at 10:08:37PM -0800, Linus Torvalds wrote: > On Tue, Nov 8, 2016 at 7:54 PM, Feng Tang wrote: > > On Wed, Nov 02, 2016 at 04:47:37AM +0800, Ville Syrjälä wrote: > >> > >> I left the thing running for the weekend and it failed 26 out of 16057 > >> times with the 25ms timeout. Looks like it takes ~5 minutes to resume > >> when it fails, but eventually it does come back. > > > > Just came back from a travel. Yes, the 5 minutes delay may be due to the > > expiration of the HPET timer, counting from 0 to 0xffffffff for a 13M > > frequencey HPET takes about 300 seconds. After resume, it seems nobody > > arms it so my old patch forces to arm one event. > > Ville, what happens if you disable HPET? Can you force the TSC with > "clocksource=tsc" or "tsc=reliable". Does resume work reliably then? > > Or is this one of the CPU's where tsc just doesn't work? tsc=reliable allows use of the tsc it seems. Doesn't seem to help with resuming though. -- Ville Syrjälä Intel OTC From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com ([134.134.136.100]:58490 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754264AbcKQRPG (ORCPT ); Thu, 17 Nov 2016 12:15:06 -0500 Date: Thu, 17 Nov 2016 19:14:56 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: S3 resume regression [1cf4f629d9d2 ("cpu/hotplug: Move online calls to hotplugged cpu")] Message-ID: <20161117171456.GZ31595@intel.com> References: <20161027192006.GF4617@intel.com> <20161027203745.GH4617@intel.com> <20161028155603.GI4617@intel.com> <20161101204737.GB4617@intel.com> <20161109035418.GA18246@shbuild888> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Linus Torvalds Cc: Feng Tang , Thomas Gleixner , Feng Tang , "Rafael J. Wysocki" , "Wysocki, Rafael J" , Steven Rostedt , Sebastian Andrzej Siewior , "linux-arch@vger.kernel.org" , Rik van Riel , "Srivatsa S. Bhat" , Peter Zijlstra , Arjan van de Ven , Rusty Russell , Oleg Nesterov , Tejun Heo , Andrew Morton , Paul McKenney , Paul Turner , Linux Kernel Mailing List , "Zhang, Rui" , "Brown, Len" , Linux PM , Linux ACPI Message-ID: <20161117171456.8P4IMYg7byUgYFL64-pINFJFXdSTbP42JgCi4qIQBJ0@z> On Tue, Nov 08, 2016 at 10:08:37PM -0800, Linus Torvalds wrote: > On Tue, Nov 8, 2016 at 7:54 PM, Feng Tang wrote: > > On Wed, Nov 02, 2016 at 04:47:37AM +0800, Ville Syrjälä wrote: > >> > >> I left the thing running for the weekend and it failed 26 out of 16057 > >> times with the 25ms timeout. Looks like it takes ~5 minutes to resume > >> when it fails, but eventually it does come back. > > > > Just came back from a travel. Yes, the 5 minutes delay may be due to the > > expiration of the HPET timer, counting from 0 to 0xffffffff for a 13M > > frequencey HPET takes about 300 seconds. After resume, it seems nobody > > arms it so my old patch forces to arm one event. > > Ville, what happens if you disable HPET? Can you force the TSC with > "clocksource=tsc" or "tsc=reliable". Does resume work reliably then? > > Or is this one of the CPU's where tsc just doesn't work? tsc=reliable allows use of the tsc it seems. Doesn't seem to help with resuming though. -- Ville Syrjälä Intel OTC