From: Arnd Bergmann <arnd@arndb.de>
To: Russell King <linux@armlinux.org.uk>
Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org>,
"Nicolas Pitre" <nico@linaro.org>,
linux-arm-kernel@lists.infradead.org,
"Nicholas Piggin" <npiggin@gmail.com>,
viro@zeniv.linux.org.uk, linux-kbuild@vger.kernel.org,
linux-arch@vger.kernel.org, regressions@leemhuis.info,
"Arnd Bergmann" <arnd@arndb.de>,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] ARM: move mmiocpy/mmioset exports to io.c
Date: Tue, 22 Nov 2016 12:05:41 +0100 [thread overview]
Message-ID: <20161122110557.1533467-2-arnd@arndb.de> (raw)
In-Reply-To: <20161122110557.1533467-1-arnd@arndb.de>
The prototypes for mmioset/mmiocpy are intentionally hidden
inside of inline functions, which breaks the EXPORT_SYMBOL
statements when symbol versioning is enabled.
This moves the two exports from the files that implement the
code into the kernel/io.c file, adding another local declaration
there.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/kernel/io.c | 7 +++++++
arch/arm/lib/memcpy.S | 1 -
arch/arm/lib/memset.S | 1 -
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/arch/arm/kernel/io.c b/arch/arm/kernel/io.c
index eedefe050022..c74746997626 100644
--- a/arch/arm/kernel/io.c
+++ b/arch/arm/kernel/io.c
@@ -82,3 +82,10 @@ void _memset_io(volatile void __iomem *dst, int c, size_t count)
}
}
EXPORT_SYMBOL(_memset_io);
+
+/* can't export them from memcpy.S/memset.S because of hidden declaration */
+void mmioset(void __iomem *addr, unsigned int c, size_t n);
+EXPORT_SYMBOL(mmioset);
+
+void mmiocpy(void *dest, const void __iomem *src, size_t n);
+EXPORT_SYMBOL(mmiocpy);
diff --git a/arch/arm/lib/memcpy.S b/arch/arm/lib/memcpy.S
index 1be5b6ddf37c..1f822fc52400 100644
--- a/arch/arm/lib/memcpy.S
+++ b/arch/arm/lib/memcpy.S
@@ -70,4 +70,3 @@ ENTRY(memcpy)
ENDPROC(memcpy)
ENDPROC(mmiocpy)
EXPORT_SYMBOL(memcpy)
-EXPORT_SYMBOL(mmiocpy)
diff --git a/arch/arm/lib/memset.S b/arch/arm/lib/memset.S
index 7b72044cba62..6f075ca09abc 100644
--- a/arch/arm/lib/memset.S
+++ b/arch/arm/lib/memset.S
@@ -137,4 +137,3 @@ UNWIND( .fnend )
ENDPROC(memset)
ENDPROC(mmioset)
EXPORT_SYMBOL(memset)
-EXPORT_SYMBOL(mmioset)
--
2.9.0
next prev parent reply other threads:[~2016-11-22 11:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 11:05 [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM Arnd Bergmann
2016-11-22 11:05 ` Arnd Bergmann [this message]
2016-11-22 11:05 ` [PATCH 2/2] ARM: move mmiocpy/mmioset exports to io.c Arnd Bergmann
2016-11-22 16:34 ` [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM Nicolas Pitre
2016-11-22 16:34 ` Nicolas Pitre
2016-11-23 0:41 ` Russell King - ARM Linux
2016-11-23 0:41 ` Russell King - ARM Linux
2016-11-23 1:40 ` Nicholas Piggin
2016-11-23 1:04 ` Nicholas Piggin
2016-11-23 1:04 ` Nicholas Piggin
2016-11-23 1:35 ` Nicolas Pitre
2016-11-23 9:33 ` Russell King - ARM Linux
2016-11-23 9:33 ` Russell King - ARM Linux
2016-11-23 10:36 ` Russell King - ARM Linux
2016-11-23 10:36 ` Russell King - ARM Linux
2016-11-27 2:33 ` Nicolas Pitre
2016-11-27 2:33 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122110557.1533467-2-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nico@linaro.org \
--cc=npiggin@gmail.com \
--cc=regressions@leemhuis.info \
--cc=uwe@kleine-koenig.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).