From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 07/20] PCI: implement Devres interface to map PCI config space Date: Thu, 2 Mar 2017 14:24:06 -0500 Message-ID: <20170302192406.GA8519@wtj.duckdns.org> References: <20170227151436.18698-1-lorenzo.pieralisi@arm.com> <20170227151436.18698-8-lorenzo.pieralisi@arm.com> <20170302120546.GB17277@red-moon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andy Shevchenko Cc: Wenrui Li , Gabriele Paoloni , "linux-pci@vger.kernel.org" , Shawn Lin , Will Deacon , Michal Simek , Thierry Reding , Tanmay Inamdar , Linux-Arch , Lorenzo Pieralisi , Jonathan Corbet , Pratyush Anand , Russell King , Jon Mason , Murali Karicheri , Catalin Marinas , Arnd Bergmann , Bharat Kumar Gogada , Ray Jui , John Garry , Joao Pinto , Bjorn Helgaas M List-Id: linux-arch.vger.kernel.org Hello, On Thu, Mar 02, 2017 at 02:50:00PM +0200, Andy Shevchenko wrote: > > I thought about that and did not do it because here we are remapping > > resources that are _not_ PCI bus resources (ie it is not PCI BARs we > > are remapping), keeping the devm_* prefix would be more consistent > > to the typical device drivers remapping functions pattern (ie a > > typical PCI host controller driver would mix devm_ and pcim_ calls > > which is a bit hard to parse), that was my rationale. > > > > I am not too fussed about that either way, I am happy to update it to > > pcim_* though, it is Bjorn/Arnd's decision. > > I would vote for pcim_*() variant. Me too, for brevity. > >> 2. If you may notice there is no separate pcim_*map*() stuff, they are > >> dynamically adapting to the case. > > > > I do not understand what you mean here I would ask you to elaborate > > a bit more please so that I can do something about it. > > Oh, sorry, there are two examples currently, i.e. > pci_enable_msi()/pci_enable_msix() and pci_request_region*() which has > no "m" in the name, but are managed on release by pcim_release(). > Some developers consider this as a bad idea, but so far no patch has > been sent to introduce pcim_*() variants of those. > > So, regarding to your stuff, I would stick with "pcim" prefix. Sounds good to me. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f68.google.com ([209.85.214.68]:36831 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752083AbdCBT02 (ORCPT ); Thu, 2 Mar 2017 14:26:28 -0500 Date: Thu, 2 Mar 2017 14:24:06 -0500 From: Tejun Heo Subject: Re: [PATCH 07/20] PCI: implement Devres interface to map PCI config space Message-ID: <20170302192406.GA8519@wtj.duckdns.org> References: <20170227151436.18698-1-lorenzo.pieralisi@arm.com> <20170227151436.18698-8-lorenzo.pieralisi@arm.com> <20170302120546.GB17277@red-moon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Andy Shevchenko Cc: Lorenzo Pieralisi , "linux-pci@vger.kernel.org" , linux-arm Mailing List , "linux-kernel@vger.kernel.org" , Linux-Arch , Jonathan Corbet , Bjorn Helgaas , Arnd Bergmann , Will Deacon , Catalin Marinas , Russell King , Pratyush Anand , Jingoo Han , Mingkai Hu , John Garry , Tanmay Inamdar , Murali Karicheri , Bharat Kumar Gogada , Ray Jui , Wenrui Li , Shawn Lin , Minghuan Lian , Jon Mason , Gabriele Paoloni , Thomas Petazzoni , Joao Pinto , Thierry Reding , Michal Simek , Stanimir Varbanov , Zhou Wang , Roy Zang Message-ID: <20170302192406.8FVa6275Ch6WGTktBwfORu0u8fhX3-5brVjHIloGOv0@z> Hello, On Thu, Mar 02, 2017 at 02:50:00PM +0200, Andy Shevchenko wrote: > > I thought about that and did not do it because here we are remapping > > resources that are _not_ PCI bus resources (ie it is not PCI BARs we > > are remapping), keeping the devm_* prefix would be more consistent > > to the typical device drivers remapping functions pattern (ie a > > typical PCI host controller driver would mix devm_ and pcim_ calls > > which is a bit hard to parse), that was my rationale. > > > > I am not too fussed about that either way, I am happy to update it to > > pcim_* though, it is Bjorn/Arnd's decision. > > I would vote for pcim_*() variant. Me too, for brevity. > >> 2. If you may notice there is no separate pcim_*map*() stuff, they are > >> dynamically adapting to the case. > > > > I do not understand what you mean here I would ask you to elaborate > > a bit more please so that I can do something about it. > > Oh, sorry, there are two examples currently, i.e. > pci_enable_msi()/pci_enable_msix() and pci_request_region*() which has > no "m" in the name, but are managed on release by pcim_release(). > Some developers consider this as a bad idea, but so far no patch has > been sent to introduce pcim_*() variants of those. > > So, regarding to your stuff, I would stick with "pcim" prefix. Sounds good to me. Thanks. -- tejun