From: Thierry Reding <thierry.reding@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Wenrui Li <wenrui.li@rock-chips.com>,
Gabriele Paoloni <gabriele.paoloni@huawei.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Shawn Lin <shawn.lin@rock-chips.com>,
Will Deacon <will.deacon@arm.com>,
Michal Simek <michal.simek@xilinx.com>,
Tanmay Inamdar <tinamdar@apm.com>,
Linux-Arch <linux-arch@vger.kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Jonathan Corbet <corbet@lwn.net>,
Pratyush Anand <pratyush.anand@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Jon Mason <jonmason@broadcom.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Murali Karicheri <m-karicheri2@ti.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>,
Ray Jui <rjui@broadcom.com>, John Garry <john.garry@huawei.com>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH 07/20] PCI: implement Devres interface to map PCI config space
Date: Thu, 2 Mar 2017 21:08:00 +0100 [thread overview]
Message-ID: <20170302200800.GA21303@ulmo.ba.sec> (raw)
In-Reply-To: <20170302192406.GA8519@wtj.duckdns.org>
[-- Attachment #1.1: Type: text/plain, Size: 1168 bytes --]
On Thu, Mar 02, 2017 at 02:24:06PM -0500, Tejun Heo wrote:
> Hello,
>
> On Thu, Mar 02, 2017 at 02:50:00PM +0200, Andy Shevchenko wrote:
> > > I thought about that and did not do it because here we are remapping
> > > resources that are _not_ PCI bus resources (ie it is not PCI BARs we
> > > are remapping), keeping the devm_* prefix would be more consistent
> > > to the typical device drivers remapping functions pattern (ie a
> > > typical PCI host controller driver would mix devm_ and pcim_ calls
> > > which is a bit hard to parse), that was my rationale.
> > >
> > > I am not too fussed about that either way, I am happy to update it to
> > > pcim_* though, it is Bjorn/Arnd's decision.
> >
> > I would vote for pcim_*() variant.
>
> Me too, for brevity.
devm_* is equally brief. Also, all existing pcim_*() functions take a
struct pci_dev * as their first argument, because they operate on the
PCI devices. However in this case the devm_pci_remap_*() functions do
not operate on PCI devices. Rather they operate on the struct device
that represents the PCI host bridge. Therefore I think devm_ is more
appropriate here.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Bjorn Helgaas <bhelgaas@google.com>,
Arnd Bergmann <arnd@arndb.de>, Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Russell King <linux@armlinux.org.uk>,
Pratyush Anand <pratyush.anand@gmail.com>,
Jingoo Han <jingoohan1@gmail.com>,
Mingkai Hu <mingkai.hu@freescale.com>,
John Garry <john.garry@huawei.com>,
Tanmay Inamdar <tinamdar@apm.com>,
Murali Karicheri <m-karicheri2@ti.com>,
Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>,
Ray Jui <rjui@broadcom.com>, Wenrui Li <wenrui.li@rock-chips.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
Minghuan Lian <minghuan.Lian@freescale.com>,
Jon Mason <jonmason@broadcom.com>,
Gabriele Paoloni <gabriele.paoloni@huawei.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Michal Simek <michal.simek@xilinx.com>,
Stanimir Varbanov <svarbanov@mm-sol.com>,
Zhou Wang <wangzhou1@hisilicon.com>,
Roy Zang <tie-fei.zang@freescale.com>
Subject: Re: [PATCH 07/20] PCI: implement Devres interface to map PCI config space
Date: Thu, 2 Mar 2017 21:08:00 +0100 [thread overview]
Message-ID: <20170302200800.GA21303@ulmo.ba.sec> (raw)
Message-ID: <20170302200800.qpE0U4n6J7xd8h-jqHI0rsBMt1a0gyhtpV1wFQSNCtY@z> (raw)
In-Reply-To: <20170302192406.GA8519@wtj.duckdns.org>
[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]
On Thu, Mar 02, 2017 at 02:24:06PM -0500, Tejun Heo wrote:
> Hello,
>
> On Thu, Mar 02, 2017 at 02:50:00PM +0200, Andy Shevchenko wrote:
> > > I thought about that and did not do it because here we are remapping
> > > resources that are _not_ PCI bus resources (ie it is not PCI BARs we
> > > are remapping), keeping the devm_* prefix would be more consistent
> > > to the typical device drivers remapping functions pattern (ie a
> > > typical PCI host controller driver would mix devm_ and pcim_ calls
> > > which is a bit hard to parse), that was my rationale.
> > >
> > > I am not too fussed about that either way, I am happy to update it to
> > > pcim_* though, it is Bjorn/Arnd's decision.
> >
> > I would vote for pcim_*() variant.
>
> Me too, for brevity.
devm_* is equally brief. Also, all existing pcim_*() functions take a
struct pci_dev * as their first argument, because they operate on the
PCI devices. However in this case the devm_pci_remap_*() functions do
not operate on PCI devices. Rather they operate on the struct device
that represents the PCI host bridge. Therefore I think devm_ is more
appropriate here.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-03-02 20:08 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 15:14 [PATCH 00/20] PCI: fix config and I/O Address space memory mappings Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 01/20] PCI: remove __weak tag from pci_remap_iospace() Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-03-01 16:15 ` Arnd Bergmann
2017-03-01 16:15 ` Arnd Bergmann
2017-02-27 15:14 ` [PATCH 02/20] PCI: fix pci_remap_iospace() remap attribute Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-03-16 21:48 ` Bjorn Helgaas
2017-03-16 21:48 ` Bjorn Helgaas
2017-03-17 0:33 ` Luis R. Rodriguez
2017-03-17 0:33 ` Luis R. Rodriguez
2017-03-17 10:43 ` Liviu Dudau
2017-03-17 10:43 ` Liviu Dudau
2017-03-17 16:26 ` Luis R. Rodriguez
2017-03-17 16:26 ` Luis R. Rodriguez
2017-03-20 16:19 ` Lorenzo Pieralisi
2017-03-20 16:19 ` Lorenzo Pieralisi
2017-03-20 16:06 ` Bjorn Helgaas
2017-03-20 16:06 ` Bjorn Helgaas
2017-03-20 16:26 ` Lorenzo Pieralisi
2017-03-20 16:26 ` Lorenzo Pieralisi
2017-03-20 16:38 ` Bjorn Helgaas
2017-03-20 16:38 ` Bjorn Helgaas
2017-02-27 15:14 ` [PATCH 03/20] asm-generic/io.h: add PCI config space remap interface Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-03-16 21:12 ` Bjorn Helgaas
2017-03-16 21:12 ` Bjorn Helgaas
2017-03-17 0:08 ` Luis R. Rodriguez
2017-03-17 0:08 ` Luis R. Rodriguez
2017-03-20 10:22 ` John Garry
2017-03-20 10:22 ` John Garry
2017-03-20 16:27 ` Bjorn Helgaas
2017-03-20 16:27 ` Bjorn Helgaas
2017-03-20 18:45 ` Lorenzo Pieralisi
2017-03-20 18:45 ` Lorenzo Pieralisi
2017-03-22 15:04 ` Lorenzo Pieralisi
2017-03-22 15:04 ` Lorenzo Pieralisi
2017-03-22 15:15 ` Arnd Bergmann
2017-03-22 15:15 ` Arnd Bergmann
2017-03-22 16:29 ` Bjorn Helgaas
2017-03-22 16:29 ` Bjorn Helgaas
2017-02-27 15:14 ` [PATCH 04/20] ARM64: implement pci_remap_cfgspace() interface Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 05/20] ARM: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-03-20 16:43 ` Russell King - ARM Linux
2017-03-20 16:43 ` Russell King - ARM Linux
2017-03-21 15:26 ` Lorenzo Pieralisi
2017-03-21 15:26 ` Lorenzo Pieralisi
2017-03-21 16:53 ` Russell King - ARM Linux
2017-03-21 16:53 ` Russell King - ARM Linux
2017-02-27 15:14 ` [PATCH 06/20] PCI: ECAM: use pci_remap_cfgspace() to map config region Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 07/20] PCI: implement Devres interface to map PCI config space Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-28 10:43 ` Lorenzo Pieralisi
2017-02-28 10:43 ` Lorenzo Pieralisi
2017-03-01 23:54 ` Andy Shevchenko
2017-03-01 23:54 ` Andy Shevchenko
2017-03-02 12:05 ` Lorenzo Pieralisi
2017-03-02 12:05 ` Lorenzo Pieralisi
2017-03-02 12:50 ` Andy Shevchenko
2017-03-02 12:50 ` Andy Shevchenko
2017-03-02 19:24 ` Tejun Heo
2017-03-02 19:24 ` Tejun Heo
2017-03-02 20:08 ` Thierry Reding [this message]
2017-03-02 20:08 ` Thierry Reding
2017-02-27 15:14 ` [PATCH 08/20] PCI: xilinx: update PCI config space remap function Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 09/20] PCI: xilinx-nwl: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 10/20] PCI: spear13xx: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 11/20] PCI: rockchip: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 12/20] PCI: qcom: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 13/20] PCI: iproc-platform: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 21:21 ` Ray Jui
2017-02-27 21:21 ` Ray Jui
2017-02-28 10:54 ` Lorenzo Pieralisi
2017-02-28 10:54 ` Lorenzo Pieralisi
2017-02-28 17:42 ` Ray Jui
2017-02-28 17:42 ` Ray Jui
2017-02-27 15:14 ` [PATCH 14/20] PCI: hisi: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-03-02 10:56 ` Gabriele Paoloni
2017-03-02 10:56 ` Gabriele Paoloni
2017-03-02 11:49 ` Lorenzo Pieralisi
2017-03-02 11:49 ` Lorenzo Pieralisi
2017-03-02 11:53 ` Gabriele Paoloni
2017-03-02 11:53 ` Gabriele Paoloni
2017-02-27 15:14 ` [PATCH 15/20] PCI: designware: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 16/20] PCI: armada8k: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 17/20] PCI: xgene: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 18/20] PCI: tegra: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 19/20] PCI: layerscape: " Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 20/20] PCI: keystone-dw: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-03-01 16:18 ` [PATCH 00/20] PCI: fix config and I/O Address space memory mappings Arnd Bergmann
2017-03-01 16:18 ` Arnd Bergmann
2017-03-02 18:00 ` Lorenzo Pieralisi
2017-03-02 18:00 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170302200800.GA21303@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=Joao.Pinto@synopsys.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=bharat.kumar.gogada@xilinx.com \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=gabriele.paoloni@huawei.com \
--cc=john.garry@huawei.com \
--cc=jonmason@broadcom.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=m-karicheri2@ti.com \
--cc=michal.simek@xilinx.com \
--cc=pratyush.anand@gmail.com \
--cc=rjui@broadcom.com \
--cc=shawn.lin@rock-chips.com \
--cc=tinamdar@apm.com \
--cc=tj@kernel.org \
--cc=wenrui.li@rock-chips.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).