From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH 4/6] x86/kasan: Prepare clear_pgds() to switch to Date: Wed, 22 Mar 2017 08:31:36 +0100 Message-ID: <20170322073136.GC13904@gmail.com> References: <20170317185515.8636-1-kirill.shutemov@linux.intel.com> <20170317185515.8636-5-kirill.shutemov@linux.intel.com> <218853b4-3498-dab9-d1e9-02caed4d9322@virtuozzo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <218853b4-3498-dab9-d1e9-02caed4d9322@virtuozzo.com> Sender: owner-linux-mm@kvack.org To: Andrey Ryabinin Cc: "Kirill A. Shutemov" , Linus Torvalds , Andrew Morton , x86@kernel.org, Thomas Gleixner , Ingo Molnar , Arnd Bergmann , "H. Peter Anvin" , Andi Kleen , Dave Hansen , Andy Lutomirski , Michal Hocko , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dmitry Vyukov List-Id: linux-arch.vger.kernel.org * Andrey Ryabinin wrote: > > > On 03/17/2017 09:55 PM, Kirill A. Shutemov wrote: > > With folded p4d, pgd_clear() is nop. Change clear_pgds() to use > > p4d_clear() instead. > > > > You could probably just use set_pgd(pgd_offset_k(start), __pgd(0)); instead of pgd_clear() > as we already do in arm64. > It's basically pgd_clear() except it's not a nop wih p4d folded. Makes sense. Kirill, if you agree, mind spinning a v2 patch? Thanks, Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com ([74.125.82.67]:36210 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752391AbdCVHbl (ORCPT ); Wed, 22 Mar 2017 03:31:41 -0400 Date: Wed, 22 Mar 2017 08:31:36 +0100 From: Ingo Molnar Subject: Re: [PATCH 4/6] x86/kasan: Prepare clear_pgds() to switch to Message-ID: <20170322073136.GC13904@gmail.com> References: <20170317185515.8636-1-kirill.shutemov@linux.intel.com> <20170317185515.8636-5-kirill.shutemov@linux.intel.com> <218853b4-3498-dab9-d1e9-02caed4d9322@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <218853b4-3498-dab9-d1e9-02caed4d9322@virtuozzo.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Andrey Ryabinin Cc: "Kirill A. Shutemov" , Linus Torvalds , Andrew Morton , x86@kernel.org, Thomas Gleixner , Ingo Molnar , Arnd Bergmann , "H. Peter Anvin" , Andi Kleen , Dave Hansen , Andy Lutomirski , Michal Hocko , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dmitry Vyukov Message-ID: <20170322073136.C6FpQNQD0RABxcfUTrmNOQthyoztILlX5ZciHZNt1Pk@z> * Andrey Ryabinin wrote: > > > On 03/17/2017 09:55 PM, Kirill A. Shutemov wrote: > > With folded p4d, pgd_clear() is nop. Change clear_pgds() to use > > p4d_clear() instead. > > > > You could probably just use set_pgd(pgd_offset_k(start), __pgd(0)); instead of pgd_clear() > as we already do in arm64. > It's basically pgd_clear() except it's not a nop wih p4d folded. Makes sense. Kirill, if you agree, mind spinning a v2 patch? Thanks, Ingo