From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Ingo Molnar <mingo@kernel.org>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Andi Kleen <ak@linux.intel.com>,
Dave Hansen <dave.hansen@intel.com>,
Andy Lutomirski <luto@amacapital.net>,
linux-arch@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/8] x86/dump_pagetables: Add support 5-level paging
Date: Tue, 28 Mar 2017 12:30:40 +0300 [thread overview]
Message-ID: <20170328093040.wayhvqxijreps2mq@node.shutemov.name> (raw)
In-Reply-To: <20170328061259.GC20135@gmail.com>
On Tue, Mar 28, 2017 at 08:12:59AM +0200, Ingo Molnar wrote:
>
> * Kirill A. Shutemov <kirill.shutemov@linux.intel.com> wrote:
>
> > +#if PTRS_PER_P4D > 1
> > +
> > +static void walk_p4d_level(struct seq_file *m, struct pg_state *st, pgd_t addr,
> > + unsigned long P)
>
> Pretty ugly line break. Either don't break the line, or break it in a more logical
> place, like:
>
> static void
> walk_p4d_level(struct seq_file *m, struct pg_state *st, pgd_t addr, unsigned long P)
>
> > + start = (p4d_t *) pgd_page_vaddr(addr);
>
> The space between the type cast and the function invocation is not needed.
Both style issues you have pointed to are inherited from handling of other
page table levels.
Do you want me to adjust them too?
This kind of inconsistency bother me more than style issues itself.
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Ingo Molnar <mingo@kernel.org>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Andi Kleen <ak@linux.intel.com>,
Dave Hansen <dave.hansen@intel.com>,
Andy Lutomirski <luto@amacapital.net>,
linux-arch@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/8] x86/dump_pagetables: Add support 5-level paging
Date: Tue, 28 Mar 2017 12:30:40 +0300 [thread overview]
Message-ID: <20170328093040.wayhvqxijreps2mq@node.shutemov.name> (raw)
Message-ID: <20170328093040.zWoCKSNKcR218t3lqIy4-XDBQ9XGZ4gKT-nWvYO4EJc@z> (raw)
In-Reply-To: <20170328061259.GC20135@gmail.com>
On Tue, Mar 28, 2017 at 08:12:59AM +0200, Ingo Molnar wrote:
>
> * Kirill A. Shutemov <kirill.shutemov@linux.intel.com> wrote:
>
> > +#if PTRS_PER_P4D > 1
> > +
> > +static void walk_p4d_level(struct seq_file *m, struct pg_state *st, pgd_t addr,
> > + unsigned long P)
>
> Pretty ugly line break. Either don't break the line, or break it in a more logical
> place, like:
>
> static void
> walk_p4d_level(struct seq_file *m, struct pg_state *st, pgd_t addr, unsigned long P)
>
> > + start = (p4d_t *) pgd_page_vaddr(addr);
>
> The space between the type cast and the function invocation is not needed.
Both style issues you have pointed to are inherited from handling of other
page table levels.
Do you want me to adjust them too?
This kind of inconsistency bother me more than style issues itself.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2017-03-28 9:30 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 16:29 [PATCH 0/8] x86: 5-level paging enabling for v4.12, Part 3 Kirill A. Shutemov
2017-03-27 16:29 ` Kirill A. Shutemov
2017-03-27 16:29 ` [PATCH 1/8] x86/boot: Detect 5-level paging support Kirill A. Shutemov
2017-03-27 16:29 ` Kirill A. Shutemov
2017-03-28 6:06 ` Ingo Molnar
2017-03-28 6:06 ` Ingo Molnar
2017-03-28 10:45 ` [PATCHv2 " Kirill A. Shutemov
2017-03-28 10:45 ` Kirill A. Shutemov
2017-03-27 16:29 ` [PATCH 2/8] x86/asm: Remove __VIRTUAL_MASK_SHIFT==47 assert Kirill A. Shutemov
2017-03-27 16:29 ` Kirill A. Shutemov
2017-03-27 16:29 ` [PATCH 3/8] x86/mm: Define virtual memory map for 5-level paging Kirill A. Shutemov
2017-03-27 16:29 ` Kirill A. Shutemov
2017-03-28 22:21 ` H. Peter Anvin
2017-03-28 22:21 ` H. Peter Anvin
2017-03-28 22:47 ` Kirill A. Shutemov
2017-03-28 22:47 ` Kirill A. Shutemov
2017-03-29 13:20 ` [PATCHv2 " Kirill A. Shutemov
2017-03-27 16:29 ` [PATCH 4/8] x86/paravirt: Make paravirt code support " Kirill A. Shutemov
2017-03-27 16:29 ` Kirill A. Shutemov
2017-03-27 16:29 ` [PATCH 5/8] x86/mm: Add basic defines/helpers for CONFIG_X86_5LEVEL Kirill A. Shutemov
2017-03-27 16:29 ` Kirill A. Shutemov
2017-03-28 6:11 ` Ingo Molnar
2017-03-28 6:11 ` Ingo Molnar
2017-03-28 10:46 ` [PATCHv2 " Kirill A. Shutemov
2017-03-28 10:46 ` Kirill A. Shutemov
2017-03-27 16:29 ` [PATCH 6/8] x86/dump_pagetables: Add support 5-level paging Kirill A. Shutemov
2017-03-27 16:29 ` Kirill A. Shutemov
2017-03-28 6:12 ` Ingo Molnar
2017-03-28 6:12 ` Ingo Molnar
2017-03-28 9:30 ` Kirill A. Shutemov [this message]
2017-03-28 9:30 ` Kirill A. Shutemov
2017-03-28 9:39 ` Ingo Molnar
2017-03-28 9:39 ` Ingo Molnar
2017-03-28 10:48 ` [PATCHv2 " Kirill A. Shutemov
2017-03-28 10:48 ` Kirill A. Shutemov
2017-03-28 18:55 ` Borislav Petkov
2017-03-28 21:15 ` Kirill A. Shutemov
2017-03-28 21:15 ` Kirill A. Shutemov
2017-03-28 21:38 ` Borislav Petkov
2017-03-29 15:00 ` Kirill A. Shutemov
2017-03-30 6:22 ` Ingo Molnar
2017-03-30 6:22 ` Ingo Molnar
2017-03-27 16:29 ` [PATCH 7/8] x86/kasan: Extend to " Kirill A. Shutemov
2017-03-27 16:29 ` Kirill A. Shutemov
2017-03-27 16:29 ` [PATCH 8/8] x86/espfix: Add " Kirill A. Shutemov
2017-03-27 16:29 ` Kirill A. Shutemov
2017-03-29 13:22 ` [PATCHv2 " Kirill A. Shutemov
2017-03-29 13:22 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328093040.wayhvqxijreps2mq@node.shutemov.name \
--to=kirill@shutemov.name \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).