From: "Kirill A. Shutemov" <kirill@shutemov.name> To: Borislav Petkov <bp@alien8.de> Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, Linus Torvalds <torvalds@linux-foundation.org>, Andrew Morton <akpm@linux-foundation.org>, x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, Andi Kleen <ak@linux.intel.com>, Dave Hansen <dave.hansen@intel.com>, Andy Lutomirski <luto@amacapital.net>, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 6/8] x86/dump_pagetables: Add support 5-level paging Date: Wed, 29 Mar 2017 00:15:07 +0300 [thread overview] Message-ID: <20170328211507.ungejuigkewn6prl@node.shutemov.name> (raw) In-Reply-To: <20170328185522.5akqgfh4niqi3ptf@pd.tnic> On Tue, Mar 28, 2017 at 08:55:22PM +0200, Borislav Petkov wrote: > On Tue, Mar 28, 2017 at 01:48:06PM +0300, Kirill A. Shutemov wrote: > > Simple extension to support one more page table level. > > > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > > --- > > arch/x86/mm/dump_pagetables.c | 59 +++++++++++++++++++++++++++++++++---------- > > 1 file changed, 45 insertions(+), 14 deletions(-) > > Hmm, so without this I get the splat below. On current tip/master? > Can we do something about this bisection breakage? I mean, this is the > second explosion caused by 5level paging I trigger. Maybe we should > merge the whole thing into a single big patch when everything is applied > and tested, more or less, so that bisection is fine. > > Or someone might have a better idea... I'm not sure that collapsing history in one commit to fix bisectability is any better than having broken bisectability. I'll try to look more into this issue tomorrow. Sorry for this. -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name> To: Borislav Petkov <bp@alien8.de> Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, Linus Torvalds <torvalds@linux-foundation.org>, Andrew Morton <akpm@linux-foundation.org>, x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, Andi Kleen <ak@linux.intel.com>, Dave Hansen <dave.hansen@intel.com>, Andy Lutomirski <luto@amacapital.net>, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 6/8] x86/dump_pagetables: Add support 5-level paging Date: Wed, 29 Mar 2017 00:15:07 +0300 [thread overview] Message-ID: <20170328211507.ungejuigkewn6prl@node.shutemov.name> (raw) Message-ID: <20170328211507.vaBA_FbCJtGKK8-Wkt7InU077aWDvFCNAeO9VpmPWWM@z> (raw) In-Reply-To: <20170328185522.5akqgfh4niqi3ptf@pd.tnic> On Tue, Mar 28, 2017 at 08:55:22PM +0200, Borislav Petkov wrote: > On Tue, Mar 28, 2017 at 01:48:06PM +0300, Kirill A. Shutemov wrote: > > Simple extension to support one more page table level. > > > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > > --- > > arch/x86/mm/dump_pagetables.c | 59 +++++++++++++++++++++++++++++++++---------- > > 1 file changed, 45 insertions(+), 14 deletions(-) > > Hmm, so without this I get the splat below. On current tip/master? > Can we do something about this bisection breakage? I mean, this is the > second explosion caused by 5level paging I trigger. Maybe we should > merge the whole thing into a single big patch when everything is applied > and tested, more or less, so that bisection is fine. > > Or someone might have a better idea... I'm not sure that collapsing history in one commit to fix bisectability is any better than having broken bisectability. I'll try to look more into this issue tomorrow. Sorry for this. -- Kirill A. Shutemov
next prev parent reply other threads:[~2017-03-28 21:15 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-27 16:29 [PATCH 0/8] x86: 5-level paging enabling for v4.12, Part 3 Kirill A. Shutemov 2017-03-27 16:29 ` Kirill A. Shutemov 2017-03-27 16:29 ` [PATCH 1/8] x86/boot: Detect 5-level paging support Kirill A. Shutemov 2017-03-27 16:29 ` Kirill A. Shutemov 2017-03-28 6:06 ` Ingo Molnar 2017-03-28 6:06 ` Ingo Molnar 2017-03-28 10:45 ` [PATCHv2 " Kirill A. Shutemov 2017-03-28 10:45 ` Kirill A. Shutemov 2017-03-27 16:29 ` [PATCH 2/8] x86/asm: Remove __VIRTUAL_MASK_SHIFT==47 assert Kirill A. Shutemov 2017-03-27 16:29 ` Kirill A. Shutemov 2017-03-27 16:29 ` [PATCH 3/8] x86/mm: Define virtual memory map for 5-level paging Kirill A. Shutemov 2017-03-27 16:29 ` Kirill A. Shutemov 2017-03-28 22:21 ` H. Peter Anvin 2017-03-28 22:21 ` H. Peter Anvin 2017-03-28 22:47 ` Kirill A. Shutemov 2017-03-28 22:47 ` Kirill A. Shutemov 2017-03-29 13:20 ` [PATCHv2 " Kirill A. Shutemov 2017-03-27 16:29 ` [PATCH 4/8] x86/paravirt: Make paravirt code support " Kirill A. Shutemov 2017-03-27 16:29 ` Kirill A. Shutemov 2017-03-27 16:29 ` [PATCH 5/8] x86/mm: Add basic defines/helpers for CONFIG_X86_5LEVEL Kirill A. Shutemov 2017-03-27 16:29 ` Kirill A. Shutemov 2017-03-28 6:11 ` Ingo Molnar 2017-03-28 6:11 ` Ingo Molnar 2017-03-28 10:46 ` [PATCHv2 " Kirill A. Shutemov 2017-03-28 10:46 ` Kirill A. Shutemov 2017-03-27 16:29 ` [PATCH 6/8] x86/dump_pagetables: Add support 5-level paging Kirill A. Shutemov 2017-03-27 16:29 ` Kirill A. Shutemov 2017-03-28 6:12 ` Ingo Molnar 2017-03-28 6:12 ` Ingo Molnar 2017-03-28 9:30 ` Kirill A. Shutemov 2017-03-28 9:30 ` Kirill A. Shutemov 2017-03-28 9:39 ` Ingo Molnar 2017-03-28 9:39 ` Ingo Molnar 2017-03-28 10:48 ` [PATCHv2 " Kirill A. Shutemov 2017-03-28 10:48 ` Kirill A. Shutemov 2017-03-28 18:55 ` Borislav Petkov 2017-03-28 21:15 ` Kirill A. Shutemov [this message] 2017-03-28 21:15 ` Kirill A. Shutemov 2017-03-28 21:38 ` Borislav Petkov 2017-03-29 15:00 ` Kirill A. Shutemov 2017-03-30 6:22 ` Ingo Molnar 2017-03-30 6:22 ` Ingo Molnar 2017-03-27 16:29 ` [PATCH 7/8] x86/kasan: Extend to " Kirill A. Shutemov 2017-03-27 16:29 ` Kirill A. Shutemov 2017-03-27 16:29 ` [PATCH 8/8] x86/espfix: Add " Kirill A. Shutemov 2017-03-27 16:29 ` Kirill A. Shutemov 2017-03-29 13:22 ` [PATCHv2 " Kirill A. Shutemov 2017-03-29 13:22 ` Kirill A. Shutemov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170328211507.ungejuigkewn6prl@node.shutemov.name \ --to=kirill@shutemov.name \ --cc=ak@linux.intel.com \ --cc=akpm@linux-foundation.org \ --cc=bp@alien8.de \ --cc=dave.hansen@intel.com \ --cc=hpa@zytor.com \ --cc=kirill.shutemov@linux.intel.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=luto@amacapital.net \ --cc=mingo@redhat.com \ --cc=tglx@linutronix.de \ --cc=torvalds@linux-foundation.org \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).