From: Tejun Heo <tj@kernel.org>
To: Cao jin <caoj.fnst@cn.fujitsu.com>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
arnd@arndb.de, cl@linux.com
Subject: Re: [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES
Date: Wed, 29 Mar 2017 11:28:27 -0400 [thread overview]
Message-ID: <20170329152827.GB30385@htj.duckdns.org> (raw)
In-Reply-To: <58DB1E19.4020501@cn.fujitsu.com>
On Wed, Mar 29, 2017 at 10:38:17AM +0800, Cao jin wrote:
> On 03/29/2017 12:00 AM, Tejun Heo wrote:
> > On Tue, Mar 28, 2017 at 04:35:07PM +0800, Cao jin wrote:
> >> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> >
> > I'm not sure. I think I used it during development and it's not like
> > it costs anything to keep.
>
> It easily confusing newbies without any comments for its purpose.
percpu variable handling is pretty complex to begin with. I don't buy
that an empty default attribute macro adds anything noticeable there.
> Temporary using during development seems not good to persist. Could I
> know its purpose?
I don't remember the exact details but at the same time I don't see
the value of the proposed change. We can apply or not apply the patch
and either way wouldn't make any noticeable difference. What's the
point?
Thanks.
--
tejun
next prev parent reply other threads:[~2017-03-29 15:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 8:35 [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES Cao jin
2017-03-28 16:00 ` Tejun Heo
2017-03-29 2:38 ` Cao jin
2017-03-29 15:28 ` Tejun Heo [this message]
2017-03-29 15:28 ` Tejun Heo
2017-03-30 3:34 ` Cao jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329152827.GB30385@htj.duckdns.org \
--to=tj@kernel.org \
--cc=arnd@arndb.de \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=cl@linux.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).