From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH] devicetree: Move include prefixes from arch to separate directory Date: Mon, 15 May 2017 16:48:45 +0100 Message-ID: <20170515154845.GW22219@n2100.armlinux.org.uk> References: <20170515142641.GU22219@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Olof Johansson Cc: Rob Herring , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Heiko Stuebner , Mark Rutland , Catalin Marinas , Will Deacon , Mikael Starvik , Jesper Nilsson , James Hogan , Ralf Baechle , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Frank Rowand , linux-arch List-Id: linux-arch.vger.kernel.org On Mon, May 15, 2017 at 08:27:54AM -0700, Olof Johansson wrote: > On Mon, May 15, 2017 at 7:47 AM, Rob Herring wrote: > > On Mon, May 15, 2017 at 9:26 AM, Russell King - ARM Linux > > wrote: > >> Maybe what we should do is: > >> > >> mkdir include/dt > >> git mv include/dt-bindings include/dt > >> for arch in arch/*; do > >> dts=$arch/boot/dts > >> if [ -d $dts ]; then > >> a=include/dt/$(basename $arch) > >> ln -s $dts $a > >> git add $a > >> fi > >> done > >> ... fixup scripts/Makefile.lib ... > >> git commit > > > > That would just break every existing include in dts files. > > It doesn't break dts includes if done together with a change in -I, > but it might break includes from the driver side (or needs another -I > there). Good point. We could leave include/dt-bindings where it is, and just do the rest of it for the cross-arch includes. Slightly less tidy but should have a lower impact. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pandora.armlinux.org.uk ([78.32.30.218]:60868 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932622AbdEOPtA (ORCPT ); Mon, 15 May 2017 11:49:00 -0400 Date: Mon, 15 May 2017 16:48:45 +0100 From: Russell King - ARM Linux Subject: Re: [PATCH] devicetree: Move include prefixes from arch to separate directory Message-ID: <20170515154845.GW22219@n2100.armlinux.org.uk> References: <20170515142641.GU22219@n2100.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Olof Johansson Cc: Rob Herring , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Heiko Stuebner , Mark Rutland , Catalin Marinas , Will Deacon , Mikael Starvik , Jesper Nilsson , James Hogan , Ralf Baechle , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Frank Rowand , linux-arch Message-ID: <20170515154845.gad6RwxSVMDlhqexjIpBkq5o0bMmyymW65Wg8Zm3tP0@z> On Mon, May 15, 2017 at 08:27:54AM -0700, Olof Johansson wrote: > On Mon, May 15, 2017 at 7:47 AM, Rob Herring wrote: > > On Mon, May 15, 2017 at 9:26 AM, Russell King - ARM Linux > > wrote: > >> Maybe what we should do is: > >> > >> mkdir include/dt > >> git mv include/dt-bindings include/dt > >> for arch in arch/*; do > >> dts=$arch/boot/dts > >> if [ -d $dts ]; then > >> a=include/dt/$(basename $arch) > >> ln -s $dts $a > >> git add $a > >> fi > >> done > >> ... fixup scripts/Makefile.lib ... > >> git commit > > > > That would just break every existing include in dts files. > > It doesn't break dts includes if done together with a change in -I, > but it might break includes from the driver side (or needs another -I > there). Good point. We could leave include/dt-bindings where it is, and just do the rest of it for the cross-arch includes. Slightly less tidy but should have a lower impact. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.