Re: Unify the various copies of libgcc into lib

Palmer Dabbelt
2017-06-03T03:06:42Z

On Wed, 24 May 2017 02:21:22 PDT (-0700), geert@linux-m68k.org wrote:
> Hi Palmer,
>
> On Wed, May 24, 2017 at 12:05 AM, Palmer Dabbelt <palmer@dabbelt.com> wrote:
>> I'm in the process of submitting the RISC-V Linux port, and someone noticed
>> that we were adding copies of some libgcc emulation routines that were the same
>> as some of the other ports. This prompted me to go through and check all the
>> ports for libgcc.h and to merge the versions that were functionally identical.
>>
>> The only difference in libgcc.h was that there was a #define for little vs big
>> endian. The differences in the emulation routines were all just whitespace.
>>
>> This patch set comes in two parts:
>>
>> * Patch 1 adds new copies of all the C files copied from libgcc, as well as
>> moving libgcc.h to include/lib (that's a new folder, which probably means
>> it's the wrong place to put it, but I couldn't find anything better). There
>> are Kconfig entries for each of these library functions so architectures can
>> select them one at a time.
>
> I would call the Kconfig symbols GENERIC_* instead of LIB_*, for consistency
> with other generic implementations.

OK. I'll include that in my v2 patch set.

>> * The rest of the patches convert each architecture over to the new system.
>
> Thanks! For all but "[PATCH 4/7] mips: ...":
>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Thanks!

>> Unless I screwed something up, this patch set shouldn't actually change any
>> functionality. Unfortunately I don't actually have all these cross compilers
>> setup so I can't actually test any of this, but I did convert the RISC-V port
>> over to using this system and it appears to be OK there so at least this isn't
>> completely broken.
>
> https://www.kernel.org/pub/tools/crosstool/

Cool. I'll build everything before I submit a v2.