diff for duplicates of <20170608090507.GA5765@leverpostej> diff --git a/a/1.txt b/N1/1.txt index 3ada2c3..dc1b174 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -40,30 +40,3 @@ On Wed, Jun 07, 2017 at 08:49:43PM -0700, Frank Rowand wrote: > (the patch lists 'riscv, nios, etc'), which config and device tree source? > > And again, what is the calling path? - -From having grepped around, I think this affects architectures which -select CONFIG_GENERIC_CPU_DEVICES, which includes nios2. - -In that case, driver_init() calls cpu_dev_init() before calling -of_core_init(). Then we get the callchain: - - cpu_dev_init() --> cpu_dev_register_generic() --> register_cpu(cpu, i) --> device_register(&cpu->dev) --> device_add(dev) --> device_add_class_symlinks(dev) - -... in device_add_class_symlinks, we we dev->of_node, and call -sysfs_create_link(), which fails because we haven't called -of_core_init() to register the sysfs devicetree directory yet. - -Given that, this patch makes sense to me. - -FWIW, with the commit message updated to describe the particular -ordering problem: - -Acked-by: Mark Rutland <mark.rutland@arm.com> - -Thanks, -Mark. diff --git a/a/content_digest b/N1/content_digest index 2232c78..dfdd3a3 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -64,33 +64,6 @@ "> What kernel version is showing the error? For a specific architecture\n" "> (the patch lists 'riscv, nios, etc'), which config and device tree source?\n" "> \n" - "> And again, what is the calling path?\n" - "\n" - "From having grepped around, I think this affects architectures which\n" - "select CONFIG_GENERIC_CPU_DEVICES, which includes nios2.\n" - "\n" - "In that case, driver_init() calls cpu_dev_init() before calling\n" - "of_core_init(). Then we get the callchain:\n" - "\n" - " cpu_dev_init()\n" - "-> cpu_dev_register_generic()\n" - "-> register_cpu(cpu, i)\n" - "-> device_register(&cpu->dev)\n" - "-> device_add(dev)\n" - "-> device_add_class_symlinks(dev)\n" - "\n" - "... in device_add_class_symlinks, we we dev->of_node, and call\n" - "sysfs_create_link(), which fails because we haven't called\n" - "of_core_init() to register the sysfs devicetree directory yet.\n" - "\n" - "Given that, this patch makes sense to me.\n" - "\n" - "FWIW, with the commit message updated to describe the particular\n" - "ordering problem:\n" - "\n" - "Acked-by: Mark Rutland <mark.rutland@arm.com>\n" - "\n" - "Thanks,\n" - Mark. + > And again, what is the calling path? -6809bac3193d788232e048665b5e26fa2c0e12f0209a28505f812b209e490fe0 +2a06e59bddfa81f2196c50b39c7de9170945e5f7fbe40ea37d9667c9ce0dfc64
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox