From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicholas Piggin Subject: Re: [PATCH 1/5] kbuild: thin archives final link close --whole-archives option Date: Mon, 19 Jun 2017 16:51:00 +1000 Message-ID: <20170619165100.3ce26d00@roar.ozlabs.ibm.com> References: <20170609052417.561-1-npiggin@gmail.com> <20170609052417.561-2-npiggin@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kbuild-owner@vger.kernel.org To: Masahiro Yamada Cc: Linux Kbuild mailing list , linux-arch , Michal Marek , Linus Torvalds , Stephen Rothwell List-Id: linux-arch.vger.kernel.org On Mon, 19 Jun 2017 15:16:17 +0900 Masahiro Yamada wrote: > Hi Nicholas, > > > 2017-06-09 14:24 GMT+09:00 Nicholas Piggin : > > Close the --whole-archives option with --no-whole-archive. Some > > architectures end up including additional .o and files multiple > > times after this, and they get duplicate symbols when they are > > brought under the --whole-archives option. > > Which architectures have additional files after --no-whole-archive ? > > I see this case only for ARCH = "um" in vmlinux_link() > where it adds some -l* options after --no-whole-archive. > > I think it is good to close the --whole-archives everywhere. > So, the code looks OK to me, but I just wondered about the log. Actually a number of archs seemed to get build errors without this, and they seem to come from libgcc perhaps. binfmt_elf.c:(.text+0x4851): undefined reference to `__kernel_syscall_via_epc' /c/gcc/libgcc/libgcc2.c:1318: multiple definition of `__ucmpdi2' /c/gcc/libgcc/libgcc2.c:405: multiple definition of `__lshrdi3' /c/gcc/libgcc/libgcc2.c:433: multiple definition of `__ashldi3' /c/gcc/libgcc/libgcc2.c:461: multiple definition of `__ashrdi3' /home/tony/buildall/src/gcc/libgcc/config/xtensa/lib2funcs.S:36: multiple definition of `__xtensa_libgcc_window_spill' etc m32r, parisc, xtensa seemed to be getting such errors. I wonder if the linker implicitly adds some runtime libs at the end that get caught up here. Either way I didn't look too far into it because this fix seems obviously correct and solved the problem. Thanks, Nick From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f193.google.com ([209.85.192.193]:33071 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751438AbdFSGvR (ORCPT ); Mon, 19 Jun 2017 02:51:17 -0400 Date: Mon, 19 Jun 2017 16:51:00 +1000 From: Nicholas Piggin Subject: Re: [PATCH 1/5] kbuild: thin archives final link close --whole-archives option Message-ID: <20170619165100.3ce26d00@roar.ozlabs.ibm.com> In-Reply-To: References: <20170609052417.561-1-npiggin@gmail.com> <20170609052417.561-2-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Masahiro Yamada Cc: Linux Kbuild mailing list , linux-arch , Michal Marek , Linus Torvalds , Stephen Rothwell Message-ID: <20170619065100.RT9C7peKkCsQJxFSR9C0xejlOpixjeT_BUsyMzoMq3g@z> On Mon, 19 Jun 2017 15:16:17 +0900 Masahiro Yamada wrote: > Hi Nicholas, > > > 2017-06-09 14:24 GMT+09:00 Nicholas Piggin : > > Close the --whole-archives option with --no-whole-archive. Some > > architectures end up including additional .o and files multiple > > times after this, and they get duplicate symbols when they are > > brought under the --whole-archives option. > > Which architectures have additional files after --no-whole-archive ? > > I see this case only for ARCH = "um" in vmlinux_link() > where it adds some -l* options after --no-whole-archive. > > I think it is good to close the --whole-archives everywhere. > So, the code looks OK to me, but I just wondered about the log. Actually a number of archs seemed to get build errors without this, and they seem to come from libgcc perhaps. binfmt_elf.c:(.text+0x4851): undefined reference to `__kernel_syscall_via_epc' /c/gcc/libgcc/libgcc2.c:1318: multiple definition of `__ucmpdi2' /c/gcc/libgcc/libgcc2.c:405: multiple definition of `__lshrdi3' /c/gcc/libgcc/libgcc2.c:433: multiple definition of `__ashldi3' /c/gcc/libgcc/libgcc2.c:461: multiple definition of `__ashrdi3' /home/tony/buildall/src/gcc/libgcc/config/xtensa/lib2funcs.S:36: multiple definition of `__xtensa_libgcc_window_spill' etc m32r, parisc, xtensa seemed to be getting such errors. I wonder if the linker implicitly adds some runtime libs at the end that get caught up here. Either way I didn't look too far into it because this fix seems obviously correct and solved the problem. Thanks, Nick