public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Tom Lendacky <thomas.lendacky-5C7GfCeVMHo@public.gmane.org>
To: linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kasan-dev-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	xen-devel-GuqFBffKawuEi8DpZVb4nw@public.gmane.org,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Cc: "Brijesh Singh" <brijesh.singh-5C7GfCeVMHo@public.gmane.org>,
	"Toshimitsu Kani" <toshi.kani-ZPxbGqLxI0U@public.gmane.org>,
	"Michael S. Tsirkin"
	<mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"Matt Fleming"
	<matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>,
	"Alexander Potapenko"
	<glider-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	"H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
	"Boris Ostrovsky"
	<boris.ostrovsky-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	"Jonathan Corbet" <corbet-T1hC0tSOHrs@public.gmane.org>,
	"Radim Krčmář" <rkrcmar-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"Larry Woodman"
	<lwoodman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"Ingo Molnar" <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"Andrey Ryabinin"
	<aryabinin-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>,
	"Dave Young" <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"Rik van Riel" <riel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"Arnd Bergmann" <arnd-r2nGTMty4D4@public.gmane.org>,
	"Borislav Petkov" <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>,
	"Andy Lutomirski" <luto-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Thomas Gleixner" <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
	"Dmitry Vyukov" <dvyukov-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	"Juergen Gross" <jgross-IBi9RG/b67k@public.gmane.org>,
	"Paolo Bonzini"
	<pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: [PATCH v8 RESEND 05/38] x86/CPU/AMD: Handle SME reduction in physical address size
Date: Tue, 27 Jun 2017 10:08:13 -0500	[thread overview]
Message-ID: <20170627150813.17428.17375.stgit@tlendack-t1.amdoffice.net> (raw)
In-Reply-To: <20170627150718.17428.81813.stgit-qCXWGYdRb2BnqfbPTmsdiZQ+2ll4COg0XqFh9Ls21Oc@public.gmane.org>

When System Memory Encryption (SME) is enabled, the physical address
space is reduced. Adjust the x86_phys_bits value to reflect this
reduction.

Reviewed-by: Borislav Petkov <bp-l3A5Bk7waGM@public.gmane.org>
Signed-off-by: Tom Lendacky <thomas.lendacky-5C7GfCeVMHo@public.gmane.org>
---
 arch/x86/kernel/cpu/amd.c |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
index c47ceee..5bdcbd4 100644
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -613,15 +613,19 @@ static void early_init_amd(struct cpuinfo_x86 *c)
 		set_cpu_bug(c, X86_BUG_AMD_E400);
 
 	/*
-	 * BIOS support is required for SME. If BIOS has not enabled SME
-	 * then don't advertise the feature (set in scattered.c)
+	 * BIOS support is required for SME. If BIOS has enabld SME then
+	 * adjust x86_phys_bits by the SME physical address space reduction
+	 * value. If BIOS has not enabled SME then don't advertise the
+	 * feature (set in scattered.c).
 	 */
 	if (cpu_has(c, X86_FEATURE_SME)) {
 		u64 msr;
 
 		/* Check if SME is enabled */
 		rdmsrl(MSR_K8_SYSCFG, msr);
-		if (!(msr & MSR_K8_SYSCFG_MEM_ENCRYPT))
+		if (msr & MSR_K8_SYSCFG_MEM_ENCRYPT)
+			c->x86_phys_bits -= (cpuid_ebx(0x8000001f) >> 6) & 0x3f;
+		else
 			clear_cpu_cap(c, X86_FEATURE_SME);
 	}
 }

WARNING: multiple messages have this Message-ID (diff)
From: Tom Lendacky <thomas.lendacky@amd.com>
To: linux-arch@vger.kernel.org, linux-efi@vger.kernel.org,
	kvm@vger.kernel.org, linux-doc@vger.kernel.org, x86@kernel.org,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	kasan-dev@googlegroups.com, xen-devel@lists.xen.org,
	linux-mm@kvack.org, iommu@lists.linux-foundation.org
Cc: "Brijesh Singh" <brijesh.singh@amd.com>,
	"Toshimitsu Kani" <toshi.kani@hpe.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	"Matt Fleming" <matt@codeblueprint.co.uk>,
	"Alexander Potapenko" <glider@google.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Larry Woodman" <lwoodman@redhat.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Joerg Roedel" <joro@8bytes.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Andrey Ryabinin" <aryabinin@virtuozzo.com>,
	"Dave Young" <dyoung@redhat.com>,
	"Rik van Riel" <riel@redhat.com>, "Arnd Bergmann" <arnd@arndb.de>,
	"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
	"Borislav Petkov" <bp@alien8.de>,
	"Andy Lutomirski" <luto@kernel.org>,
	"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
	"Dmitry Vyukov" <dvyukov@google.com>,
	"Juergen Gross" <jgross@suse.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PATCH v8 RESEND 05/38] x86/CPU/AMD: Handle SME reduction in physical address size
Date: Tue, 27 Jun 2017 10:08:13 -0500	[thread overview]
Message-ID: <20170627150813.17428.17375.stgit@tlendack-t1.amdoffice.net> (raw)
Message-ID: <20170627150813.QY2ErBZ371n9qGOyDO6-TpgQ8Oj5v5wkZcxR5hMFnX0@z> (raw)
In-Reply-To: <20170627150718.17428.81813.stgit@tlendack-t1.amdoffice.net>

When System Memory Encryption (SME) is enabled, the physical address
space is reduced. Adjust the x86_phys_bits value to reflect this
reduction.

Reviewed-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
---
 arch/x86/kernel/cpu/amd.c |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
index c47ceee..5bdcbd4 100644
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -613,15 +613,19 @@ static void early_init_amd(struct cpuinfo_x86 *c)
 		set_cpu_bug(c, X86_BUG_AMD_E400);
 
 	/*
-	 * BIOS support is required for SME. If BIOS has not enabled SME
-	 * then don't advertise the feature (set in scattered.c)
+	 * BIOS support is required for SME. If BIOS has enabld SME then
+	 * adjust x86_phys_bits by the SME physical address space reduction
+	 * value. If BIOS has not enabled SME then don't advertise the
+	 * feature (set in scattered.c).
 	 */
 	if (cpu_has(c, X86_FEATURE_SME)) {
 		u64 msr;
 
 		/* Check if SME is enabled */
 		rdmsrl(MSR_K8_SYSCFG, msr);
-		if (!(msr & MSR_K8_SYSCFG_MEM_ENCRYPT))
+		if (msr & MSR_K8_SYSCFG_MEM_ENCRYPT)
+			c->x86_phys_bits -= (cpuid_ebx(0x8000001f) >> 6) & 0x3f;
+		else
 			clear_cpu_cap(c, X86_FEATURE_SME);
 	}
 }

  parent reply	other threads:[~2017-06-27 15:08 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27 15:07 [PATCH v8 RESEND 00/38] x86: Secure Memory Encryption (AMD) Tom Lendacky
2017-06-27 15:07 ` Tom Lendacky
     [not found] ` <20170627150718.17428.81813.stgit-qCXWGYdRb2BnqfbPTmsdiZQ+2ll4COg0XqFh9Ls21Oc@public.gmane.org>
2017-06-27 15:07   ` [PATCH v8 RESEND 01/38] x86: Document AMD Secure Memory Encryption (SME) Tom Lendacky
2017-06-27 15:07     ` Tom Lendacky
2017-06-27 15:07   ` [PATCH v8 RESEND 02/38] x86/mm/pat: Set write-protect cache mode for full PAT support Tom Lendacky
2017-06-27 15:07     ` Tom Lendacky
2017-06-27 15:07   ` [PATCH v8 RESEND 03/38] x86, mpparse, x86/acpi, x86/PCI, x86/dmi, SFI: Use memremap for RAM mappings Tom Lendacky
2017-06-27 15:07     ` Tom Lendacky
2017-06-27 15:08   ` [PATCH v8 RESEND 04/38] x86/CPU/AMD: Add the Secure Memory Encryption CPU feature Tom Lendacky
2017-06-27 15:08     ` Tom Lendacky
2017-06-27 15:08   ` Tom Lendacky [this message]
2017-06-27 15:08     ` [PATCH v8 RESEND 05/38] x86/CPU/AMD: Handle SME reduction in physical address size Tom Lendacky
2017-06-27 15:08   ` [PATCH v8 RESEND 06/38] x86/mm: Add Secure Memory Encryption (SME) support Tom Lendacky
2017-06-27 15:08     ` Tom Lendacky
2017-06-27 15:08   ` [PATCH v8 RESEND 08/38] x86/mm: Add support to enable SME in early boot processing Tom Lendacky
2017-06-27 15:08     ` Tom Lendacky
2017-06-27 15:09   ` [PATCH v8 RESEND 10/38] x86/mm: Provide general kernel support for memory encryption Tom Lendacky
2017-06-27 15:09     ` Tom Lendacky
2017-06-27 15:09   ` [PATCH v8 RESEND 11/38] x86/mm: Add SME support for read_cr3_pa() Tom Lendacky
2017-06-27 15:09     ` Tom Lendacky
2017-06-27 15:09   ` [PATCH v8 RESEND 12/38] x86/mm: Extend early_memremap() support with additional attrs Tom Lendacky
2017-06-27 15:09     ` Tom Lendacky
2017-06-27 15:12   ` [PATCH v8 RESEND 27/38] iommu/amd: Allow the AMD IOMMU to work with memory encryption Tom Lendacky
2017-06-27 15:12     ` Tom Lendacky
2017-06-28  9:36     ` Joerg Roedel
2017-06-28  9:36       ` Joerg Roedel
2017-06-28 14:05       ` Tom Lendacky
2017-06-28 14:05         ` Tom Lendacky
2017-06-27 15:12   ` [PATCH v8 RESEND 28/38] x86, realmode: Check for memory encryption on the APs Tom Lendacky
2017-06-27 15:12     ` Tom Lendacky
2017-06-27 15:12   ` [PATCH v8 RESEND 29/38] x86, drm, fbdev: Do not specify encrypted memory for video mappings Tom Lendacky
2017-06-27 15:12     ` Tom Lendacky
2017-06-27 15:13   ` [PATCH v8 RESEND 30/38] kvm: x86: svm: Support Secure Memory Encryption within KVM Tom Lendacky
2017-06-27 15:13     ` Tom Lendacky
2017-06-27 15:08 ` [PATCH v8 RESEND 07/38] x86/mm: Remove phys_to_virt() usage in ioremap() Tom Lendacky
2017-06-27 15:08   ` Tom Lendacky
2017-06-27 15:08 ` [PATCH v8 RESEND 09/38] x86/mm: Simplify p[g4um]d_page() macros Tom Lendacky
2017-06-27 15:08   ` Tom Lendacky
2017-06-27 15:09 ` [PATCH v8 RESEND 13/38] x86/mm: Add support for early encrypt/decrypt of memory Tom Lendacky
2017-06-27 15:09   ` Tom Lendacky
2017-06-27 15:09 ` [PATCH v8 RESEND 14/38] x86/mm: Insure that boot memory areas are mapped properly Tom Lendacky
2017-06-27 15:09   ` Tom Lendacky
2017-06-27 15:09 ` [PATCH v8 RESEND 15/38] x86/boot/e820: Add support to determine the E820 type of an address Tom Lendacky
2017-06-27 15:09   ` Tom Lendacky
2017-06-27 15:10 ` [PATCH v8 RESEND 16/38] efi: Add an EFI table address match function Tom Lendacky
2017-06-27 15:10   ` Tom Lendacky
2017-06-27 15:10 ` [PATCH v8 RESEND 17/38] efi: Update efi_mem_type() to return an error rather than 0 Tom Lendacky
2017-06-27 15:10   ` Tom Lendacky
2017-06-27 15:10 ` [PATCH v8 RESEND 18/38] x86/efi: Update EFI pagetable creation to work with SME Tom Lendacky
2017-06-27 15:10   ` Tom Lendacky
2017-06-27 15:10 ` [PATCH v8 RESEND 19/38] x86/mm: Add support to access boot related data in the clear Tom Lendacky
2017-06-27 15:10   ` Tom Lendacky
2017-06-27 15:11 ` [PATCH v8 RESEND 20/38] x86, mpparse: Use memremap to map the mpf and mpc data Tom Lendacky
2017-06-27 15:11   ` Tom Lendacky
2017-06-27 15:11 ` [PATCH v8 RESEND 21/38] x86/mm: Add support to access persistent memory in the clear Tom Lendacky
2017-06-27 15:11   ` Tom Lendacky
2017-06-27 15:11 ` [PATCH v8 RESEND 22/38] x86/mm: Add support for changing the memory encryption attribute Tom Lendacky
2017-06-27 15:11   ` Tom Lendacky
2017-06-27 15:11 ` [PATCH v8 RESEND 23/38] x86/realmode: Decrypt trampoline area if memory encryption is active Tom Lendacky
2017-06-27 15:11   ` Tom Lendacky
2017-06-27 15:11 ` [PATCH v8 RESEND 24/38] x86, swiotlb: Add memory encryption support Tom Lendacky
2017-06-27 15:11   ` Tom Lendacky
2017-06-27 15:12 ` [PATCH v8 RESEND 25/38] swiotlb: Add warnings for use of bounce buffers with SME Tom Lendacky
2017-06-27 15:12   ` Tom Lendacky
2017-06-27 15:12 ` [PATCH v8 RESEND 26/38] x86/CPU/AMD: Make the microcode level available earlier in the boot Tom Lendacky
2017-06-27 15:12   ` Tom Lendacky
2017-06-27 15:13 ` [PATCH v8 RESEND 31/38] x86/mm, kexec: Allow kexec to be used with SME Tom Lendacky
2017-06-27 15:13   ` Tom Lendacky
2017-06-27 15:13 ` [PATCH v8 RESEND 32/38] xen/x86: Remove SME feature in PV guests Tom Lendacky
2017-06-27 15:13   ` Tom Lendacky
2017-06-27 15:13 ` [PATCH v8 RESEND 33/38] x86/mm: Use proper encryption attributes with /dev/mem Tom Lendacky
2017-06-27 15:13   ` Tom Lendacky
2017-06-27 15:13 ` [PATCH v8 RESEND 34/38] x86/mm: Create native_make_p4d() for PGTABLE_LEVELS <= 4 Tom Lendacky
2017-06-27 15:13   ` Tom Lendacky
2017-06-27 15:14 ` [PATCH v8 RESEND 35/38] x86/mm: Add support to encrypt the kernel in-place Tom Lendacky
2017-06-27 15:14   ` Tom Lendacky
2017-06-27 15:14 ` [PATCH v8 RESEND 36/38] x86/boot: Add early cmdline parsing for options with arguments Tom Lendacky
2017-06-27 15:14   ` Tom Lendacky
2017-06-27 15:14 ` [PATCH v8 RESEND 37/38] compiler-gcc.h: Introduce __nostackp function attribute Tom Lendacky
2017-06-27 15:14   ` Tom Lendacky
2017-06-27 15:14 ` [PATCH v8 RESEND 38/38] x86/mm: Add support to make use of Secure Memory Encryption Tom Lendacky
2017-06-27 15:14   ` Tom Lendacky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170627150813.17428.17375.stgit@tlendack-t1.amdoffice.net \
    --to=thomas.lendacky-5c7gfcevmho@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=aryabinin-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org \
    --cc=boris.ostrovsky-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org \
    --cc=brijesh.singh-5C7GfCeVMHo@public.gmane.org \
    --cc=corbet-T1hC0tSOHrs@public.gmane.org \
    --cc=dvyukov-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=glider-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=jgross-IBi9RG/b67k@public.gmane.org \
    --cc=kasan-dev-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    --cc=kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=luto-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=lwoodman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org \
    --cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=riel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=rkrcmar-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
    --cc=toshi.kani-ZPxbGqLxI0U@public.gmane.org \
    --cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=xen-devel-GuqFBffKawuEi8DpZVb4nw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox