From: Ingo Molnar <mingo@kernel.org>
To: raymond pang <raymondpangxd@gmail.com>
Cc: joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, linux-arch@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/ioapic: Correctly print IRTE's index field when enabling INTR
Date: Wed, 23 Aug 2017 10:16:39 +0200 [thread overview]
Message-ID: <20170823081638.qcxex3576qkta3lb@gmail.com> (raw)
In-Reply-To: <CAHG4imNDzpDyOVi7MByVrLQ=QFuOVqpzJ5F-Xs5z6OZphubj-Q@mail.gmail.com>
* raymond pang <raymondpangxd@gmail.com> wrote:
> When enabling interrupt remap, IOAPIC's RTE contains interrupt_index
> field of IRTE. And this field is composed of index and index2 member of
> struct IR_IO_APIC_route_entry. Make io_apic_print_entries() correctly
> print interrupt index field.
>
> Signed-off-by: Raymond Pang <raymondpangxd@gmail.com>
> ---
> arch/x86/kernel/apic/io_apic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
> index 237e9c2..70e48aa 100644
> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c
> @@ -1243,7 +1243,7 @@ static void io_apic_print_entries(unsigned int
> apic, unsigned int nr_entries)
> entry.vector, entry.irr, entry.delivery_status);
> if (ir_entry->format)
> printk(KERN_DEBUG "%s, remapped, I(%04X), Z(%X)\n",
> - buf, (ir_entry->index << 15) | ir_entry->index,
> + buf, (ir_entry->index2 << 15) | ir_entry->index,
> ir_entry->zero);
> else
> printk(KERN_DEBUG "%s, %s, D(%02X), M(%1d)\n",
Applied.
[ Note that your patch was whitespace damaged (all tabs were converted to spaces),
I fixed that up manually. It's a pain to keep some mailers from doing that, see
Documentation/process/email-clients.rst for best practices. ]
Thanks,
Ingo
prev parent reply other threads:[~2017-08-23 8:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 15:44 [PATCH] x86/ioapic: Correctly print IRTE's index field when enabling INTR raymond pang
2017-08-23 8:16 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170823081638.qcxex3576qkta3lb@gmail.com \
--to=mingo@kernel.org \
--cc=hpa@zytor.com \
--cc=joro@8bytes.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=raymondpangxd@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).