From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Boqun Feng <boqun.feng@gmail.com>, Andrew Hunter <ahh@google.com>,
maged michael <maged.michael@gmail.com>,
gromer <gromer@google.com>, Avi Kivity <avi@scylladb.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Dave Watson <davejwatson@fb.com>,
Alan Stern <stern@rowland.harvard.edu>,
Will Deacon <will.deacon@arm.com>,
Andy Lutomirski <luto@kernel.org>,
linux-arch <linux-arch@vger.kernel.org>
Subject: Re: [RFC PATCH v2 1/2] membarrier: Provide register expedited private command
Date: Thu, 21 Sep 2017 08:27:28 -0700 [thread overview]
Message-ID: <20170921152728.GF3521@linux.vnet.ibm.com> (raw)
In-Reply-To: <196603634.15769.1506006703406.JavaMail.zimbra@efficios.com>
On Thu, Sep 21, 2017 at 03:11:43PM +0000, Mathieu Desnoyers wrote:
> ----- On Sep 21, 2017, at 8:13 AM, Peter Zijlstra peterz@infradead.org wrote:
>
> > On Mon, Sep 18, 2017 at 06:36:47PM -0400, Mathieu Desnoyers wrote:
> >> @@ -3373,6 +3362,7 @@ static void __sched notrace __schedule(bool preempt)
> >>
> >> /* Also unlocks the rq: */
> >> rq = context_switch(rq, prev, next, &rf);
> >> + membarrier_arch_sched_in(prev, next);
> >
> > That's wrong iirc; we just switched stacks, you cannot use @prev and
> > @next.
>
> Yes, it did indeed explode spectacularly at boot in testing. RFC v3 fixes that.
Good to hear that there is a useful test. ;-)
Thanx, Paul
> Thanks,
>
> Mathieu
>
>
> >
> >> } else {
> >> rq->clock_update_flags &= ~(RQCF_ACT_SKIP|RQCF_REQ_SKIP);
> > > rq_unlock_irq(rq, &rf);
>
> --
> Mathieu Desnoyers
> EfficiOS Inc.
> http://www.efficios.com
>
next prev parent reply other threads:[~2017-09-21 15:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 22:36 [RFC PATCH v2 1/2] membarrier: Provide register expedited private command Mathieu Desnoyers
2017-09-18 22:36 ` [RFC PATCH 2/2] membarrier: selftest: Test private expedited cmd Mathieu Desnoyers
2017-09-21 12:13 ` [RFC PATCH v2 1/2] membarrier: Provide register expedited private command Peter Zijlstra
2017-09-21 15:11 ` Mathieu Desnoyers
2017-09-21 15:11 ` Mathieu Desnoyers
2017-09-21 15:27 ` Paul E. McKenney [this message]
2017-09-21 15:27 ` Paul E. McKenney
2017-09-21 15:47 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921152728.GF3521@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=ahh@google.com \
--cc=avi@scylladb.com \
--cc=benh@kernel.crashing.org \
--cc=boqun.feng@gmail.com \
--cc=davejwatson@fb.com \
--cc=gromer@google.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=maged.michael@gmail.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=stern@rowland.harvard.edu \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox