From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Martin Subject: Re: [PATCH v3 03/28] arm64: efi: Add missing Kconfig dependency on KERNEL_MODE_NEON Date: Wed, 11 Oct 2017 15:35:33 +0100 Message-ID: <20171011143533.GC19485@e103592.cambridge.arm.com> References: <1507660725-7986-1-git-send-email-Dave.Martin@arm.com> <1507660725-7986-4-git-send-email-Dave.Martin@arm.com> <20171011141647.gh24vjwgc6vvrtoy@armageddon.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:33948 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751744AbdJKOfi (ORCPT ); Wed, 11 Oct 2017 10:35:38 -0400 Content-Disposition: inline In-Reply-To: <20171011141647.gh24vjwgc6vvrtoy@armageddon.cambridge.arm.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Catalin Marinas Cc: linux-arch@vger.kernel.org, Okamoto Takayuki , libc-alpha@sourceware.org, Ard Biesheuvel , Szabolcs Nagy , Richard Sandiford , Will Deacon , Alex =?iso-8859-1?Q?Benn=E9e?= , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org On Wed, Oct 11, 2017 at 03:16:47PM +0100, Catalin Marinas wrote: > On Tue, Oct 10, 2017 at 07:38:20PM +0100, Dave P Martin wrote: > > The EFI runtime services ABI permits calls to EFI to clobber > > certain FPSIMD/NEON registers, as per the AArch64 procedure call > > standard. > > > > Saving/restoring the clobbered registers around such calls needs > > KERNEL_MODE_NEON, but the dependency is missing from Kconfig. > > > > This patch adds the missing dependency. > > > > This will aid bisection of the patches implementing support for the > > ARM Scalable Vector Extension (SVE). > > > > Signed-off-by: Dave Martin > > Reviewed-by: Alex Bennée > > --- > > arch/arm64/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index 0df64a6..ca711ac 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -1063,6 +1063,7 @@ config EFI_STUB > > config EFI > > bool "UEFI runtime support" > > depends on OF && !CPU_BIG_ENDIAN > > + depends on KERNEL_MODE_NEON > > select LIBFDT > > select UCS2_STRING > > select EFI_PARAMS_FROM_FDT > > We could've used select KERNEL_MODE_NEON since it's a feature needed by > EFI but this works for me as well as KERNEL_MODE_NEON is def_bool y > already. Either way: > > Acked-by: Catalin Marinas Agreed. I assumed this is moot anyway, since KERNEL_MODE_NEON will rarely/never be deselected in practice. Cheers ---Dave