From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Martin Subject: Re: [PATCH v3 01/28] regset: Add support for dynamically sized regsets Date: Wed, 11 Oct 2017 15:45:43 +0100 Message-ID: <20171011144543.GE19485@e103592.cambridge.arm.com> References: <1507660725-7986-1-git-send-email-Dave.Martin@arm.com> <1507660725-7986-2-git-send-email-Dave.Martin@arm.com> <20171011141410.tu53u2ugvs6n7uem@armageddon.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <20171011141410.tu53u2ugvs6n7uem@armageddon.cambridge.arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: Catalin Marinas Cc: linux-arch@vger.kernel.org, Okamoto Takayuki , libc-alpha@sourceware.org, Ard Biesheuvel , Szabolcs Nagy , Richard Sandiford , Will Deacon , viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org List-Id: linux-arch.vger.kernel.org On Wed, Oct 11, 2017 at 03:14:10PM +0100, Catalin Marinas wrote: > On Tue, Oct 10, 2017 at 07:38:18PM +0100, Dave P Martin wrote: > > Currently the regset API doesn't allow for the possibility that > > regsets (or at least, the amount of meaningful data in a regset) > > may change in size. > > = > > In particular, this results in useless padding being added to > > coredumps in a regset's current size is smaller than its > > theoretical maximum size. > > = > > This patch adds a get_size() function to struct user_regset. > > Individual regset implementations can implement this function to > > return the current size of the regset data. A regset_size() > > function is added to provide callers with an abstract interface for > > determining the size of a regset without needing to know whether > > the regset is dynamically sized or not. > > = > > The only affected user of this interface is the ELF coredump code: > > This patch ports ELF coredump to dump regsets with their actual > > size in the coredump. This has no effect except for new regsets > > that are dynamically sized and provide a get_size() implementation. > > = > > Signed-off-by: Dave Martin > > Reviewed-by: Alex Benn=E9e > > --- > > fs/binfmt_elf.c | 6 ++--- > > include/linux/regset.h | 67 ++++++++++++++++++++++++++++++++++++++++++= ++------ > > 2 files changed, 63 insertions(+), 10 deletions(-) > = > The patch looks fine to me: > = > Reviewed-by: Catalin Marinas > = > However, you'd probably need an ack from the filesystem maintainers > (cc'ed; patch below for reference). Apologies for that -- I manually added Ccs to this patch in previous postings, and predictably lost them in the respin. I'll add Cc lines in the commit message, since there will be a further re-spin of the series to apply the Documentation changes requested by Szabolcs that I missed. I don't currently have any pending fixes to _this_ patch, so it's still worth reviewing. Cheers ---Dave [...] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:34186 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752213AbdJKOps (ORCPT ); Wed, 11 Oct 2017 10:45:48 -0400 Date: Wed, 11 Oct 2017 15:45:43 +0100 From: Dave Martin Subject: Re: [PATCH v3 01/28] regset: Add support for dynamically sized regsets Message-ID: <20171011144543.GE19485@e103592.cambridge.arm.com> References: <1507660725-7986-1-git-send-email-Dave.Martin@arm.com> <1507660725-7986-2-git-send-email-Dave.Martin@arm.com> <20171011141410.tu53u2ugvs6n7uem@armageddon.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171011141410.tu53u2ugvs6n7uem@armageddon.cambridge.arm.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Catalin Marinas Cc: linux-arch@vger.kernel.org, Okamoto Takayuki , libc-alpha@sourceware.org, Ard Biesheuvel , Szabolcs Nagy , Richard Sandiford , Will Deacon , viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, Alex =?iso-8859-1?Q?Benn=E9e?= , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Message-ID: <20171011144543.2pOA-pBQht1XhyN3b6m7iaaX4-wLorPaNEqIebfaukg@z> On Wed, Oct 11, 2017 at 03:14:10PM +0100, Catalin Marinas wrote: > On Tue, Oct 10, 2017 at 07:38:18PM +0100, Dave P Martin wrote: > > Currently the regset API doesn't allow for the possibility that > > regsets (or at least, the amount of meaningful data in a regset) > > may change in size. > > > > In particular, this results in useless padding being added to > > coredumps in a regset's current size is smaller than its > > theoretical maximum size. > > > > This patch adds a get_size() function to struct user_regset. > > Individual regset implementations can implement this function to > > return the current size of the regset data. A regset_size() > > function is added to provide callers with an abstract interface for > > determining the size of a regset without needing to know whether > > the regset is dynamically sized or not. > > > > The only affected user of this interface is the ELF coredump code: > > This patch ports ELF coredump to dump regsets with their actual > > size in the coredump. This has no effect except for new regsets > > that are dynamically sized and provide a get_size() implementation. > > > > Signed-off-by: Dave Martin > > Reviewed-by: Alex Bennée > > --- > > fs/binfmt_elf.c | 6 ++--- > > include/linux/regset.h | 67 ++++++++++++++++++++++++++++++++++++++++++++------ > > 2 files changed, 63 insertions(+), 10 deletions(-) > > The patch looks fine to me: > > Reviewed-by: Catalin Marinas > > However, you'd probably need an ack from the filesystem maintainers > (cc'ed; patch below for reference). Apologies for that -- I manually added Ccs to this patch in previous postings, and predictably lost them in the respin. I'll add Cc lines in the commit message, since there will be a further re-spin of the series to apply the Documentation changes requested by Szabolcs that I missed. I don't currently have any pending fixes to _this_ patch, so it's still worth reviewing. Cheers ---Dave [...]