From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [GIT PULL de-alpha] Make core code not need to know about Alpha for v4.15 Date: Wed, 25 Oct 2017 11:04:43 +0200 Message-ID: <20171025090443.g6aahmn3ggu6vcon@gmail.com> References: <20171023210408.GA2930@linux.vnet.ibm.com> <20171025084548.mc7pqlshuzmtci4p@gmail.com> <20171025085414.GH3659@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20171025085414.GH3659@linux.vnet.ibm.com> Sender: linux-kernel-owner@vger.kernel.org To: "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, will.deacon@arm.com, mark.rutland@arm.com, snitzer@redhat.com, thor.thayer@linux.intel.com, viro@zeniv.linux.org.uk, davem@davemloft.net, shuah@kernel.org, mpe@ellerman.id.au, tj@kernel.org List-Id: linux-arch.vger.kernel.org * Paul E. McKenney wrote: > On Wed, Oct 25, 2017 at 10:45:48AM +0200, Ingo Molnar wrote: > > > > * Paul E. McKenney wrote: > > > > > Hello, Ingo, > > > > > > This series is a first step towards making the core kernel no longer > > > need to consider DEC Alpha as a special case. This is accomplished > > > by two sets of patches, followed by a Coccinelle script: > > > > > > 1. Patches 1/19 through 15/19 in the following patches, which > > > change non-Coccinelle-susceptible instances of ACCESS_ONCE() > > > to either READ_ONCE() or WRITE_ONCE(), as appropriate. Most of > > > these patches are courtesy of Mark Rutland. > > > > > > 2. Patches 16/19 through 18/19 in the following patches, which > > > add smp_read_barrier_depends() to READ_ONCE() and to Alpha's > > > value-returning _release and _relaxed atomic read-modify-write > > > operations, while also removing lockless_dereference() in favor > > > of the modified READ_ONCE(). > > > > > > 3. A patch generated by Coccinelle (script in commit log) that > > > converts ACCESS_ONCE() to either READ_ONCE() or WRITE_ONCE(), > > > as appropriate. Of course, this patch should not be applied > > > as-is to mainline, instead, the Coccinelle script should be > > > re-run in order to account for any changes between now and > > > the time of merging into mainline. > > > > > > A later series (most likely targeted to v4.16) will remove instances of > > > smp_read_barrier_depends() that are made redundant by this series, that > > > is to say, almost all of them. > > > > > > These changes are available in the git repository at: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/alpha-cocci > > > > > > for you to fetch changes up to d19fa5187a69bd7685e9c7452ce9e339b1b079fc: > > > > > > COCCINELLE: treewide: kill off ACCESS_ONCE() (2017-10-21 12:52:09 -0700) > > > > > > ---------------------------------------------------------------- > > > Mark Rutland (14): > > > dm integrity: Kill off ACCESS_ONCE() > > > EDAC, altera: Kill off ACCESS_ONCE() > > > firmware/ivc: Kill off ACCESS_ONCE() > > > fs: dcache: Kill off ACCESS_ONCE() > > > fs: ncpfs: Kill off ACCESS_ONCE() > > > media: dvb_ringbuffer: Kill off ACCESS_ONCE() > > > net: netlink/netfilter: Kill off ACCESS_ONCE() > > > net/ipv4/tcp_input.c: Kill off ACCESS_ONCE() > > > net: average: Kill off ACCESS_ONCE() > > > samples: mic/mpssd/mpssd.c: Kill off ACCESS_ONCE() > > > selftests/powerpc: Kill off ACCESS_ONCE() > > > workqueue: Kill off ACCESS_ONCE() > > > rcutorture: formal: Prepare for ACCESS_ONCE() removal > > > COCCINELLE: treewide: kill off ACCESS_ONCE() > > > > None of the patches from Mark include your Signed-off-by - I'll add them, let me > > know if that's not OK. I suppose this happened because you rebased his tree? > > I did pull his tree rather than applying from email, [...] You might have pulled it, but the commits in rcu/alpha-cocci suggest that the tree was also rebased: commit d19fa5187a69bd7685e9c7452ce9e339b1b079fc Author: Mark Rutland AuthorDate: Thu Oct 19 10:42:03 2017 -0700 Commit: Paul E. McKenney CommitDate: Sat Oct 21 12:52:09 2017 -0700 COCCINELLE: treewide: kill off ACCESS_ONCE() Note the "Commit:" field which says the commit was created by you, not by Mark. Thanks, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f52.google.com ([209.85.215.52]:54443 "EHLO mail-lf0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932284AbdJYJEs (ORCPT ); Wed, 25 Oct 2017 05:04:48 -0400 Date: Wed, 25 Oct 2017 11:04:43 +0200 From: Ingo Molnar Subject: Re: [GIT PULL de-alpha] Make core code not need to know about Alpha for v4.15 Message-ID: <20171025090443.g6aahmn3ggu6vcon@gmail.com> References: <20171023210408.GA2930@linux.vnet.ibm.com> <20171025084548.mc7pqlshuzmtci4p@gmail.com> <20171025085414.GH3659@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171025085414.GH3659@linux.vnet.ibm.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, will.deacon@arm.com, mark.rutland@arm.com, snitzer@redhat.com, thor.thayer@linux.intel.com, viro@zeniv.linux.org.uk, davem@davemloft.net, shuah@kernel.org, mpe@ellerman.id.au, tj@kernel.org Message-ID: <20171025090443.0i5AU4Xlmo3RHiAPSb72EofyqARYVLdT3V5GGjK6vp0@z> * Paul E. McKenney wrote: > On Wed, Oct 25, 2017 at 10:45:48AM +0200, Ingo Molnar wrote: > > > > * Paul E. McKenney wrote: > > > > > Hello, Ingo, > > > > > > This series is a first step towards making the core kernel no longer > > > need to consider DEC Alpha as a special case. This is accomplished > > > by two sets of patches, followed by a Coccinelle script: > > > > > > 1. Patches 1/19 through 15/19 in the following patches, which > > > change non-Coccinelle-susceptible instances of ACCESS_ONCE() > > > to either READ_ONCE() or WRITE_ONCE(), as appropriate. Most of > > > these patches are courtesy of Mark Rutland. > > > > > > 2. Patches 16/19 through 18/19 in the following patches, which > > > add smp_read_barrier_depends() to READ_ONCE() and to Alpha's > > > value-returning _release and _relaxed atomic read-modify-write > > > operations, while also removing lockless_dereference() in favor > > > of the modified READ_ONCE(). > > > > > > 3. A patch generated by Coccinelle (script in commit log) that > > > converts ACCESS_ONCE() to either READ_ONCE() or WRITE_ONCE(), > > > as appropriate. Of course, this patch should not be applied > > > as-is to mainline, instead, the Coccinelle script should be > > > re-run in order to account for any changes between now and > > > the time of merging into mainline. > > > > > > A later series (most likely targeted to v4.16) will remove instances of > > > smp_read_barrier_depends() that are made redundant by this series, that > > > is to say, almost all of them. > > > > > > These changes are available in the git repository at: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/alpha-cocci > > > > > > for you to fetch changes up to d19fa5187a69bd7685e9c7452ce9e339b1b079fc: > > > > > > COCCINELLE: treewide: kill off ACCESS_ONCE() (2017-10-21 12:52:09 -0700) > > > > > > ---------------------------------------------------------------- > > > Mark Rutland (14): > > > dm integrity: Kill off ACCESS_ONCE() > > > EDAC, altera: Kill off ACCESS_ONCE() > > > firmware/ivc: Kill off ACCESS_ONCE() > > > fs: dcache: Kill off ACCESS_ONCE() > > > fs: ncpfs: Kill off ACCESS_ONCE() > > > media: dvb_ringbuffer: Kill off ACCESS_ONCE() > > > net: netlink/netfilter: Kill off ACCESS_ONCE() > > > net/ipv4/tcp_input.c: Kill off ACCESS_ONCE() > > > net: average: Kill off ACCESS_ONCE() > > > samples: mic/mpssd/mpssd.c: Kill off ACCESS_ONCE() > > > selftests/powerpc: Kill off ACCESS_ONCE() > > > workqueue: Kill off ACCESS_ONCE() > > > rcutorture: formal: Prepare for ACCESS_ONCE() removal > > > COCCINELLE: treewide: kill off ACCESS_ONCE() > > > > None of the patches from Mark include your Signed-off-by - I'll add them, let me > > know if that's not OK. I suppose this happened because you rebased his tree? > > I did pull his tree rather than applying from email, [...] You might have pulled it, but the commits in rcu/alpha-cocci suggest that the tree was also rebased: commit d19fa5187a69bd7685e9c7452ce9e339b1b079fc Author: Mark Rutland AuthorDate: Thu Oct 19 10:42:03 2017 -0700 Commit: Paul E. McKenney CommitDate: Sat Oct 21 12:52:09 2017 -0700 COCCINELLE: treewide: kill off ACCESS_ONCE() Note the "Commit:" field which says the commit was created by you, not by Mark. Thanks, Ingo