From: Yury Norov <ynorov@caviumnetworks.com>
To: Clement Courbet <courbet@google.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <mawilcox@microsoft.com>,
Ingo Molnar <mingo@kernel.org>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Re [PATCH v2] lib: optimize cpumask_next_and()
Date: Wed, 25 Oct 2017 18:50:14 +0300 [thread overview]
Message-ID: <20171025155014.ppsu6hkwnhh3fjxp@yury-thinkpad> (raw)
In-Reply-To: <20171025152841.6746-1-courbet@google.com>
On Wed, Oct 25, 2017 at 05:28:41PM +0200, Clement Courbet wrote:
> Thanks for the comments Yury.
>
> > But I'd like also to keep _find_next_bit() consistent with
> > _find_next_bit_le()
>
> Not sure I understand what you're suggesting here: Do you want a
> find_next_and_bit_le() or do you want to make _find_next_bit_le() more
> like _find_next_bit() ? In the latter case we might just want to merge
> it with _find_next_bit() and end up with an extra is_le parameter :)
Both ways will work, but I think that extra is_le is too much.
_find_next_bit_le() should be the copy of _find_next_bit() with the
addition of swapping code.
If you don't need find_next_and_bit_le(), don't add it.
find_{first,last}_bit() doesn't have LE version, for example.
Yury
next prev parent reply other threads:[~2017-10-25 15:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 10:51 [PATCH v2] lib: optimize cpumask_next_and() Clement Courbet
2017-10-25 7:28 ` Matthew Wilcox
2017-10-25 7:28 ` Matthew Wilcox
2017-10-25 14:59 ` Yury Norov
2017-10-25 14:59 ` Yury Norov
2017-10-25 15:28 ` Re " Clement Courbet
2017-10-25 15:28 ` Clement Courbet
2017-10-25 15:50 ` Yury Norov [this message]
2017-10-25 17:41 ` Yury Norov
2017-10-25 17:41 ` Yury Norov
2017-10-26 12:12 ` kbuild test robot
2017-10-26 12:12 ` kbuild test robot
2017-10-26 12:22 ` kbuild test robot
2017-10-26 12:22 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171025155014.ppsu6hkwnhh3fjxp@yury-thinkpad \
--to=ynorov@caviumnetworks.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=courbet@google.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mawilcox@microsoft.com \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).