From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] frv: fix build failure
Date: Sun, 3 Dec 2017 22:32:26 +0000 [thread overview]
Message-ID: <20171203223226.GA3741@sudip-laptop> (raw)
In-Reply-To: <3a6fe86e-7a66-56df-3b1d-e2e8cd3e6eae@synopsys.com>
On Mon, Nov 27, 2017 at 10:25:16AM -0800, Vineet Gupta wrote:
> +CC linux-arch, Arnd
>
> On 11/23/2017 09:17 AM, Alexey Brodkin wrote:
> >Hi Sudip,
> >
> >On Tue, 2017-11-21 at 22:10 +0000, Sudip Mukherjee wrote:
<snip>
> I understand the case/need for adding a weak/common abort() as a
> quick fix for handling such cases, but perhaps we should not and
> instead fix the rootcause. In this specific case, Claudiu mentioned
> that gcc was generating abort due to something like this (flagging a
> possible divide by zero due to
> -fno-isolate-erroneous-paths-dereference.
>
> a;
>
> fn1() {
> switch (a)
> case 0:
> return 1 / a;
> }
>
> Sudeep can you confirm that removing this hacking FRV build to not
> have this toggle fixes the abort issue.
>
> So the offending code needs to be fixed as in the end when that code
> path is taken system is hosed.
The above case that you mentioned is indeed the case here.
mpihelp_divrem() in lib/mpi/mpih-div.c has this same divide by zero case.
So, what should be the actual fix here?
WARNING: multiple messages have this Message-ID (diff)
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] frv: fix build failure
Date: Sun, 3 Dec 2017 22:32:26 +0000 [thread overview]
Message-ID: <20171203223226.GA3741@sudip-laptop> (raw)
Message-ID: <20171203223226.uTI0ywRtbcjzv8eqo_GHuvcp-bva5YatkUuC7FLuy0M@z> (raw)
In-Reply-To: <3a6fe86e-7a66-56df-3b1d-e2e8cd3e6eae@synopsys.com>
On Mon, Nov 27, 2017 at 10:25:16AM -0800, Vineet Gupta wrote:
> +CC linux-arch, Arnd
>
> On 11/23/2017 09:17 AM, Alexey Brodkin wrote:
> >Hi Sudip,
> >
> >On Tue, 2017-11-21 at 22:10 +0000, Sudip Mukherjee wrote:
<snip>
> I understand the case/need for adding a weak/common abort() as a
> quick fix for handling such cases, but perhaps we should not and
> instead fix the rootcause. In this specific case, Claudiu mentioned
> that gcc was generating abort due to something like this (flagging a
> possible divide by zero due to
> -fno-isolate-erroneous-paths-dereference.
>
> a;
>
> fn1() {
> switch (a)
> case 0:
> return 1 / a;
> }
>
> Sudeep can you confirm that removing this hacking FRV build to not
> have this toggle fixes the abort issue.
>
> So the offending code needs to be fixed as in the end when that code
> path is taken system is hosed.
The above case that you mentioned is indeed the case here.
mpihelp_divrem() in lib/mpi/mpih-div.c has this same divide by zero case.
So, what should be the actual fix here?
--
Regards
Sudip
next prev parent reply other threads:[~2017-12-03 22:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1511302233-5008-1-git-send-email-sudipm.mukherjee@gmail.com>
[not found] ` <1511457437.32422.6.camel@synopsys.com>
2017-11-27 18:25 ` [PATCH] frv: fix build failure Vineet Gupta
2017-12-03 22:32 ` Sudip Mukherjee [this message]
2017-12-03 22:32 ` Sudip Mukherjee
2017-12-06 22:00 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171203223226.GA3741@sudip-laptop \
--to=sudipm.mukherjee@gmail.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).