Generic Linux architectural discussions
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-arch@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] m32r: fix readl/writel prototypes
Date: Tue,  2 Jan 2018 11:56:41 +0100	[thread overview]
Message-ID: <20180102105653.1645748-1-arnd@arndb.de> (raw)

All other architectures use 'unsigned int' as the data in readl/write,
but m32r uses 'unsigned long', leading to lots of harmless build warnings
like:

drivers/mmc/host/dw_mmc.c: In function 'dw_mci_regs_show':
drivers/mmc/host/dw_mmc.c:168:31: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long unsigned int' [-Wformat=]
  seq_printf(s, "STATUS:\t0x%08x\n", mci_readl(host, STATUS));

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/m32r/include/asm/io.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/m32r/include/asm/io.h b/arch/m32r/include/asm/io.h
index 1b653bb16f9a..093486b5b931 100644
--- a/arch/m32r/include/asm/io.h
+++ b/arch/m32r/include/asm/io.h
@@ -108,9 +108,9 @@ static inline unsigned short _readw(unsigned long addr)
 	return *(volatile unsigned short __force *)addr;
 }
 
-static inline unsigned long _readl(unsigned long addr)
+static inline unsigned int _readl(unsigned long addr)
 {
-	return *(volatile unsigned long __force *)addr;
+	return *(volatile unsigned int __force *)addr;
 }
 
 static inline void _writeb(unsigned char b, unsigned long addr)
@@ -123,9 +123,9 @@ static inline void _writew(unsigned short w, unsigned long addr)
 	*(volatile unsigned short __force *)addr = w;
 }
 
-static inline void _writel(unsigned long l, unsigned long addr)
+static inline void _writel(unsigned long l, unsigned int addr)
 {
-	*(volatile unsigned long __force *)addr = l;
+	*(volatile unsigned int __force *)addr = l;
 }
 
 #define inb     _inb
-- 
2.9.0

             reply	other threads:[~2018-01-02 10:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-02 10:56 Arnd Bergmann [this message]
2018-01-02 14:20 ` [PATCH] m32r: fix readl/writel prototypes Geert Uytterhoeven
2018-01-02 14:20   ` Geert Uytterhoeven
2018-01-02 21:52 ` Luc Van Oostenryck
2018-01-02 21:52   ` Luc Van Oostenryck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180102105653.1645748-1-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox