From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [REGRESSION] testing/selftests/x86/ pkeys build failures (was: Re: [PATCH] mm, x86: pkeys: Introduce PKEY_ALLOC_SIGNALINHERIT and change signal semantics) Date: Fri, 12 Jan 2018 15:14:49 +0100 Message-ID: <20180112141449.5gmn3nxvosk6y6qs@gmail.com> References: <360ef254-48bc-aee6-70f9-858f773b8693@redhat.com> <20180112125537.bdl376ziiaqp664o@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20180112125537.bdl376ziiaqp664o@gmail.com> Sender: owner-linux-mm@kvack.org To: Florian Weimer , Shuah Khan , Dave Hansen Cc: linux-mm , linux-arch , linux-x86_64@vger.kernel.org, Linux API , x86@kernel.org, Dave Hansen , Ram Pai List-Id: linux-arch.vger.kernel.org * Ingo Molnar wrote: > Also, the protection keys testcase first need to be fixed, before we complicate > them - for example on a pretty regular Ubuntu x86-64 installation they fail to > build with the build errors attached further below. > > On an older Fedora 23 installation, the testcases themselves don't build at all: The Ubuntu build failure seems to have gone away after a 'make clean', what remains is an ugly build warning: triton:~/tip/tools/testing/selftests/x86> make gcc -m32 -o /home/mingo/tip/tools/testing/selftests/x86/protection_keys_32 -O2 -g -std=gnu99 -pthread -Wall -no-pie protection_keys.c -lrt -ldl -lm protection_keys.c: In function ‘dumpit’: protection_keys.c:419:3: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result] write(1, buf, nr_read); ^~~~~~~~~~~~~~~~~~~~~~ gcc -m64 -o /home/mingo/tip/tools/testing/selftests/x86/protection_keys_64 -O2 -g -std=gnu99 -pthread -Wall -no-pie protection_keys.c -lrt -ldl protection_keys.c: In function ‘dumpit’: protection_keys.c:419:3: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result] write(1, buf, nr_read); ^~~~~~~~~~~~~~~~~~~~~~ If this build warning and the Fedora build failure is fixed we can apply your patch too I think. Thanks, Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com ([209.85.128.195]:35006 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933687AbeALOOy (ORCPT ); Fri, 12 Jan 2018 09:14:54 -0500 Date: Fri, 12 Jan 2018 15:14:49 +0100 From: Ingo Molnar Subject: Re: [REGRESSION] testing/selftests/x86/ pkeys build failures (was: Re: [PATCH] mm, x86: pkeys: Introduce PKEY_ALLOC_SIGNALINHERIT and change signal semantics) Message-ID: <20180112141449.5gmn3nxvosk6y6qs@gmail.com> References: <360ef254-48bc-aee6-70f9-858f773b8693@redhat.com> <20180112125537.bdl376ziiaqp664o@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180112125537.bdl376ziiaqp664o@gmail.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Florian Weimer , Shuah Khan , Dave Hansen Cc: linux-mm , linux-arch , linux-x86_64@vger.kernel.org, Linux API , x86@kernel.org, Dave Hansen , Ram Pai Message-ID: <20180112141449.B81AZr2xGUp3AAkp-bXP9A1rUqm0LOv0U34ALr5Wtaw@z> * Ingo Molnar wrote: > Also, the protection keys testcase first need to be fixed, before we complicate > them - for example on a pretty regular Ubuntu x86-64 installation they fail to > build with the build errors attached further below. > > On an older Fedora 23 installation, the testcases themselves don't build at all: The Ubuntu build failure seems to have gone away after a 'make clean', what remains is an ugly build warning: triton:~/tip/tools/testing/selftests/x86> make gcc -m32 -o /home/mingo/tip/tools/testing/selftests/x86/protection_keys_32 -O2 -g -std=gnu99 -pthread -Wall -no-pie protection_keys.c -lrt -ldl -lm protection_keys.c: In function ‘dumpit’: protection_keys.c:419:3: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result] write(1, buf, nr_read); ^~~~~~~~~~~~~~~~~~~~~~ gcc -m64 -o /home/mingo/tip/tools/testing/selftests/x86/protection_keys_64 -O2 -g -std=gnu99 -pthread -Wall -no-pie protection_keys.c -lrt -ldl protection_keys.c: In function ‘dumpit’: protection_keys.c:419:3: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result] write(1, buf, nr_read); ^~~~~~~~~~~~~~~~~~~~~~ If this build warning and the Fedora build failure is fixed we can apply your patch too I think. Thanks, Ingo