From: Will Deacon <will.deacon@arm.com>
To: Masami Hiramatsu <mhiramat@kernel.org>, catalin.marinas@arm.com
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Jon Medhurst <tixy@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
David Howells <dhowells@redhat.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
"Tobin C . Harding" <me@tobin.cc>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 6/8] kprobes/arm64: Fix %p uses in error messages
Date: Thu, 25 Jan 2018 16:42:31 +0000 [thread overview]
Message-ID: <20180125164230.GC22963@arm.com> (raw)
In-Reply-To: <151685817205.3099.18079175391687728067.stgit@devbox>
On Thu, Jan 25, 2018 at 02:29:32PM +0900, Masami Hiramatsu wrote:
> Fix %p uses in error messages by removing it because
> those are redundant or meaningless.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> arch/arm64/kernel/probes/kprobes.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Will Deacon <will.deacon@arm.com>
I guess Catalin can just pick this one up via arm64.
Will
> diff --git a/arch/arm64/kernel/probes/kprobes.c b/arch/arm64/kernel/probes/kprobes.c
> index d849d9804011..34f78d07a068 100644
> --- a/arch/arm64/kernel/probes/kprobes.c
> +++ b/arch/arm64/kernel/probes/kprobes.c
> @@ -275,7 +275,7 @@ static int __kprobes reenter_kprobe(struct kprobe *p,
> break;
> case KPROBE_HIT_SS:
> case KPROBE_REENTER:
> - pr_warn("Unrecoverable kprobe detected at %p.\n", p->addr);
> + pr_warn("Unrecoverable kprobe detected.\n");
> dump_kprobe(p);
> BUG();
> break;
> @@ -521,7 +521,7 @@ int __kprobes longjmp_break_handler(struct kprobe *p, struct pt_regs *regs)
> (struct pt_regs *)kcb->jprobe_saved_regs.sp;
> pr_err("current sp %lx does not match saved sp %lx\n",
> orig_sp, stack_addr);
> - pr_err("Saved registers for jprobe %p\n", jp);
> + pr_err("Saved registers for jprobe\n");
> __show_regs(saved_regs);
> pr_err("Current registers\n");
> __show_regs(regs);
>
next prev parent reply other threads:[~2018-01-25 16:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 5:26 [PATCH 0/8] kprobes: Fix %p in kprobes Masami Hiramatsu
2018-01-25 5:26 ` Masami Hiramatsu
2018-01-25 5:27 ` [PATCH 1/8] kprobes: Show blacklist addresses as same as kallsyms does Masami Hiramatsu
2018-01-25 5:27 ` [PATCH 2/8] kprobes: Show address of kprobes if " Masami Hiramatsu
2018-01-25 5:28 ` [PATCH 3/8] kprobes: Replace %p with other pointer types Masami Hiramatsu
2018-01-25 5:28 ` [PATCH 4/8] kprobes/x86: Fix %p uses in error messages Masami Hiramatsu
2018-01-25 5:29 ` [PATCH 5/8] kprobes/arm: " Masami Hiramatsu
2018-01-25 5:29 ` Masami Hiramatsu
2018-01-25 5:29 ` [PATCH 6/8] kprobes/arm64: " Masami Hiramatsu
2018-01-25 16:42 ` Will Deacon [this message]
2018-01-26 5:40 ` Masami Hiramatsu
2018-01-25 5:30 ` [PATCH 7/8] kprobes/MN10300: " Masami Hiramatsu
2018-01-25 5:30 ` [PATCH 8/8] kprobes/s390: " Masami Hiramatsu
2018-01-25 5:30 ` Masami Hiramatsu
2018-01-27 10:15 ` Heiko Carstens
2018-01-27 10:15 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180125164230.GC22963@arm.com \
--to=will.deacon@arm.com \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=tixy@linaro.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).