From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masami Hiramatsu Subject: Re: [PATCH 6/8] kprobes/arm64: Fix %p uses in error messages Date: Fri, 26 Jan 2018 14:40:53 +0900 Message-ID: <20180126144053.82268e050f3fba636f6845df@kernel.org> References: <151685799071.3099.10383062804474021403.stgit@devbox> <151685817205.3099.18079175391687728067.stgit@devbox> <20180125164230.GC22963@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mail.kernel.org ([198.145.29.99]:37458 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751750AbeAZFk7 (ORCPT ); Fri, 26 Jan 2018 00:40:59 -0500 In-Reply-To: <20180125164230.GC22963@arm.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Will Deacon Cc: catalin.marinas@arm.com, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Ingo Molnar , "H . Peter Anvin" , x86@kernel.org, Ananth N Mavinakayanahalli , Anil S Keshavamurthy , "David S . Miller" , Jon Medhurst , Arnd Bergmann , David Howells , Heiko Carstens , "Tobin C . Harding" , Linus Torvalds On Thu, 25 Jan 2018 16:42:31 +0000 Will Deacon wrote: > On Thu, Jan 25, 2018 at 02:29:32PM +0900, Masami Hiramatsu wrote: > > Fix %p uses in error messages by removing it because > > those are redundant or meaningless. > > > > Signed-off-by: Masami Hiramatsu > > --- > > arch/arm64/kernel/probes/kprobes.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Acked-by: Will Deacon > > I guess Catalin can just pick this one up via arm64. OK, thanks! > > Will > > > diff --git a/arch/arm64/kernel/probes/kprobes.c b/arch/arm64/kernel/probes/kprobes.c > > index d849d9804011..34f78d07a068 100644 > > --- a/arch/arm64/kernel/probes/kprobes.c > > +++ b/arch/arm64/kernel/probes/kprobes.c > > @@ -275,7 +275,7 @@ static int __kprobes reenter_kprobe(struct kprobe *p, > > break; > > case KPROBE_HIT_SS: > > case KPROBE_REENTER: > > - pr_warn("Unrecoverable kprobe detected at %p.\n", p->addr); > > + pr_warn("Unrecoverable kprobe detected.\n"); > > dump_kprobe(p); > > BUG(); > > break; > > @@ -521,7 +521,7 @@ int __kprobes longjmp_break_handler(struct kprobe *p, struct pt_regs *regs) > > (struct pt_regs *)kcb->jprobe_saved_regs.sp; > > pr_err("current sp %lx does not match saved sp %lx\n", > > orig_sp, stack_addr); > > - pr_err("Saved registers for jprobe %p\n", jp); > > + pr_err("Saved registers for jprobe\n"); > > __show_regs(saved_regs); > > pr_err("Current registers\n"); > > __show_regs(regs); > > -- Masami Hiramatsu