From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Jon Medhurst <tixy@linaro.org>, Will Deacon <will.deacon@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
David Howells <dhowells@redhat.com>,
"Tobin C . Harding" <me@tobin.cc>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 8/8] kprobes/s390: Fix %p uses in error messages
Date: Sat, 27 Jan 2018 11:15:46 +0100 [thread overview]
Message-ID: <20180127101546.GA3915@osiris> (raw)
In-Reply-To: <151685823207.3099.1804053958699756937.stgit@devbox>
On Thu, Jan 25, 2018 at 02:30:32PM +0900, Masami Hiramatsu wrote:
> Remove %p because the kprobe will be dumped in
> dump_kprobe().
>
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> arch/s390/kernel/kprobes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/kernel/kprobes.c b/arch/s390/kernel/kprobes.c
> index af3722c28fd9..df30e5b9a572 100644
> --- a/arch/s390/kernel/kprobes.c
> +++ b/arch/s390/kernel/kprobes.c
> @@ -282,7 +282,7 @@ static void kprobe_reenter_check(struct kprobe_ctlblk *kcb, struct kprobe *p)
> * is a BUG. The code path resides in the .kprobes.text
> * section and is executed with interrupts disabled.
> */
> - printk(KERN_EMERG "Invalid kprobe detected at %p.\n", p->addr);
> + pr_err("Invalid kprobe detected.\n");
Given that this change makes sense anyway, I just applied it to the s390
tree. :)
Thanks!
next prev parent reply other threads:[~2018-01-27 10:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 5:26 [PATCH 0/8] kprobes: Fix %p in kprobes Masami Hiramatsu
2018-01-25 5:26 ` Masami Hiramatsu
2018-01-25 5:27 ` [PATCH 1/8] kprobes: Show blacklist addresses as same as kallsyms does Masami Hiramatsu
2018-01-25 5:27 ` [PATCH 2/8] kprobes: Show address of kprobes if " Masami Hiramatsu
2018-01-25 5:28 ` [PATCH 3/8] kprobes: Replace %p with other pointer types Masami Hiramatsu
2018-01-25 5:28 ` [PATCH 4/8] kprobes/x86: Fix %p uses in error messages Masami Hiramatsu
2018-01-25 5:29 ` [PATCH 5/8] kprobes/arm: " Masami Hiramatsu
2018-01-25 5:29 ` Masami Hiramatsu
2018-01-25 5:29 ` [PATCH 6/8] kprobes/arm64: " Masami Hiramatsu
2018-01-25 16:42 ` Will Deacon
2018-01-26 5:40 ` Masami Hiramatsu
2018-01-25 5:30 ` [PATCH 7/8] kprobes/MN10300: " Masami Hiramatsu
2018-01-25 5:30 ` [PATCH 8/8] kprobes/s390: " Masami Hiramatsu
2018-01-25 5:30 ` Masami Hiramatsu
2018-01-27 10:15 ` Heiko Carstens [this message]
2018-01-27 10:15 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180127101546.GA3915@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=tixy@linaro.org \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).