From: Matthew Wilcox <willy@infradead.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: Kai Heng Feng <kai.heng.feng@canonical.com>,
Laura Abbott <labbott@redhat.com>,
linux-mm@kvack.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arch@vger.kernel.org,
James.Bottomley@HansenPartnership.com, davem@redhat.com
Subject: Re: Regression after commit 19809c2da28a ("mm, vmalloc: use __GFP_HIGHMEM implicitly")
Date: Sun, 11 Feb 2018 15:51:07 -0800 [thread overview]
Message-ID: <20180211235107.GE4680@bombadil.infradead.org> (raw)
In-Reply-To: <20180211120515.GB4551@bombadil.infradead.org>
On Sun, Feb 11, 2018 at 04:05:15AM -0800, Matthew Wilcox wrote:
> On Sun, Feb 11, 2018 at 03:28:08AM -0800, Matthew Wilcox wrote:
> > Now, longer-term, perhaps we should do the following:
> >
> > #ifdef CONFIG_ZONE_DMA32
> > #define OPT_ZONE_DMA32 ZONE_DMA32
> > #elif defined(CONFIG_64BIT)
> > #define OPT_ZONE_DMA OPT_ZONE_DMA
> > #else
> > #define OPT_ZONE_DMA32 ZONE_NORMAL
> > #endif
>
> For consistent / coherent memory, we have an allocation function.
> But we don't have an allocation function for streaming memory, which is
> what these drivers want. They also flush the DMA memory and then access
> the memory through a different virtual mapping, which I'm not sure is
> going to work well on virtually-indexed caches like SPARC and PA-RISC
> (maybe not MIPS either?)
Perhaps I (and a number of other people ...) have misunderstood the
semantics of GFP_DMA32. Perhaps GFP_DMA32 is not "allocate memory below
4GB", perhaps it's "allocate memory which can be mapped below 4GB".
Machines with an IOMMU can use ZONE_NORMAL. Machines with no IOMMU can
choose to allocate memory with a physical address below 4GB.
After all, it has 'DMA' right there in the name. If someone's relying
on it to allocate physical memory below 4GB, they're arguably misusing it.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: Kai Heng Feng <kai.heng.feng@canonical.com>,
Laura Abbott <labbott@redhat.com>,
linux-mm@kvack.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arch@vger.kernel.org,
James.Bottomley@HansenPartnership.com, davem@redhat.com
Subject: Re: Regression after commit 19809c2da28a ("mm, vmalloc: use __GFP_HIGHMEM implicitly")
Date: Sun, 11 Feb 2018 15:51:07 -0800 [thread overview]
Message-ID: <20180211235107.GE4680@bombadil.infradead.org> (raw)
Message-ID: <20180211235107.1lWG_JGUHkZLh2xa2yUMxic5HpX7YuUVrl43_OAblyM@z> (raw)
In-Reply-To: <20180211120515.GB4551@bombadil.infradead.org>
On Sun, Feb 11, 2018 at 04:05:15AM -0800, Matthew Wilcox wrote:
> On Sun, Feb 11, 2018 at 03:28:08AM -0800, Matthew Wilcox wrote:
> > Now, longer-term, perhaps we should do the following:
> >
> > #ifdef CONFIG_ZONE_DMA32
> > #define OPT_ZONE_DMA32 ZONE_DMA32
> > #elif defined(CONFIG_64BIT)
> > #define OPT_ZONE_DMA OPT_ZONE_DMA
> > #else
> > #define OPT_ZONE_DMA32 ZONE_NORMAL
> > #endif
>
> For consistent / coherent memory, we have an allocation function.
> But we don't have an allocation function for streaming memory, which is
> what these drivers want. They also flush the DMA memory and then access
> the memory through a different virtual mapping, which I'm not sure is
> going to work well on virtually-indexed caches like SPARC and PA-RISC
> (maybe not MIPS either?)
Perhaps I (and a number of other people ...) have misunderstood the
semantics of GFP_DMA32. Perhaps GFP_DMA32 is not "allocate memory below
4GB", perhaps it's "allocate memory which can be mapped below 4GB".
Machines with an IOMMU can use ZONE_NORMAL. Machines with no IOMMU can
choose to allocate memory with a physical address below 4GB.
After all, it has 'DMA' right there in the name. If someone's relying
on it to allocate physical memory below 4GB, they're arguably misusing it.
next prev parent reply other threads:[~2018-02-11 23:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <627DA40A-D0F6-41C1-BB5A-55830FBC9800@canonical.com>
[not found] ` <20180208130649.GA15846@bombadil.infradead.org>
[not found] ` <20180208232004.GA21027@bombadil.infradead.org>
[not found] ` <20180211092652.GV21609@dhcp22.suse.cz>
[not found] ` <20180211112808.GA4551@bombadil.infradead.org>
2018-02-11 12:05 ` Regression after commit 19809c2da28a ("mm, vmalloc: use __GFP_HIGHMEM implicitly") Matthew Wilcox
2018-02-11 12:05 ` Matthew Wilcox
2018-02-11 23:51 ` Matthew Wilcox [this message]
2018-02-11 23:51 ` Matthew Wilcox
2018-02-14 14:04 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180211235107.GE4680@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=davem@redhat.com \
--cc=kai.heng.feng@canonical.com \
--cc=labbott@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).