From: Logan Gunthorpe <logang@deltatee.com>
To: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-ntb@googlegroups.com, linux-crypto@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Horia Geantă" <horia.geanta@nxp.com>,
"Logan Gunthorpe" <logang@deltatee.com>,
"Philippe Ombredanne" <pombredanne@nexb.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Kate Stewart" <kstewart@linuxfoundation.org>
Subject: [PATCH v14 01/10] iomap: Use correct endian conversion function in mmio_writeXXbe
Date: Thu, 22 Mar 2018 11:16:54 -0600 [thread overview]
Message-ID: <20180322171703.4300-2-logang@deltatee.com> (raw)
In-Reply-To: <20180322171703.4300-1-logang@deltatee.com>
The semantics of the iowriteXXbe() functions are to write a
value in CPU endianess to an IO register that is known by the
caller to be in Big Endian. The mmio_writeXXbe() macro, which
is called by iowriteXXbe(), should therefore use cpu_to_beXX()
instead of beXX_to_cpu().
Seeing both beXX_to_cpu() and cpu_to_beXX() are both functionally
implemented as either null operations or swabXX operations there
was no noticable bug here. But it is confusing for both developers
and code analysis tools alike.
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Reviewed-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Philippe Ombredanne <pombredanne@nexb.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Kate Stewart <kstewart@linuxfoundation.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
lib/iomap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/iomap.c b/lib/iomap.c
index 541d926da95e..be120c13d6cc 100644
--- a/lib/iomap.c
+++ b/lib/iomap.c
@@ -106,8 +106,8 @@ EXPORT_SYMBOL(ioread32be);
#endif
#ifndef mmio_write16be
-#define mmio_write16be(val,port) __raw_writew(be16_to_cpu(val),port)
-#define mmio_write32be(val,port) __raw_writel(be32_to_cpu(val),port)
+#define mmio_write16be(val,port) __raw_writew(cpu_to_be16(val),port)
+#define mmio_write32be(val,port) __raw_writel(cpu_to_be32(val),port)
#endif
void iowrite8(u8 val, void __iomem *addr)
--
2.11.0
next prev parent reply other threads:[~2018-03-22 17:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 17:16 [PATCH v14 00/10] Add io{read|write}64 to io-64-atomic headers Logan Gunthorpe
2018-03-22 17:16 ` Logan Gunthorpe
2018-03-22 17:16 ` Logan Gunthorpe [this message]
2018-03-22 17:16 ` [PATCH v14 01/10] iomap: Use correct endian conversion function in mmio_writeXXbe Logan Gunthorpe
2018-03-22 17:16 ` [PATCH v14 02/10] iomap: Add big endian sparse annotations to mmio_{read|write}XXbe() Logan Gunthorpe
2018-03-22 17:16 ` Logan Gunthorpe
2018-03-22 17:27 ` Luc Van Oostenryck
2018-03-22 17:27 ` Luc Van Oostenryck
2018-03-22 17:28 ` Logan Gunthorpe
2018-03-22 17:28 ` Logan Gunthorpe
2018-03-22 17:16 ` [PATCH v14 03/10] parisc: iomap: introduce io{read|write}64 Logan Gunthorpe
2018-03-22 17:16 ` Logan Gunthorpe
2018-03-22 17:16 ` [PATCH v14 04/10] powerpc: io.h: move iomap.h include so that it can use readq/writeq defs Logan Gunthorpe
2018-03-22 17:16 ` Logan Gunthorpe
2018-03-22 17:16 ` [PATCH v14 05/10] powerpc: iomap.c: introduce io{read|write}64_{lo_hi|hi_lo} Logan Gunthorpe
2018-03-22 17:16 ` Logan Gunthorpe
2018-03-22 17:16 ` [PATCH v14 06/10] iomap: " Logan Gunthorpe
2018-03-22 17:16 ` Logan Gunthorpe
2018-03-22 17:17 ` [PATCH v14 07/10] io-64-nonatomic: add io{read|write}64[be]{_lo_hi|_hi_lo} macros Logan Gunthorpe
2018-03-22 17:17 ` Logan Gunthorpe
2018-03-22 17:17 ` [PATCH v14 08/10] ntb: ntb_hw_intel: use io-64-nonatomic instead of in-driver hacks Logan Gunthorpe
2018-03-22 17:17 ` Logan Gunthorpe
2018-03-22 17:17 ` [PATCH v14 09/10] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64 Logan Gunthorpe
2018-03-22 17:17 ` Logan Gunthorpe
2018-03-22 17:17 ` [PATCH v14 10/10] ntb: ntb_hw_switchtec: Cleanup 64bit IO defines to use the common header Logan Gunthorpe
2018-03-22 17:17 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180322171703.4300-2-logang@deltatee.com \
--to=logang@deltatee.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=horia.geanta@nxp.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox