From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guo Ren Subject: Re: [PATCH 00/19] C-SKY(csky) Linux Kernel Port Date: Tue, 27 Mar 2018 09:58:36 +0800 Message-ID: <20180327015835.GA10185@guoren> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: linux-arch , Linux Kernel Mailing List , Thomas Gleixner , Daniel Lezcano , Jason Cooper , c-sky_gcc_upstream@c-sky.com, gnu-csky@mentor.com, thomas.petazzoni@bootlin.com, wbx@uclibc-ng.org List-Id: linux-arch.vger.kernel.org On Mon, Mar 26, 2018 at 03:30:34PM +0200, Arnd Bergmann wrote: > Thanks for your submission. I had started reviewing it over a week > ago, but never > completed since I was travelling in the meantime. I've completed my first pass > now and will wait for a new version before I take a more detailed look. > > Overall, it looks nice, but changing the rest of the system call interface will > take a while, this includes several points I've mentioned already, but > to clarify, > every file in arch/csky/include/uapi/asm/ needs to be carefully reviewed to > contain only the minimum required additions to the asm-generic version. > > Changing the ABI will obviously get in the way of testing, but this should > be over as soon as the port is merged. I entirely agree with you. After modify the unistd.h, we found a lot of ltp-cases failed. We are dealing with them. Best Regards Guo Ren From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp2200-217.mail.aliyun.com ([121.197.200.217]:59598 "EHLO smtp2200-217.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752055AbeC0B6u (ORCPT ); Mon, 26 Mar 2018 21:58:50 -0400 Date: Tue, 27 Mar 2018 09:58:36 +0800 From: Guo Ren Subject: Re: [PATCH 00/19] C-SKY(csky) Linux Kernel Port Message-ID: <20180327015835.GA10185@guoren> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Arnd Bergmann Cc: linux-arch , Linux Kernel Mailing List , Thomas Gleixner , Daniel Lezcano , Jason Cooper , c-sky_gcc_upstream@c-sky.com, gnu-csky@mentor.com, thomas.petazzoni@bootlin.com, wbx@uclibc-ng.org Message-ID: <20180327015836.NYtEMFA4VUPlJL1rHMqGNTZ5YEqKbeZKNbR_7FRMn9c@z> On Mon, Mar 26, 2018 at 03:30:34PM +0200, Arnd Bergmann wrote: > Thanks for your submission. I had started reviewing it over a week > ago, but never > completed since I was travelling in the meantime. I've completed my first pass > now and will wait for a new version before I take a more detailed look. > > Overall, it looks nice, but changing the rest of the system call interface will > take a while, this includes several points I've mentioned already, but > to clarify, > every file in arch/csky/include/uapi/asm/ needs to be carefully reviewed to > contain only the minimum required additions to the asm-generic version. > > Changing the ABI will obviously get in the way of testing, but this should > be over as soon as the port is merged. I entirely agree with you. After modify the unistd.h, we found a lot of ltp-cases failed. We are dealing with them. Best Regards Guo Ren