public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
	Andi Kleen <ak@linux.intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andy Lutomirski <luto@kernel.org>,
	Brian Gerst <brgerst@gmail.com>,
	Denys Vlasenko <dvlasenk@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	x86@kernel.org, Maninder Singh <maninder1.s@samsung.com>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH 0/3] syscalls: clean up stub naming convention
Date: Mon, 9 Apr 2018 09:34:31 +0200	[thread overview]
Message-ID: <20180409073431.3acda3qpyhb35wnt@gmail.com> (raw)
In-Reply-To: <20180409070800.GA14257@light.dominikbrodowski.net>


* Dominik Brodowski <linux@dominikbrodowski.net> wrote:

> > New suggested naming:
> > 
> > 810f08d0 t     kernel_waitid	# common C function (see kernel/exit.c)
> > 
> > <inline>     __do_sys_waitid	# inlined helper doing the actual work
> > 				# (takes original parameters as declared)
> > 
> > 810f1aa0 T   __se_sys_waitid	# sign-extending C function calling inlined
> > 				# helper (takes parameters of type long;
> > 				# casts them to the declared type)
> > 
> > 810f1aa0 T        sys_waitid	# alias to __se_sys_waitid() (but taking
> > 				# original parameters as declared), to be
> > 				# included in syscall table
> > 
> > Agreed?
> 
> Yes.

Ok, great. Since these re-renames look complex enough, mind re-sending the series 
with these changes incorporated and the 4/3 patch incorporated as well (and the 
image shrinking script left out)?

The base patches are looking good here so I plan sending these to Linus 
tomorrow-ish. (The renames don't affect functionality so they don't need
as much testing.)

Thanks,

	Ingo

  parent reply	other threads:[~2018-04-09  7:34 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-07  7:46 [PATCH 0/3] syscalls: clean up stub naming convention Dominik Brodowski
2018-04-07  7:46 ` Dominik Brodowski
2018-04-08  8:35 ` Ingo Molnar
2018-04-08  8:35   ` Ingo Molnar
2018-04-08  9:15   ` Dominik Brodowski
2018-04-08  9:15     ` Dominik Brodowski
2018-04-08 19:59     ` Dominik Brodowski
2018-04-08 19:59       ` Dominik Brodowski
2018-04-08 20:06       ` [PATCH 4/3] syscalls/x86: adapt syscall_wrapper.h to the new syscall " Dominik Brodowski
2018-04-08 20:06         ` Dominik Brodowski
2018-04-09  6:49       ` [PATCH 0/3] syscalls: clean up " Ingo Molnar
2018-04-09  6:49         ` Ingo Molnar
2018-04-09  6:54         ` Dominik Brodowski
2018-04-09  6:54           ` Dominik Brodowski
2018-04-09  6:39     ` Ingo Molnar
2018-04-09  6:39       ` Ingo Molnar
2018-04-09 19:13       ` Linus Torvalds
2018-04-09 19:13         ` Linus Torvalds
2018-04-09  6:45     ` Ingo Molnar
2018-04-09  6:45       ` Ingo Molnar
2018-04-09  6:53       ` Dominik Brodowski
2018-04-09  6:53         ` Dominik Brodowski
2018-04-09  7:06       ` Ingo Molnar
2018-04-09  7:06         ` Ingo Molnar
2018-04-09  7:08         ` Dominik Brodowski
2018-04-09  7:08           ` Dominik Brodowski
2018-04-09  7:34           ` Ingo Molnar [this message]
2018-04-09  7:34             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180409073431.3acda3qpyhb35wnt@gmail.com \
    --to=mingo@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=brgerst@gmail.com \
    --cc=dvlasenk@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=luto@kernel.org \
    --cc=maninder1.s@samsung.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox