From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH v3 5/7] kprobes/x86: Fix %p uses in error messages Date: Fri, 27 Apr 2018 08:58:17 +0200 Message-ID: <20180427065817.tedhin5sy7brgq7m@gmail.com> References: <152481117776.22588.1210388093668905564.stgit@devbox> <152481133105.22588.10668983189195179761.stgit@devbox> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <152481133105.22588.10668983189195179761.stgit@devbox> Sender: linux-kernel-owner@vger.kernel.org To: Masami Hiramatsu Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Ingo Molnar , "H . Peter Anvin" , x86@kernel.org, Ananth N Mavinakayanahalli , Anil S Keshavamurthy , "David S . Miller" , Jon Medhurst , Will Deacon , Arnd Bergmann , David Howells , Heiko Carstens , "Tobin C . Harding" , Linus Torvalds , Thomas Richter , akpm@linux-foundation.org, acme@kernel.org, rostedt@goodmis.org, brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com, stable@vger.kernel.org List-Id: linux-arch.vger.kernel.org * Masami Hiramatsu wrote: > (addr < (u8 *) jprobe_return_end)) { > if (stack_addr(regs) != saved_sp) { > struct pt_regs *saved_regs = &kcb->jprobe_saved_regs; > - printk(KERN_ERR > - "current sp %p does not match saved sp %p\n", > + pr_err("current sp %pS does not match saved sp %pS\n", > stack_addr(regs), saved_sp); Why does this use %pS? Stack pointers are typically pointing into general kernel RAM, which is totally pointless to display 'symbolically'. Thanks, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com ([74.125.82.49]:32935 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757494AbeD0G6V (ORCPT ); Fri, 27 Apr 2018 02:58:21 -0400 Date: Fri, 27 Apr 2018 08:58:17 +0200 From: Ingo Molnar Subject: Re: [PATCH v3 5/7] kprobes/x86: Fix %p uses in error messages Message-ID: <20180427065817.tedhin5sy7brgq7m@gmail.com> References: <152481117776.22588.1210388093668905564.stgit@devbox> <152481133105.22588.10668983189195179761.stgit@devbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152481133105.22588.10668983189195179761.stgit@devbox> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Masami Hiramatsu Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Ingo Molnar , "H . Peter Anvin" , x86@kernel.org, Ananth N Mavinakayanahalli , Anil S Keshavamurthy , "David S . Miller" , Jon Medhurst , Will Deacon , Arnd Bergmann , David Howells , Heiko Carstens , "Tobin C . Harding" , Linus Torvalds , Thomas Richter , akpm@linux-foundation.org, acme@kernel.org, rostedt@goodmis.org, brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com, stable@vger.kernel.org Message-ID: <20180427065817.qqMfLHUxRjIPCXoTbJs_9aBatGjlPRq69HMynRYzDTo@z> * Masami Hiramatsu wrote: > (addr < (u8 *) jprobe_return_end)) { > if (stack_addr(regs) != saved_sp) { > struct pt_regs *saved_regs = &kcb->jprobe_saved_regs; > - printk(KERN_ERR > - "current sp %p does not match saved sp %p\n", > + pr_err("current sp %pS does not match saved sp %pS\n", > stack_addr(regs), saved_sp); Why does this use %pS? Stack pointers are typically pointing into general kernel RAM, which is totally pointless to display 'symbolically'. Thanks, Ingo