From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [RFC] Removal of CONFIG_HAVE_UNDERSCORE_SYMBOL_PREFIX Date: Sat, 5 May 2018 17:55:23 +0200 Message-ID: <20180505155523.GA17349@ravnborg.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Masahiro Yamada Cc: Linus Torvalds , Arnd Bergmann , linux-arch , Linux Kbuild mailing list , Linux Kernel Mailing List , Steven Miao , James Hogan , Andrew Morton , Greg Kroah-Hartman List-Id: linux-arch.vger.kernel.org On Sat, May 05, 2018 at 07:16:13PM +0900, Masahiro Yamada wrote: > Hi. > > > CONFIG_HAVE_UNDERSCORE_SYMBOL_PREFIX was selected > by BLACKFIN and METAG. > > Now that both architectures removed in the previous > merge window, there is no more user of this CONFIG option. No need to keep this around, just in case someone steps up to add support for these archs again. There is no users so it will bit-rot over time anyway, and will confuse new readers. And if an arch shows up there is now a good incentive to do what everyone else does, rather than having special handling in the kernel. Removing the symbol has the extra benefit that the kbuild files becomes a little more readable, something we should always welcome. In other words - drop the symbol. And well spotted! Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from asavdk3.altibox.net ([109.247.116.14]:45870 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751206AbeEEQDA (ORCPT ); Sat, 5 May 2018 12:03:00 -0400 Date: Sat, 5 May 2018 17:55:23 +0200 From: Sam Ravnborg Subject: Re: [RFC] Removal of CONFIG_HAVE_UNDERSCORE_SYMBOL_PREFIX Message-ID: <20180505155523.GA17349@ravnborg.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Masahiro Yamada Cc: Linus Torvalds , Arnd Bergmann , linux-arch , Linux Kbuild mailing list , Linux Kernel Mailing List , Steven Miao , James Hogan , Andrew Morton , Greg Kroah-Hartman Message-ID: <20180505155523.GOCTiTR3I__f9MeEm80Sb403HyW2e3Em8eSXddafF7E@z> On Sat, May 05, 2018 at 07:16:13PM +0900, Masahiro Yamada wrote: > Hi. > > > CONFIG_HAVE_UNDERSCORE_SYMBOL_PREFIX was selected > by BLACKFIN and METAG. > > Now that both architectures removed in the previous > merge window, there is no more user of this CONFIG option. No need to keep this around, just in case someone steps up to add support for these archs again. There is no users so it will bit-rot over time anyway, and will confuse new readers. And if an arch shows up there is now a good incentive to do what everyone else does, rather than having special handling in the kernel. Removing the symbol has the extra benefit that the kbuild files becomes a little more readable, something we should always welcome. In other words - drop the symbol. And well spotted! Sam