From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: [PATCH REPOST 1/5] thread_info: Port core code to use update_thread_flag() helpers Date: Fri, 11 May 2018 11:33:38 -0400 Message-ID: <20180511113338.1d828a50@gandalf.local.home> References: <1526051104-15995-1-git-send-email-Dave.Martin@arm.com> <1526051104-15995-2-git-send-email-Dave.Martin@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1526051104-15995-2-git-send-email-Dave.Martin@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Dave Martin Cc: linux-kernel@vger.kernel.org, Ralf Baechle , James Hogan , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , "David S. Miller" , Ingo Molnar , Peter Zijlstra , Oleg Nesterov , linux-arch@vger.kernel.org List-Id: linux-arch.vger.kernel.org On Fri, 11 May 2018 16:05:00 +0100 Dave Martin wrote: > This patch ports a couple of relevant bits of the core kernel to > use the new update_thread_flag() helpers. > > No functional change. > > Signed-off-by: Dave Martin > Cc: Ingo Molnar > Cc: Peter Zijlstra > Cc: Steven Rostedt > Cc: Oleg Nesterov > --- > include/trace/syscall.h | 6 ++---- > kernel/ptrace.c | 13 +++++-------- > 2 files changed, 7 insertions(+), 12 deletions(-) > > diff --git a/include/trace/syscall.h b/include/trace/syscall.h > index dc8ac27..dcc9bdf 100644 > --- a/include/trace/syscall.h > +++ b/include/trace/syscall.h > @@ -37,10 +37,8 @@ struct syscall_metadata { > #if defined(CONFIG_TRACEPOINTS) && defined(CONFIG_HAVE_SYSCALL_TRACEPOINTS) > static inline void syscall_tracepoint_update(struct task_struct *p) > { > - if (test_thread_flag(TIF_SYSCALL_TRACEPOINT)) > - set_tsk_thread_flag(p, TIF_SYSCALL_TRACEPOINT); > - else > - clear_tsk_thread_flag(p, TIF_SYSCALL_TRACEPOINT); > + update_tsk_thread_flag(p, TIF_SYSCALL_TRACEPOINT, > + test_thread_flag(TIF_SYSCALL_TRACEPOINT)); > } Acked-by: Steven Rostedt (VMware) -- Steve > #else > static inline void syscall_tracepoint_update(struct task_struct *p) > diff --git a/kernel/ptrace.c b/kernel/ptrace.c > index 21fec73..7a2bd8d 100644 > --- a/kernel/ptrace.c > +++ b/kernel/ptrace.c > @@ -785,16 +785,13 @@ static int ptrace_resume(struct task_struct *child, long request, > if (!valid_signal(data)) > return -EIO; > > - if (request == PTRACE_SYSCALL) > - set_tsk_thread_flag(child, TIF_SYSCALL_TRACE); > - else > - clear_tsk_thread_flag(child, TIF_SYSCALL_TRACE); > + update_tsk_thread_flag(child, TIF_SYSCALL_TRACE, > + request == PTRACE_SYSCALL); > > #ifdef TIF_SYSCALL_EMU > - if (request == PTRACE_SYSEMU || request == PTRACE_SYSEMU_SINGLESTEP) > - set_tsk_thread_flag(child, TIF_SYSCALL_EMU); > - else > - clear_tsk_thread_flag(child, TIF_SYSCALL_EMU); > + update_tsk_thread_flag(child, TIF_SYSCALL_EMU, > + request == PTRACE_SYSEMU || > + request == PTRACE_SYSEMU_SINGLESTEP); > #endif > > if (is_singleblock(request)) { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:56456 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751217AbeEKPdl (ORCPT ); Fri, 11 May 2018 11:33:41 -0400 Date: Fri, 11 May 2018 11:33:38 -0400 From: Steven Rostedt Subject: Re: [PATCH REPOST 1/5] thread_info: Port core code to use update_thread_flag() helpers Message-ID: <20180511113338.1d828a50@gandalf.local.home> In-Reply-To: <1526051104-15995-2-git-send-email-Dave.Martin@arm.com> References: <1526051104-15995-1-git-send-email-Dave.Martin@arm.com> <1526051104-15995-2-git-send-email-Dave.Martin@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Dave Martin Cc: linux-kernel@vger.kernel.org, Ralf Baechle , James Hogan , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , "David S. Miller" , Ingo Molnar , Peter Zijlstra , Oleg Nesterov , linux-arch@vger.kernel.org Message-ID: <20180511153338.TE_yvNmPPS-CVn5P3wb6h0mWZM8XkOuZG6NnnnwjYuk@z> On Fri, 11 May 2018 16:05:00 +0100 Dave Martin wrote: > This patch ports a couple of relevant bits of the core kernel to > use the new update_thread_flag() helpers. > > No functional change. > > Signed-off-by: Dave Martin > Cc: Ingo Molnar > Cc: Peter Zijlstra > Cc: Steven Rostedt > Cc: Oleg Nesterov > --- > include/trace/syscall.h | 6 ++---- > kernel/ptrace.c | 13 +++++-------- > 2 files changed, 7 insertions(+), 12 deletions(-) > > diff --git a/include/trace/syscall.h b/include/trace/syscall.h > index dc8ac27..dcc9bdf 100644 > --- a/include/trace/syscall.h > +++ b/include/trace/syscall.h > @@ -37,10 +37,8 @@ struct syscall_metadata { > #if defined(CONFIG_TRACEPOINTS) && defined(CONFIG_HAVE_SYSCALL_TRACEPOINTS) > static inline void syscall_tracepoint_update(struct task_struct *p) > { > - if (test_thread_flag(TIF_SYSCALL_TRACEPOINT)) > - set_tsk_thread_flag(p, TIF_SYSCALL_TRACEPOINT); > - else > - clear_tsk_thread_flag(p, TIF_SYSCALL_TRACEPOINT); > + update_tsk_thread_flag(p, TIF_SYSCALL_TRACEPOINT, > + test_thread_flag(TIF_SYSCALL_TRACEPOINT)); > } Acked-by: Steven Rostedt (VMware) -- Steve > #else > static inline void syscall_tracepoint_update(struct task_struct *p) > diff --git a/kernel/ptrace.c b/kernel/ptrace.c > index 21fec73..7a2bd8d 100644 > --- a/kernel/ptrace.c > +++ b/kernel/ptrace.c > @@ -785,16 +785,13 @@ static int ptrace_resume(struct task_struct *child, long request, > if (!valid_signal(data)) > return -EIO; > > - if (request == PTRACE_SYSCALL) > - set_tsk_thread_flag(child, TIF_SYSCALL_TRACE); > - else > - clear_tsk_thread_flag(child, TIF_SYSCALL_TRACE); > + update_tsk_thread_flag(child, TIF_SYSCALL_TRACE, > + request == PTRACE_SYSCALL); > > #ifdef TIF_SYSCALL_EMU > - if (request == PTRACE_SYSEMU || request == PTRACE_SYSEMU_SINGLESTEP) > - set_tsk_thread_flag(child, TIF_SYSCALL_EMU); > - else > - clear_tsk_thread_flag(child, TIF_SYSCALL_EMU); > + update_tsk_thread_flag(child, TIF_SYSCALL_EMU, > + request == PTRACE_SYSEMU || > + request == PTRACE_SYSEMU_SINGLESTEP); > #endif > > if (is_singleblock(request)) {