From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartosz Golaszewski Subject: [PATCH 02/12] platform/early: don't WARN() on non-empty devres list for early devices Date: Fri, 11 May 2018 18:20:18 +0200 Message-ID: <20180511162028.20616-3-brgl@bgdev.pl> References: <20180511162028.20616-1-brgl@bgdev.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180511162028.20616-1-brgl@bgdev.pl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sekhar Nori , Kevin Hilman , David Lechner , Michael Turquette , Stephen Boyd , Arnd Bergmann , Greg Kroah-Hartman , Mark Rutland , Yoshinori Sato , Rich Felker , Andy Shevchenko , Marc Zyngier , "Rafael J . Wysocki" , Peter Rosin , Jiri Slaby , Thomas Gleixner , Daniel Lezcano , Geert Uytterhoeven , Magnus Damm , Johan Hovold , Rob Herring , Frank Rowand Cc: linux-arch@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski List-Id: linux-arch.vger.kernel.org From: Bartosz Golaszewski Early platform devices can have devres objects allocated in early_probe(). This is not a bug so don't dump stack in this case. Signed-off-by: Bartosz Golaszewski --- drivers/base/dd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/dd.c b/drivers/base/dd.c index c9f54089429b..0b94d9426757 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -410,7 +410,7 @@ static int really_probe(struct device *dev, struct device_driver *drv) atomic_inc(&probe_count); pr_debug("bus: '%s': %s: probing driver %s with device %s\n", drv->bus->name, __func__, drv->name, dev_name(dev)); - WARN_ON(!list_empty(&dev->devres_head)); + WARN_ON(!dev->early && !list_empty(&dev->devres_head)); re_probe: dev->driver = drv; -- 2.17.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:37843 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752082AbeEKQV3 (ORCPT ); Fri, 11 May 2018 12:21:29 -0400 Received: by mail-wm0-f68.google.com with SMTP id l1-v6so4254000wmb.2 for ; Fri, 11 May 2018 09:21:29 -0700 (PDT) From: Bartosz Golaszewski Subject: [PATCH 02/12] platform/early: don't WARN() on non-empty devres list for early devices Date: Fri, 11 May 2018 18:20:18 +0200 Message-ID: <20180511162028.20616-3-brgl@bgdev.pl> In-Reply-To: <20180511162028.20616-1-brgl@bgdev.pl> References: <20180511162028.20616-1-brgl@bgdev.pl> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Sekhar Nori , Kevin Hilman , David Lechner , Michael Turquette , Stephen Boyd , Arnd Bergmann , Greg Kroah-Hartman , Mark Rutland , Yoshinori Sato , Rich Felker , Andy Shevchenko , Marc Zyngier , "Rafael J . Wysocki" , Peter Rosin , Jiri Slaby , Thomas Gleixner , Daniel Lezcano , Geert Uytterhoeven , Magnus Damm , Johan Hovold , Rob Herring , Frank Rowand Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, Bartosz Golaszewski Message-ID: <20180511162018.rHhYSBQkan0dAgJD8gyBAzf53kuh1eSScYnPGxe22_g@z> From: Bartosz Golaszewski Early platform devices can have devres objects allocated in early_probe(). This is not a bug so don't dump stack in this case. Signed-off-by: Bartosz Golaszewski --- drivers/base/dd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/dd.c b/drivers/base/dd.c index c9f54089429b..0b94d9426757 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -410,7 +410,7 @@ static int really_probe(struct device *dev, struct device_driver *drv) atomic_inc(&probe_count); pr_debug("bus: '%s': %s: probing driver %s with device %s\n", drv->bus->name, __func__, drv->name, dev_name(dev)); - WARN_ON(!list_empty(&dev->devres_head)); + WARN_ON(!dev->early && !list_empty(&dev->devres_head)); re_probe: dev->driver = drv; -- 2.17.0