From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masami Hiramatsu Subject: Re: [RFC PATCH -tip v5 18/27] powerpc/kprobes: Don't call the ->break_handler() in arm kprobes code Date: Fri, 8 Jun 2018 09:42:11 +0900 Message-ID: <20180608094211.0d225831bb7acc100b7c2436@kernel.org> References: <152812730943.10068.5166429445118734697.stgit@devbox> <152812783350.10068.4690566636762511152.stgit@devbox> <1528371112.vwnh1m0k39.naveen@linux.ibm.com> <20180607232802.c5fcea960e94ef2f3cd4cde8@kernel.org> <1528389409.62iyaqw9yn.naveen@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1528389409.62iyaqw9yn.naveen@linux.ibm.com> Sender: linux-kernel-owner@vger.kernel.org To: "Naveen N. Rao" Cc: Andrew Morton , "H . Peter Anvin" , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Ingo Molnar , Ingo Molnar , Paul Mackerras , Steven Rostedt , Thomas Gleixner List-Id: linux-arch.vger.kernel.org On Thu, 07 Jun 2018 22:07:26 +0530 "Naveen N. Rao" wrote: > Masami Hiramatsu wrote: > > On Thu, 07 Jun 2018 17:07:00 +0530 > > "Naveen N. Rao" wrote: > > > >> Masami Hiramatsu wrote: > >> > Don't call the ->break_handler() from the arm kprobes code, > >> ^^^ powerpc > >> > >> > because it was only used by jprobes which got removed. > >> > > >> > This also makes skip_singlestep() a static function since > >> > only ftrace-kprobe.c is using this function. > >> > > >> > Signed-off-by: Masami Hiramatsu > >> > Cc: Benjamin Herrenschmidt > >> > Cc: Paul Mackerras > >> > Cc: Michael Ellerman > >> > Cc: "Naveen N. Rao" > >> > Cc: linuxppc-dev@lists.ozlabs.org > >> > --- > >> > arch/powerpc/include/asm/kprobes.h | 10 ---------- > >> > arch/powerpc/kernel/kprobes-ftrace.c | 16 +++------------- > >> > arch/powerpc/kernel/kprobes.c | 31 +++++++++++-------------------- > >> > 3 files changed, 14 insertions(+), 43 deletions(-) > >> > >> With 2 small comments... > > > > 2 ? or 1 ? > > Two, with one in the commit log above :) Oops, sorry I missed it. yeah, the comment above is my mistake. I'll fix it. Thanks! -- Masami Hiramatsu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:46506 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752178AbeFHAmP (ORCPT ); Thu, 7 Jun 2018 20:42:15 -0400 Date: Fri, 8 Jun 2018 09:42:11 +0900 From: Masami Hiramatsu Subject: Re: [RFC PATCH -tip v5 18/27] powerpc/kprobes: Don't call the ->break_handler() in arm kprobes code Message-ID: <20180608094211.0d225831bb7acc100b7c2436@kernel.org> In-Reply-To: <1528389409.62iyaqw9yn.naveen@linux.ibm.com> References: <152812730943.10068.5166429445118734697.stgit@devbox> <152812783350.10068.4690566636762511152.stgit@devbox> <1528371112.vwnh1m0k39.naveen@linux.ibm.com> <20180607232802.c5fcea960e94ef2f3cd4cde8@kernel.org> <1528389409.62iyaqw9yn.naveen@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: "Naveen N. Rao" Cc: Andrew Morton , "H . Peter Anvin" , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Ingo Molnar , Ingo Molnar , Paul Mackerras , Steven Rostedt , Thomas Gleixner Message-ID: <20180608004211.kPwAhN4mscOTZkv-UTM-Akcs9cP0BwXYNCJdVXezifs@z> On Thu, 07 Jun 2018 22:07:26 +0530 "Naveen N. Rao" wrote: > Masami Hiramatsu wrote: > > On Thu, 07 Jun 2018 17:07:00 +0530 > > "Naveen N. Rao" wrote: > > > >> Masami Hiramatsu wrote: > >> > Don't call the ->break_handler() from the arm kprobes code, > >> ^^^ powerpc > >> > >> > because it was only used by jprobes which got removed. > >> > > >> > This also makes skip_singlestep() a static function since > >> > only ftrace-kprobe.c is using this function. > >> > > >> > Signed-off-by: Masami Hiramatsu > >> > Cc: Benjamin Herrenschmidt > >> > Cc: Paul Mackerras > >> > Cc: Michael Ellerman > >> > Cc: "Naveen N. Rao" > >> > Cc: linuxppc-dev@lists.ozlabs.org > >> > --- > >> > arch/powerpc/include/asm/kprobes.h | 10 ---------- > >> > arch/powerpc/kernel/kprobes-ftrace.c | 16 +++------------- > >> > arch/powerpc/kernel/kprobes.c | 31 +++++++++++-------------------- > >> > 3 files changed, 14 insertions(+), 43 deletions(-) > >> > >> With 2 small comments... > > > > 2 ? or 1 ? > > Two, with one in the commit log above :) Oops, sorry I missed it. yeah, the comment above is my mistake. I'll fix it. Thanks! -- Masami Hiramatsu