linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Logan Gunthorpe <logang@deltatee.com>
To: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	linux-ntb@googlegroups.com, linux-crypto@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Andy Shevchenko" <andy.shevchenko@gmail.com>,
	"Horia Geantă" <horia.geanta@nxp.com>,
	"Logan Gunthorpe" <logang@deltatee.com>,
	"Christoph Hellwig" <hch@lst.de>,
	"Alan Cox" <gnomes@lxorguk.ukuu.org.uk>
Subject: [PATCH v18 4/7] io-64-nonatomic: add io{read|write}64[be]{_lo_hi|_hi_lo} macros
Date: Fri, 22 Jun 2018 13:47:49 -0600	[thread overview]
Message-ID: <20180622194752.11221-5-logang@deltatee.com> (raw)
In-Reply-To: <20180622194752.11221-1-logang@deltatee.com>

This patch adds generic io{read|write}64[be]{_lo_hi|_hi_lo} macros if
they are not already defined by the architecture. (As they are provided
by the generic iomap library).

The patch also points io{read|write}64[be] to the variant specified by the
header name.

This is because new drivers are encouraged to use ioreadXX, et al instead
of readX[1], et al -- and mixing ioreadXX with readq is pretty ugly.

[1] LDD3: section 9.4.2

Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 include/linux/io-64-nonatomic-hi-lo.h | 64 +++++++++++++++++++++++++++++++++++
 include/linux/io-64-nonatomic-lo-hi.h | 64 +++++++++++++++++++++++++++++++++++
 2 files changed, 128 insertions(+)

diff --git a/include/linux/io-64-nonatomic-hi-lo.h b/include/linux/io-64-nonatomic-hi-lo.h
index 862d786a904f..ae21b72cce85 100644
--- a/include/linux/io-64-nonatomic-hi-lo.h
+++ b/include/linux/io-64-nonatomic-hi-lo.h
@@ -55,4 +55,68 @@ static inline void hi_lo_writeq_relaxed(__u64 val, volatile void __iomem *addr)
 #define writeq_relaxed hi_lo_writeq_relaxed
 #endif
 
+#ifndef ioread64_hi_lo
+#define ioread64_hi_lo ioread64_hi_lo
+static inline u64 ioread64_hi_lo(void __iomem *addr)
+{
+	u32 low, high;
+
+	high = ioread32(addr + sizeof(u32));
+	low = ioread32(addr);
+
+	return low + ((u64)high << 32);
+}
+#endif
+
+#ifndef iowrite64_hi_lo
+#define iowrite64_hi_lo iowrite64_hi_lo
+static inline void iowrite64_hi_lo(u64 val, void __iomem *addr)
+{
+	iowrite32(val >> 32, addr + sizeof(u32));
+	iowrite32(val, addr);
+}
+#endif
+
+#ifndef ioread64be_hi_lo
+#define ioread64be_hi_lo ioread64be_hi_lo
+static inline u64 ioread64be_hi_lo(void __iomem *addr)
+{
+	u32 low, high;
+
+	high = ioread32be(addr);
+	low = ioread32be(addr + sizeof(u32));
+
+	return low + ((u64)high << 32);
+}
+#endif
+
+#ifndef iowrite64be_hi_lo
+#define iowrite64be_hi_lo iowrite64be_hi_lo
+static inline void iowrite64be_hi_lo(u64 val, void __iomem *addr)
+{
+	iowrite32be(val >> 32, addr);
+	iowrite32be(val, addr + sizeof(u32));
+}
+#endif
+
+#ifndef ioread64
+#define ioread64_is_nonatomic
+#define ioread64 ioread64_hi_lo
+#endif
+
+#ifndef iowrite64
+#define iowrite64_is_nonatomic
+#define iowrite64 iowrite64_hi_lo
+#endif
+
+#ifndef ioread64be
+#define ioread64be_is_nonatomic
+#define ioread64be ioread64be_hi_lo
+#endif
+
+#ifndef iowrite64be
+#define iowrite64be_is_nonatomic
+#define iowrite64be iowrite64be_hi_lo
+#endif
+
 #endif	/* _LINUX_IO_64_NONATOMIC_HI_LO_H_ */
diff --git a/include/linux/io-64-nonatomic-lo-hi.h b/include/linux/io-64-nonatomic-lo-hi.h
index d042e7bb5adb..faaa842dbdb9 100644
--- a/include/linux/io-64-nonatomic-lo-hi.h
+++ b/include/linux/io-64-nonatomic-lo-hi.h
@@ -55,4 +55,68 @@ static inline void lo_hi_writeq_relaxed(__u64 val, volatile void __iomem *addr)
 #define writeq_relaxed lo_hi_writeq_relaxed
 #endif
 
+#ifndef ioread64_lo_hi
+#define ioread64_lo_hi ioread64_lo_hi
+static inline u64 ioread64_lo_hi(void __iomem *addr)
+{
+	u32 low, high;
+
+	low = ioread32(addr);
+	high = ioread32(addr + sizeof(u32));
+
+	return low + ((u64)high << 32);
+}
+#endif
+
+#ifndef iowrite64_lo_hi
+#define iowrite64_lo_hi iowrite64_lo_hi
+static inline void iowrite64_lo_hi(u64 val, void __iomem *addr)
+{
+	iowrite32(val, addr);
+	iowrite32(val >> 32, addr + sizeof(u32));
+}
+#endif
+
+#ifndef ioread64be_lo_hi
+#define ioread64be_lo_hi ioread64be_lo_hi
+static inline u64 ioread64be_lo_hi(void __iomem *addr)
+{
+	u32 low, high;
+
+	low = ioread32be(addr + sizeof(u32));
+	high = ioread32be(addr);
+
+	return low + ((u64)high << 32);
+}
+#endif
+
+#ifndef iowrite64be_lo_hi
+#define iowrite64be_lo_hi iowrite64be_lo_hi
+static inline void iowrite64be_lo_hi(u64 val, void __iomem *addr)
+{
+	iowrite32be(val, addr + sizeof(u32));
+	iowrite32be(val >> 32, addr);
+}
+#endif
+
+#ifndef ioread64
+#define ioread64_is_nonatomic
+#define ioread64 ioread64_lo_hi
+#endif
+
+#ifndef iowrite64
+#define iowrite64_is_nonatomic
+#define iowrite64 iowrite64_lo_hi
+#endif
+
+#ifndef ioread64be
+#define ioread64be_is_nonatomic
+#define ioread64be ioread64be_lo_hi
+#endif
+
+#ifndef iowrite64be
+#define iowrite64be_is_nonatomic
+#define iowrite64be iowrite64be_lo_hi
+#endif
+
 #endif	/* _LINUX_IO_64_NONATOMIC_LO_HI_H_ */
-- 
2.11.0

  parent reply	other threads:[~2018-06-22 19:47 UTC|newest]

Thread overview: 98+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-22 19:47 [PATCH v18 0/7] Add io{read|write}64 to io-64-atomic headers Logan Gunthorpe
2018-06-22 19:47 ` Logan Gunthorpe
2018-06-22 19:47 ` [PATCH v18 1/7] iomap: Use non-raw io functions for io{read|write}XXbe Logan Gunthorpe
2018-06-22 19:47   ` Logan Gunthorpe
2018-06-22 19:47 ` [PATCH v18 2/7] parisc: iomap: introduce io{read|write}64 Logan Gunthorpe
2018-06-22 19:47   ` Logan Gunthorpe
2018-06-22 19:47 ` [PATCH v18 3/7] iomap: introduce io{read|write}64_{lo_hi|hi_lo} Logan Gunthorpe
2018-06-22 19:47   ` Logan Gunthorpe
2018-07-13 23:38   ` [v18,3/7] " Guenter Roeck
2018-07-13 23:38     ` Guenter Roeck
2018-07-14  0:20     ` Logan Gunthorpe
2018-07-14  0:20       ` Logan Gunthorpe
2018-07-14  1:12       ` Guenter Roeck
2018-07-14  1:12         ` Guenter Roeck
2018-06-22 19:47 ` Logan Gunthorpe [this message]
2018-06-22 19:47   ` [PATCH v18 4/7] io-64-nonatomic: add io{read|write}64[be]{_lo_hi|_hi_lo} macros Logan Gunthorpe
2018-06-22 19:47 ` [PATCH v18 5/7] ntb: ntb_hw_intel: use io-64-nonatomic instead of in-driver hacks Logan Gunthorpe
2018-06-22 19:47   ` Logan Gunthorpe
2018-06-22 19:47 ` [PATCH v18 6/7] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64 Logan Gunthorpe
2018-06-22 19:47   ` Logan Gunthorpe
2018-07-03 15:31   ` Fabio Estevam
2018-07-03 15:31     ` Fabio Estevam
2018-07-03 17:36     ` Andy Shevchenko
2018-07-03 17:36       ` Andy Shevchenko
2018-07-03 17:44       ` Fabio Estevam
2018-07-03 17:44         ` Fabio Estevam
2018-07-03 18:01       ` Logan Gunthorpe
2018-07-03 18:01         ` Logan Gunthorpe
2018-07-03 18:06         ` Fabio Estevam
2018-07-03 18:06           ` Fabio Estevam
2018-07-03 18:09           ` Andy Shevchenko
2018-07-03 18:09             ` Andy Shevchenko
2018-07-03 18:11             ` Fabio Estevam
2018-07-03 18:11               ` Fabio Estevam
2018-07-03 18:47               ` Logan Gunthorpe
2018-07-03 18:47                 ` Logan Gunthorpe
2018-07-03 19:40                 ` Fabio Estevam
2018-07-03 19:40                   ` Fabio Estevam
2018-07-03 19:58                   ` Andy Shevchenko
2018-07-03 19:58                     ` Andy Shevchenko
2018-07-03 20:10                     ` Fabio Estevam
2018-07-03 20:10                       ` Fabio Estevam
2018-07-03 20:40                       ` Andy Shevchenko
2018-07-03 20:40                         ` Andy Shevchenko
2018-07-03 20:42                         ` Andy Shevchenko
2018-07-03 20:42                           ` Andy Shevchenko
2018-07-03 23:55                         ` Fabio Estevam
2018-07-03 23:55                           ` Fabio Estevam
2018-07-03 21:16                       ` Logan Gunthorpe
2018-07-03 21:16                         ` Logan Gunthorpe
2018-07-03 23:56                         ` Fabio Estevam
2018-07-03 23:56                           ` Fabio Estevam
2018-07-03 21:20                   ` Logan Gunthorpe
2018-07-03 21:20                     ` Logan Gunthorpe
2018-07-03 22:21                     ` Andy Shevchenko
2018-07-03 22:21                       ` Andy Shevchenko
2018-07-03 23:20                       ` Logan Gunthorpe
2018-07-03 23:20                         ` Logan Gunthorpe
2018-07-03 23:52                         ` Fabio Estevam
2018-07-03 23:52                           ` Fabio Estevam
2018-07-03 23:57                       ` Logan Gunthorpe
2018-07-03 23:57                         ` Logan Gunthorpe
2018-07-04  0:02                         ` Logan Gunthorpe
2018-07-04  0:02                           ` Logan Gunthorpe
2018-07-04  0:06                           ` Fabio Estevam
2018-07-04  0:06                             ` Fabio Estevam
2018-07-04 11:45                         ` Horia Geanta
2018-07-04 11:45                           ` Horia Geanta
2018-07-04 15:06                           ` Fabio Estevam
2018-07-04 15:06                             ` Fabio Estevam
2018-07-04 15:59                             ` Horia Geanta
2018-07-04 15:59                               ` Horia Geanta
2018-07-04 16:16                               ` Fabio Estevam
2018-07-04 16:16                                 ` Fabio Estevam
2018-07-04 17:01                             ` Logan Gunthorpe
2018-07-04 17:01                               ` Logan Gunthorpe
2018-07-04 17:10                               ` Andy Shevchenko
2018-07-04 17:10                                 ` Andy Shevchenko
2018-07-04 17:13                                 ` Logan Gunthorpe
2018-07-04 17:13                                   ` Logan Gunthorpe
2018-07-04 17:16                                   ` Andy Shevchenko
2018-07-04 17:16                                     ` Andy Shevchenko
2018-07-04 17:21                                     ` Logan Gunthorpe
2018-07-04 17:21                                       ` Logan Gunthorpe
2018-07-04 17:21                                     ` Andy Shevchenko
2018-07-04 17:21                                       ` Andy Shevchenko
2018-07-04 17:23                                       ` Logan Gunthorpe
2018-07-04 17:23                                         ` Logan Gunthorpe
2018-07-04 17:25                                         ` Andy Shevchenko
2018-07-04 17:25                                           ` Andy Shevchenko
2018-07-04 17:32                           ` Andy Shevchenko
2018-07-04 17:32                             ` Andy Shevchenko
2018-07-04 17:36                             ` Logan Gunthorpe
2018-07-04 17:36                               ` Logan Gunthorpe
2018-07-03 18:06         ` Andy Shevchenko
2018-07-03 18:06           ` Andy Shevchenko
2018-06-22 19:47 ` [PATCH v18 7/7] ntb: ntb_hw_switchtec: Cleanup 64bit IO defines to use the common header Logan Gunthorpe
2018-06-22 19:47   ` Logan Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180622194752.11221-5-logang@deltatee.com \
    --to=logang@deltatee.com \
    --cc=akpm@linux-foundation.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=arnd@arndb.de \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@lst.de \
    --cc=horia.geanta@nxp.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-ntb@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).