From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guo Ren Subject: Re: [PATCH V2 01/19] csky: Build infrastructure Date: Tue, 3 Jul 2018 17:14:09 +0800 Message-ID: <20180703091407.GA31664@guoren> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: linux-arch@vger.kernel.org, Linux Kernel Mailing List , Thomas Gleixner , Daniel Lezcano , Jason Cooper , Arnd Bergmann , c-sky_gcc_upstream@c-sky.com, gnu-csky@mentor.com, thomas.petazzoni@bootlin.com, wbx@uclibc-ng.org, Greentime Hu List-Id: linux-arch.vger.kernel.org On Mon, Jul 02, 2018 at 09:33:51PM -0600, Rob Herring wrote: > > +config CSKY_BUILTIN_DTB > > + bool "Use kernel builtin dtb" > > + > > +config CSKY_BUILTIN_DTB_NAME > > + string "kernel builtin dtb name" > > + depends on CSKY_BUILTIN_DTB > > +endmenu > > These options generally exist for backwards compatibility with legacy > bootloaders that don't support DT which shouldn't apply here given > this is a new arch. If we need this for other reasons, it should not > be an architecture specific option. We want the BUILTIN_DTB for some boards and they don't need change dtb at all. And I just follow other archs BUILTIN_DTB in their Kconfig. eg: xtensa, h8300, mips, nds32, sh, openrisc, arc ... I just keep this in Kconfig.debug and it's not a recommended method. Guo Ren From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp2200-217.mail.aliyun.com ([121.197.200.217]:57340 "EHLO smtp2200-217.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754096AbeGCJOU (ORCPT ); Tue, 3 Jul 2018 05:14:20 -0400 Date: Tue, 3 Jul 2018 17:14:09 +0800 From: Guo Ren Subject: Re: [PATCH V2 01/19] csky: Build infrastructure Message-ID: <20180703091407.GA31664@guoren> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Rob Herring Cc: linux-arch@vger.kernel.org, Linux Kernel Mailing List , Thomas Gleixner , Daniel Lezcano , Jason Cooper , Arnd Bergmann , c-sky_gcc_upstream@c-sky.com, gnu-csky@mentor.com, thomas.petazzoni@bootlin.com, wbx@uclibc-ng.org, Greentime Hu Message-ID: <20180703091409.xtZrsriaLnTXcxup03-k_i3QSw8w6IERdBxoIBIJMBg@z> On Mon, Jul 02, 2018 at 09:33:51PM -0600, Rob Herring wrote: > > +config CSKY_BUILTIN_DTB > > + bool "Use kernel builtin dtb" > > + > > +config CSKY_BUILTIN_DTB_NAME > > + string "kernel builtin dtb name" > > + depends on CSKY_BUILTIN_DTB > > +endmenu > > These options generally exist for backwards compatibility with legacy > bootloaders that don't support DT which shouldn't apply here given > this is a new arch. If we need this for other reasons, it should not > be an architecture specific option. We want the BUILTIN_DTB for some boards and they don't need change dtb at all. And I just follow other archs BUILTIN_DTB in their Kconfig. eg: xtensa, h8300, mips, nds32, sh, openrisc, arc ... I just keep this in Kconfig.debug and it's not a recommended method. Guo Ren