From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v2] devres: Really align data field to unsigned long long Date: Mon, 9 Jul 2018 06:18:05 +0200 Message-ID: <20180709041805.GA5983@kroah.com> References: <20180708175621.6951-1-abrodkin@synopsys.com> <20180708184049.GA1645@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+gla-linux-snps-arc=m.gmane.org@lists.infradead.org To: =?utf-8?B?0JDQu9C10LrRgdC10Lkg0JHRgNC+0LTQutC40L0=?= Cc: linux-arch@vger.kernel.org, Alexey Brodkin , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Thomas Gleixner , linux-snps-arc@lists.infradead.org List-Id: linux-arch.vger.kernel.org T24gU3VuLCBKdWwgMDgsIDIwMTggYXQgMDk6NDU6MzFQTSArMDMwMCwg0JDQu9C10LrRgdC10Lkg 0JHRgNC+0LTQutC40L0gd3JvdGU6Cj4gSGkgR3JlZywKPiAKPiDQstGBLCA4INC40Y7Quy4gMjAx OCDQsy4g0LIgMjE6NDAsIEdyZWcgS0ggPGdyZWdAa3JvYWguY29tPjoKPiA+Cj4gPiBPbiBTdW4s IEp1bCAwOCwgMjAxOCBhdCAwODo1NjoyMVBNICswMzAwLCBBbGV4ZXkgQnJvZGtpbiB3cm90ZToK PiA+ID4gRGVwZW5kaW5nIG9uIEFCSSAibG9uZyBsb25nIiB0eXBlIG9mIGEgcGFydGljdWxhciAz Mi1iaXQgQ1BVCj4gPiA+IG1pZ2h0IGJlIGFsaWduZWQgYnkgZWl0aGVyIHdvcmQgKDMyLWJpdHMp IG9yIGRvdWJsZSB3b3JkICg2NC1iaXRzKS4KPiA+ID4gTWFrZSBzdXJlICJkYXRhIiBpcyByZWFs bHkgNjQtYml0IGFsaWduZWQgZm9yIGFueSAzMi1iaXQgQ1BVLgo+ID4gPgo+ID4gPiBBdCBsZWFz dCBmb3IgMzItYml0IEFSQyBjb3JlcyBBQkkgcmVxdWlyZXMgImxvbmcgbG9uZyIgdHlwZXMKPiA+ ID4gdG8gYmUgYWxpZ25lZCBieSBub3JtYWwgMzItYml0IHdvcmQuIFRoaXMgbWFrZXMgImRhdGEi IGZpZWxkIGFsaWduZWQgdG8KPiA+ID4gMTIgYnl0ZXMuIFdoaWNoIGlzIHN0aWxsIE9LIGFzIGxv bmcgYXMgd2UgdXNlIDMyLWJpdCBkYXRhIG9ubHkuCj4gPiA+Cj4gPiA+IEJ1dCBvbmNlIHdlIHdh bnQgdG8gdXNlIG5hdGl2ZSBhdG9taWM2NF90IHR5cGUgKGkuZS4gd2hlbiB3ZSB1c2Ugc3BlY2lh bAo+ID4gPiBpbnN0cnVjdGlvbnMgTExPQ0tEL1NDT05ERCBmb3IgYWNjZXNzaW5nIDY0LWJpdCBk YXRhKSB3ZSBlYXNpbHkgaGl0Cj4gPiA+IG1pc2FsaWduZWQgYWNjZXNzIGV4Y2VwdGlvbi4KPiA+ ID4KPiA+ID4gVGhhdCdzIGJlY2F1c2UgZXZlbiBvbiBDUFVzIGNhcGFibGUgb2Ygbm9uLWFsaWdu ZWQgZGF0YSBhY2Nlc3MgTEwvU0MKPiA+ID4gaW5zdHJ1Y3Rpb25zIHJlcXVpcmUgc3RyaWN0IGFs aWdubWVudC4KPiA+ID4KPiA+ID4gU2lnbmVkLW9mZi1ieTogQWxleGV5IEJyb2RraW4gPGFicm9k a2luQHN5bm9wc3lzLmNvbT4KPiA+ID4gQ2M6IFRob21hcyBHbGVpeG5lciA8dGdseEBsaW51dHJv bml4LmRlPgo+ID4gPiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwo+ID4gPiAtLS0KPiA+ID4K PiA+ID4gQ2hhbmdlcyB2MSAtPiB2MjoKPiA+ID4KPiA+ID4gICogUmV3b3JkZWQgY29tbWl0IG1l c3NhZ2UKPiA+ID4gICogSW5zZXJ0ZWQgY29tbWVudCByaWdodCBpbiBzb3VyY2UgW1Rob21hc10K PiA+ID4KPiA+ID4gIGRyaXZlcnMvYmFzZS9kZXZyZXMuYyB8IDggKysrKysrLS0KPiA+ID4gIDEg ZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gPgo+ID4gQWx3 YXlzIHVzZSBzY3JpcHRzL2dldF9tYWludGFpbmVyLnBsIHRvIHByb3Blcmx5IGNjOiB0aGUgbmVl ZGVkCj4gPiBkZXZlbG9wZXIvbWFpbnRhaW5lci4gIEFzIGl0IGlzLCB0aGlzIHBhdGNoIGlzIGdv aW5nIHRvIGdldCBkcm9wcGVkIG9uCj4gPiB0aGUgZmxvb3IsIHNvcnJ5Li4uCj4gCj4gUmlnaHQg SSB3YXMgd2F5IHRvbyByZWxheGVkIGRlYWxpbmcgd2l0aCB2ZXJ5IGdlbmVyaWMgc3R1ZmYgd2hp Y2ggbWlnaHQgZ2V0Cj4gbm90IHRoYXQgbXVjaCBvZiBhdHRlbnRpb24gYXMgbW9yZSBuYXJyb3cg dG9waWNzIG9yIHN1YnN5c3RlbXMuIEJ1dCBhbnl3YXlzCj4gZ2V0X21haW50YWluZXIucGwgc2F5 cyB5b3UncmUgdGhlIGd1eSBzbyBkbyBJIG5lZWQgdG8gZG8gYW55dGhpbmcgZXh0cmEgc3RpbGwg b3IKPiBpdCdzIE9LIGZvciB0aGlzIHRpbWU/CgpQbGVhc2UgcmVzZW5kIGl0IHByb3Blcmx5LCBp dCBpcyBub3QgaW4gbXkgcGF0Y2ggcXVldWUgYW55d2hlcmUuLi4KCmdyZWcgay1oCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1zbnBzLWFyYyBt YWlsaW5nIGxpc3QKbGludXgtc25wcy1hcmNAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXNucHMtYXJj From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:60391 "EHLO wout1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750814AbeGIE0U (ORCPT ); Mon, 9 Jul 2018 00:26:20 -0400 Date: Mon, 9 Jul 2018 06:18:05 +0200 From: Greg KH Subject: Re: [PATCH v2] devres: Really align data field to unsigned long long Message-ID: <20180709041805.GA5983@kroah.com> References: <20180708175621.6951-1-abrodkin@synopsys.com> <20180708184049.GA1645@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: =?utf-8?B?0JDQu9C10LrRgdC10Lkg0JHRgNC+0LTQutC40L0=?= Cc: linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arch@vger.kernel.org, Alexey Brodkin , Thomas Gleixner , stable@vger.kernel.org Message-ID: <20180709041805.7DsHbzmw-QFHhTq1WFDMpwwAXzlObQwDNnngM_mFlTE@z> On Sun, Jul 08, 2018 at 09:45:31PM +0300, Алексей Бродкин wrote: > Hi Greg, > > вс, 8 июл. 2018 г. в 21:40, Greg KH : > > > > On Sun, Jul 08, 2018 at 08:56:21PM +0300, Alexey Brodkin wrote: > > > Depending on ABI "long long" type of a particular 32-bit CPU > > > might be aligned by either word (32-bits) or double word (64-bits). > > > Make sure "data" is really 64-bit aligned for any 32-bit CPU. > > > > > > At least for 32-bit ARC cores ABI requires "long long" types > > > to be aligned by normal 32-bit word. This makes "data" field aligned to > > > 12 bytes. Which is still OK as long as we use 32-bit data only. > > > > > > But once we want to use native atomic64_t type (i.e. when we use special > > > instructions LLOCKD/SCONDD for accessing 64-bit data) we easily hit > > > misaligned access exception. > > > > > > That's because even on CPUs capable of non-aligned data access LL/SC > > > instructions require strict alignment. > > > > > > Signed-off-by: Alexey Brodkin > > > Cc: Thomas Gleixner > > > Cc: stable@vger.kernel.org > > > --- > > > > > > Changes v1 -> v2: > > > > > > * Reworded commit message > > > * Inserted comment right in source [Thomas] > > > > > > drivers/base/devres.c | 8 ++++++-- > > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > Always use scripts/get_maintainer.pl to properly cc: the needed > > developer/maintainer. As it is, this patch is going to get dropped on > > the floor, sorry... > > Right I was way too relaxed dealing with very generic stuff which might get > not that much of attention as more narrow topics or subsystems. But anyways > get_maintainer.pl says you're the guy so do I need to do anything extra still or > it's OK for this time? Please resend it properly, it is not in my patch queue anywhere... greg k-h