From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ram Pai Subject: Re: [PATCH v13 16/24] selftests/vm: clear the bits in shadow reg when a pkey is freed. Date: Tue, 17 Jul 2018 09:03:51 -0700 Message-ID: <20180717160351.GD5790@ram.oc3035372033.ibm.com> References: <1528937115-10132-1-git-send-email-linuxram@us.ibm.com> <1528937115-10132-17-git-send-email-linuxram@us.ibm.com> <0b534ee8-5747-2811-745c-d87b3e720955@intel.com> Reply-To: Ram Pai Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <0b534ee8-5747-2811-745c-d87b3e720955@intel.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Dave Hansen Cc: linux-arch@vger.kernel.org, fweimer@redhat.com, x86@kernel.org, shuahkh@osg.samsung.com, mhocko@kernel.org, linux-mm@kvack.org, mingo@redhat.com, aneesh.kumar@linux.vnet.ibm.com, linux-kselftest@vger.kernel.org, bauerman@linux.vnet.ibm.com, msuchanek@suse.de, linuxppc-dev@lists.ozlabs.org List-Id: linux-arch.vger.kernel.org On Wed, Jun 20, 2018 at 08:07:31AM -0700, Dave Hansen wrote: > On 06/13/2018 05:45 PM, Ram Pai wrote: > > --- a/tools/testing/selftests/vm/protection_keys.c > > +++ b/tools/testing/selftests/vm/protection_keys.c > > @@ -577,7 +577,8 @@ int sys_pkey_free(unsigned long pkey) > > int ret = syscall(SYS_pkey_free, pkey); > > > > if (!ret) > > - shadow_pkey_reg &= clear_pkey_flags(pkey, PKEY_DISABLE_ACCESS); > > + shadow_pkey_reg &= clear_pkey_flags(pkey, > > + PKEY_DISABLE_ACCESS | PKEY_DISABLE_WRITE); > > dprintf1("%s(pkey=%ld) syscall ret: %d\n", __func__, pkey, ret); > > return ret; > > } > > Why did you introduce this code earlier and then modify it now? > > BTW, my original aversion to this code still stands. Have entirely got rid of this code in the new version. -- Ram Pai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:33480 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729657AbeGQQhZ (ORCPT ); Tue, 17 Jul 2018 12:37:25 -0400 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w6HG073x031185 for ; Tue, 17 Jul 2018 12:04:04 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2k9ggqh4m0-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 17 Jul 2018 12:04:04 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 17 Jul 2018 17:04:02 +0100 Date: Tue, 17 Jul 2018 09:03:51 -0700 From: Ram Pai Subject: Re: [PATCH v13 16/24] selftests/vm: clear the bits in shadow reg when a pkey is freed. Reply-To: Ram Pai References: <1528937115-10132-1-git-send-email-linuxram@us.ibm.com> <1528937115-10132-17-git-send-email-linuxram@us.ibm.com> <0b534ee8-5747-2811-745c-d87b3e720955@intel.com> MIME-Version: 1.0 In-Reply-To: <0b534ee8-5747-2811-745c-d87b3e720955@intel.com> Message-ID: <20180717160351.GD5790@ram.oc3035372033.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit Content-Disposition: inline Sender: linux-arch-owner@vger.kernel.org List-ID: To: Dave Hansen Cc: shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org, mingo@redhat.com, mhocko@kernel.org, bauerman@linux.vnet.ibm.com, fweimer@redhat.com, msuchanek@suse.de, aneesh.kumar@linux.vnet.ibm.com Message-ID: <20180717160351.-GJ0c08LlDbgKHlunLiWyi3yKISn7wXV8TrLjuRbGBE@z> On Wed, Jun 20, 2018 at 08:07:31AM -0700, Dave Hansen wrote: > On 06/13/2018 05:45 PM, Ram Pai wrote: > > --- a/tools/testing/selftests/vm/protection_keys.c > > +++ b/tools/testing/selftests/vm/protection_keys.c > > @@ -577,7 +577,8 @@ int sys_pkey_free(unsigned long pkey) > > int ret = syscall(SYS_pkey_free, pkey); > > > > if (!ret) > > - shadow_pkey_reg &= clear_pkey_flags(pkey, PKEY_DISABLE_ACCESS); > > + shadow_pkey_reg &= clear_pkey_flags(pkey, > > + PKEY_DISABLE_ACCESS | PKEY_DISABLE_WRITE); > > dprintf1("%s(pkey=%ld) syscall ret: %d\n", __func__, pkey, ret); > > return ret; > > } > > Why did you introduce this code earlier and then modify it now? > > BTW, my original aversion to this code still stands. Have entirely got rid of this code in the new version. -- Ram Pai