From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ram Pai Subject: Re: [PATCH v13 18/24] selftests/vm: fix an assertion in test_pkey_alloc_exhaust() Date: Tue, 17 Jul 2018 09:08:28 -0700 Message-ID: <20180717160828.GF5790@ram.oc3035372033.ibm.com> References: <1528937115-10132-1-git-send-email-linuxram@us.ibm.com> <1528937115-10132-19-git-send-email-linuxram@us.ibm.com> <55227442-a573-62b1-3206-1f3065a4b55f@intel.com> Reply-To: Ram Pai Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <55227442-a573-62b1-3206-1f3065a4b55f@intel.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Dave Hansen Cc: linux-arch@vger.kernel.org, fweimer@redhat.com, x86@kernel.org, shuahkh@osg.samsung.com, mhocko@kernel.org, linux-mm@kvack.org, mingo@redhat.com, aneesh.kumar@linux.vnet.ibm.com, linux-kselftest@vger.kernel.org, bauerman@linux.vnet.ibm.com, msuchanek@suse.de, linuxppc-dev@lists.ozlabs.org List-Id: linux-arch.vger.kernel.org On Wed, Jun 20, 2018 at 08:11:07AM -0700, Dave Hansen wrote: > On 06/13/2018 05:45 PM, Ram Pai wrote: > > /* > > - * There are 16 pkeys supported in hardware. Three are > > - * allocated by the time we get here: > > - * 1. The default key (0) > > - * 2. One possibly consumed by an execute-only mapping. > > - * 3. One allocated by the test code and passed in via > > - * 'pkey' to this function. > > - * Ensure that we can allocate at least another 13 (16-3). > > + * There are NR_PKEYS pkeys supported in hardware. arch_reserved_keys() > > + * are reserved. One of which is the default key(0). One can be taken > > + * up by an execute-only mapping. > > + * Ensure that we can allocate at least the remaining. > > */ > > - pkey_assert(i >= NR_PKEYS-3); > > + pkey_assert(i >= (NR_PKEYS-arch_reserved_keys()-1)); > > We recently had a bug here. I fixed it and left myself a really nice > comment so I and others wouldn't screw it up in the future. > > Does this kill my nice, new comment? part of your nice comment has been moved into the header file. The arch specific header file explains where and how the reserved keys are used. -- Ram Pai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:55136 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729600AbeGQQmF (ORCPT ); Tue, 17 Jul 2018 12:42:05 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w6HG5sOB111126 for ; Tue, 17 Jul 2018 12:08:42 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0b-001b2d01.pphosted.com with ESMTP id 2k9k2vhsde-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 17 Jul 2018 12:08:41 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 17 Jul 2018 17:08:40 +0100 Date: Tue, 17 Jul 2018 09:08:28 -0700 From: Ram Pai Subject: Re: [PATCH v13 18/24] selftests/vm: fix an assertion in test_pkey_alloc_exhaust() Reply-To: Ram Pai References: <1528937115-10132-1-git-send-email-linuxram@us.ibm.com> <1528937115-10132-19-git-send-email-linuxram@us.ibm.com> <55227442-a573-62b1-3206-1f3065a4b55f@intel.com> MIME-Version: 1.0 In-Reply-To: <55227442-a573-62b1-3206-1f3065a4b55f@intel.com> Message-ID: <20180717160828.GF5790@ram.oc3035372033.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit Content-Disposition: inline Sender: linux-arch-owner@vger.kernel.org List-ID: To: Dave Hansen Cc: shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org, mingo@redhat.com, mhocko@kernel.org, bauerman@linux.vnet.ibm.com, fweimer@redhat.com, msuchanek@suse.de, aneesh.kumar@linux.vnet.ibm.com Message-ID: <20180717160828.bORm1kOnbFvNlDRa4UMkLsqpPgFMN2_cDbu6zEetDxE@z> On Wed, Jun 20, 2018 at 08:11:07AM -0700, Dave Hansen wrote: > On 06/13/2018 05:45 PM, Ram Pai wrote: > > /* > > - * There are 16 pkeys supported in hardware. Three are > > - * allocated by the time we get here: > > - * 1. The default key (0) > > - * 2. One possibly consumed by an execute-only mapping. > > - * 3. One allocated by the test code and passed in via > > - * 'pkey' to this function. > > - * Ensure that we can allocate at least another 13 (16-3). > > + * There are NR_PKEYS pkeys supported in hardware. arch_reserved_keys() > > + * are reserved. One of which is the default key(0). One can be taken > > + * up by an execute-only mapping. > > + * Ensure that we can allocate at least the remaining. > > */ > > - pkey_assert(i >= NR_PKEYS-3); > > + pkey_assert(i >= (NR_PKEYS-arch_reserved_keys()-1)); > > We recently had a bug here. I fixed it and left myself a really nice > comment so I and others wouldn't screw it up in the future. > > Does this kill my nice, new comment? part of your nice comment has been moved into the header file. The arch specific header file explains where and how the reserved keys are used. -- Ram Pai