From: Christoph Hellwig <hch@lst.de>
To: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Cc: linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org,
Vineet Gupta <Vineet.Gupta1@synopsys.com>,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
hch@lst.de
Subject: Re: [PATCH] ARC: fix broken noncoherent cache ops
Date: Thu, 26 Jul 2018 11:11:55 +0200 [thread overview]
Message-ID: <20180726091155.GA24209@lst.de> (raw)
In-Reply-To: <20180724141302.4305-1-Eugeniy.Paltsev@synopsys.com>
On Tue, Jul 24, 2018 at 05:13:02PM +0300, Eugeniy Paltsev wrote:
> All DMA devices on ARC haven't worked with SW cache control
> since commit a8eb92d02dd7 ("arc: fix arc_dma_{map,unmap}_page")
> This happens because we don't check direction argument at all in
> new implementation. Fix that.
>
> Fixies: commit a8eb92d02dd7 ("arc: fix arc_dma_{map,unmap}_page")
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Looks sensible. Might be worth explaining that ARC can speculate
into the areas under DMA, which is why this is required.
next prev parent reply other threads:[~2018-07-26 9:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 14:13 [PATCH] ARC: fix broken noncoherent cache ops Eugeniy Paltsev
2018-07-24 14:13 ` Eugeniy Paltsev
2018-07-24 18:34 ` Vineet Gupta
2018-07-24 18:34 ` Vineet Gupta
2018-07-26 9:11 ` Christoph Hellwig [this message]
2018-07-26 9:11 ` Christoph Hellwig
2018-07-26 19:00 ` Vineet Gupta
2018-07-26 19:00 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180726091155.GA24209@lst.de \
--to=hch@lst.de \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox