From: Christoph Hellwig <hch@lst.de>
To: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Cc: linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org,
Vineet Gupta <Vineet.Gupta1@synopsys.com>,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
hch@lst.de
Subject: Re: [PATCH v2 4/4] ARC: don't check for HIGHMEM pages in arch_dma_alloc
Date: Tue, 31 Jul 2018 10:08:57 +0200 [thread overview]
Message-ID: <20180731080857.GB23303@lst.de> (raw)
In-Reply-To: <20180730162636.3556-5-Eugeniy.Paltsev@synopsys.com>
On Mon, Jul 30, 2018 at 07:26:36PM +0300, Eugeniy Paltsev wrote:
> __GFP_HIGHMEM flag is cleared by upper layer functions
> (in include/linux/dma-mapping.h) so we'll never get a
> __GFP_HIGHMEM flag in arch_dma_alloc gfp argument.
> That's why alloc_pages will never return highmem page
> here.
>
> Get rid of highmem pages handling and cleanup arch_dma_alloc
> and arch_dma_free functions.
>
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2018-07-31 8:08 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 16:26 [PATCH v2 0/4] ARC: allow to use IOC and non-IOC DMA devices simultaneously Eugeniy Paltsev
2018-07-30 16:26 ` Eugeniy Paltsev
2018-07-30 16:26 ` [PATCH v2 1/4] ARC: DTS: mark DMA devices connected through IOC port as dma-coherent Eugeniy Paltsev
2018-07-30 16:26 ` Eugeniy Paltsev
2018-07-30 16:26 ` [PATCH v2 2/4] ARC: allow to use IOC and non-IOC DMA devices simultaneously Eugeniy Paltsev
2018-07-30 16:26 ` Eugeniy Paltsev
2018-08-13 16:24 ` Vineet Gupta
2018-08-13 16:24 ` Vineet Gupta
2018-08-13 17:08 ` Eugeniy Paltsev
2018-08-13 17:08 ` Eugeniy Paltsev
2018-08-20 22:34 ` Vineet Gupta
2018-08-20 22:34 ` Vineet Gupta
2018-08-22 18:40 ` Eugeniy Paltsev
2018-08-22 18:40 ` Eugeniy Paltsev
2018-08-23 14:05 ` hch
2018-08-23 14:05 ` hch
2018-09-04 18:13 ` Vineet Gupta
2018-09-04 18:13 ` Vineet Gupta
2018-07-30 16:26 ` [PATCH v2 3/4] ARC: IOC: panic if both IOC and ZONE_HIGHMEM enabled Eugeniy Paltsev
2018-07-30 16:26 ` Eugeniy Paltsev
2018-07-30 16:26 ` [PATCH v2 4/4] ARC: don't check for HIGHMEM pages in arch_dma_alloc Eugeniy Paltsev
2018-07-30 16:26 ` Eugeniy Paltsev
2018-07-31 8:08 ` Christoph Hellwig [this message]
2018-07-31 8:08 ` Christoph Hellwig
2018-08-13 16:19 ` [PATCH v2 0/4] ARC: allow to use IOC and non-IOC DMA devices simultaneously Vineet Gupta
2018-08-13 16:19 ` Vineet Gupta
2018-08-13 17:27 ` Eugeniy Paltsev
2018-08-13 17:27 ` Eugeniy Paltsev
2018-08-13 17:39 ` Vineet Gupta
2018-08-13 17:39 ` Vineet Gupta
2018-09-04 20:14 ` Vineet Gupta
2018-09-04 20:14 ` Vineet Gupta
2018-09-04 21:11 ` Christoph Hellwig
2018-09-04 21:11 ` Christoph Hellwig
2018-09-04 21:34 ` Vineet Gupta
2018-09-04 21:34 ` Vineet Gupta
2018-09-04 21:38 ` Christoph Hellwig
2018-09-04 21:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731080857.GB23303@lst.de \
--to=hch@lst.de \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).